Displaying 11 results from an estimated 11 matches for "ope_encoder_deferred_init_with_map".
2018 Mar 20
2
[PATCH] Support for Ambisonics
...39;s aren't in
> the public API. Right now there are other functions with a leading
> underscore, so we'll have to fix them as well (not in this patch of
> course). Maybe an "opeint_" prefix would do the job here (unless anyone
> has a better idea)?
>
> > +int ope_encoder_deferred_init_with_mapping(OggOpusEnc *enc, int
> > family, int streams,
> > int coupled_streams, const unsigned char *mapping) {
> > int ret;
> > int i;
> >
> > This code is allowing family 253 for a deferred init, but does not
> > create a projection encoder in that...
2018 Mar 20
2
[PATCH] Support for Ambisonics
...re; the family field in this structure is not actually used
except to compare the value to 253 to determine whether to use the
"ms" or "pr" pointer. It would be simpler to omit the incorrectly-set
family field and just check whether the corresponding pointer is
non-NULL.
-int ope_encoder_deferred_init_with_mapping(OggOpusEnc *enc, int
family, int streams,
+int ope_encoder_deferred_init_with_mapping(OggOpusEnc *enc, int
family, int streams,
int coupled_streams, const unsigned char *mapping) {
int ret;
int i;
- OpusMSEncoder *st;
+ OpusGenericEncoder *st;
if (enc->st!=NULL) {
return...
2018 Mar 20
2
[PATCH] Support for Ambisonics
...now there are other functions with a leading
> > underscore, so we'll have to fix them as well (not in this patch of
> > course). Maybe an "opeint_" prefix would do the job here (unless
> anyone
> > has a better idea)?
> >
> > > +int ope_encoder_deferred_init_with_mapping(OggOpusEnc *enc, int
> > > family, int streams,
> > > int coupled_streams, const unsigned char *mapping) {
> > > int ret;
> > > int i;
> > >
> > > This code is allowing family 253 for a deferred init, but d...
2018 Mar 22
2
[PATCH] Support for Ambisonics
...underscore, so we'll have to fix them as well (not in this
> > patch of
> > > course). Maybe an "opeint_" prefix would do the job here
> > (unless anyone
> > > has a better idea)?
> > >
> > > > +int ope_encoder_deferred_init_with_mapping(OggOpusEnc *enc,
> int
> > > > family, int streams,
> > > > int coupled_streams, const unsigned char *mapping) {
> > > > int ret;
> > > > int i;
> > > >
> > > >...
2018 Mar 26
3
[PATCH] Support for Ambisonics
...l (not in this
>>> > patch of
>>> > > course). Maybe an "opeint_" prefix would do the job here
>>> > (unless anyone
>>> > > has a better idea)?
>>> > >
>>> > > > +int ope_encoder_deferred_init_with_mapping(OggOpusEnc
>>> *enc, int
>>> > > > family, int streams,
>>> > > > int coupled_streams, const unsigned char *mapping) {
>>> > > > int ret;
>>> > > > int i;
>>> >...
2018 Mar 20
0
[PATCH] Support for Ambisonics
..._ prefix for functions that's aren't in
the public API. Right now there are other functions with a leading
underscore, so we'll have to fix them as well (not in this patch of
course). Maybe an "opeint_" prefix would do the job here (unless anyone
has a better idea)?
> +int ope_encoder_deferred_init_with_mapping(OggOpusEnc *enc, int
> family, int streams,
> int coupled_streams, const unsigned char *mapping) {
> int ret;
> int i;
>
> This code is allowing family 253 for a deferred init, but does not
> create a projection encoder in that case, so it looks like it will
>...
2018 Mar 20
0
[PATCH] Support for Ambisonics
...t; the public API. Right now there are other functions with a leading
> underscore, so we'll have to fix them as well (not in this patch of
> course). Maybe an "opeint_" prefix would do the job here (unless anyone
> has a better idea)?
>
> > +int ope_encoder_deferred_init_with_mapping(OggOpusEnc *enc, int
> > family, int streams,
> > int coupled_streams, const unsigned char *mapping) {
> > int ret;
> > int i;
> >
> > This code is allowing family 253 for a deferred init, but does not
> > create a...
2018 Mar 22
0
[PATCH] Support for Ambisonics
...h a leading
> > underscore, so we'll have to fix them as well (not in this
> patch of
> > course). Maybe an "opeint_" prefix would do the job here
> (unless anyone
> > has a better idea)?
> >
> > > +int ope_encoder_deferred_init_with_mapping(OggOpusEnc *enc, int
> > > family, int streams,
> > > int coupled_streams, const unsigned char *mapping) {
> > > int ret;
> > > int i;
> > >
> > > This code is allowing family 253 fo...
2018 Mar 26
0
[PATCH] Support for Ambisonics
...have to fix them as well (not in this
>> > patch of
>> > > course). Maybe an "opeint_" prefix would do the job here
>> > (unless anyone
>> > > has a better idea)?
>> > >
>> > > > +int ope_encoder_deferred_init_with_mapping(OggOpusEnc
>> *enc, int
>> > > > family, int streams,
>> > > > int coupled_streams, const unsigned char *mapping) {
>> > > > int ret;
>> > > > int i;
>> > > >
>...
2018 Jul 07
0
[PATCH] Support for Ambisonics
...> course). Maybe an "opeint_" prefix would do the job here
>>>>>>> > (unless anyone
>>>>>>> > > has a better idea)?
>>>>>>> > >
>>>>>>> > > > +int ope_encoder_deferred_init_with_mapping(OggOpusEnc
>>>>>>> *enc, int
>>>>>>> > > > family, int streams,
>>>>>>> > > > int coupled_streams, const unsigned char
>>>>>>> *mapping) {
>>>>>>> >...
2018 Mar 19
3
[PATCH] Support for Ambisonics
Hi Drew,
I think the libopusenc patch is better, but there's still a few issues left:
1) The static MAX_PACKET_BUFFER_SIZE value is still problematic because
if you link libopusenc with a new version of libopus that supports
higher order projection or just more projection channels for order 3,
then you will overflow the buffer. I think what you'd want is a
_ope_opus_header_get_size() call