search for: opaquetyid

Hi llvm, 1) The lib/VMCore/Verifier.cpp in 2.7 implements Verifier::VerifyType, which is empty in 2.6. I noticed that it does not check all types, for example, UnionTyID, OpaqueTyID, LabelTyID, MetadataTyID and etc are ignored in the 'default' branch. Does it mean we dont need to check them? Another question is: How much does Verifier.cpp check statically? Can I take it as a type checker for SSA? Is there any static semantics that has not been checked yet? 2) visitFr...

...isallows function types, void, and opaque: 236 inline bool isFirstClassType() const { 237 // There are more first-class kinds than non-first-class kinds, so a 238 // negative test is simpler than a positive one. 239 return ID != FunctionTyID && ID != VoidTyID && ID != OpaqueTyID; 240 } Is struct typ also a first class type? -- Jianzhou

On Mar 6, 2010, at 9:13 AM, Jianzhou Zhao wrote: > Hi llvm, > > 1) The lib/VMCore/Verifier.cpp in 2.7 implements Verifier::VerifyType, > which is empty in 2.6. I noticed that it does not check all types, > for example, UnionTyID, OpaqueTyID, LabelTyID, MetadataTyID > and etc are ignored in the 'default' branch. Does it mean we dont > need to check them? They are leaf types (just like integer type), there is nothing to check. > Another question is: How much does Verifier.cpp check statically? > Can I take it as a...

Jianzhou Zhao wrote: > Hi llvm, > > 1) The lib/VMCore/Verifier.cpp in 2.7 implements Verifier::VerifyType, > which is empty in 2.6. I noticed that it does not check all types, > for example, UnionTyID, OpaqueTyID, LabelTyID, MetadataTyID > and etc are ignored in the 'default' branch. Does it mean we dont > need to check them? We do need to check union. I'll add that. The others don't need a case because they don't contain subtypes; it's impossible to have an illegal label ty...

...ontext &Context, + const Type *type, ...) END_WITH_NULL; Please update the comments. Also, if you disallow empty unions here, you don't need to pass a context. +++ include/llvm/Type.h (working copy) @@ -86,6 +86,7 @@ PointerTyID, ///< 12: Pointers OpaqueTyID, ///< 13: Opaque: type with unknown structure VectorTyID, ///< 14: SIMD 'packed' format, or other vector type + UnionTyID, ///< 15: Unions Please put this up next to Struct for simplicity, the numbering here doesn't need to be stable. The numbering in...

...pple.com> wrote: > > On Mar 6, 2010, at 9:13 AM, Jianzhou Zhao wrote: > >> Hi llvm, >> >> 1) The lib/VMCore/Verifier.cpp in 2.7 implements Verifier::VerifyType, >> which is empty in 2.6. I noticed that it does not check all types, >> for example, UnionTyID, OpaqueTyID, LabelTyID, MetadataTyID >> and etc are ignored in the 'default' branch. Does it mean we dont >> need to check them? > > They are leaf types (just like integer type), there is nothing to check. > >> Another question is: How much does Verifier.cpp check statically?...

..., Nick Lewycky <nicholas at mxc.ca> wrote: > Jianzhou Zhao wrote: >> >> Hi llvm, >> >> 1) The lib/VMCore/Verifier.cpp in 2.7 implements Verifier::VerifyType, >> which is empty in 2.6. I noticed that it does not check all types, >> for example, UnionTyID, OpaqueTyID, LabelTyID, MetadataTyID >> and etc are ignored in the 'default' branch. Does it mean we dont >> need to check them? > > We do need to check union. I'll add that. The others don't need a case > because they don't contain subtypes; it's impossible to have...

This patch adds a UnionType to DerivedTypes.h. It also adds code to the bitcode reader / writer and the assembly parser for the new type, as well as a tiny .ll test file in test/Assembler. It does not contain any code related to code generation or type layout - I wanted to see if this much was acceptable before I proceeded any further. Unlike my previous patch, in which the Union type was

...const Type *type, ...) END_WITH_NULL; > > Please update the comments. Also, if you disallow empty unions here, you > don't need to pass a context. > > > +++ include/llvm/Type.h (working copy) > @@ -86,6 +86,7 @@ > PointerTyID, ///< 12: Pointers > OpaqueTyID, ///< 13: Opaque: type with unknown structure > VectorTyID, ///< 14: SIMD 'packed' format, or other vector type > + UnionTyID, ///< 15: Unions > > Please put this up next to Struct for simplicity, the numbering here > doesn't need to be st...

Here is the bulk of the sanitizing. My residual doubts center around the question whether we still do/want to support (un)compressed *byte*code in 2.0/2.1. I need a definitive word on this to proceed. My understanding is that bytecode is already gone, but there are still some functions/enums that really deal with *byte*code (instead of *bit*code). I did not touch those areas, so the attached