search for: op_nchannels_max

Friendly ping for supporting ambisonics in opus-tools & opusfile Please LMK any ?s you might have. Cheers, Drew -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.xiph.org/pipermail/opus/attachments/20180410/fd4a3709/attachment-0001.html> -------------- next part -------------- A non-text attachment was scrubbed... Name:

...ixing matrix equal to the channel count, which doesn't make much sense. There are a few errors in the opus_head_projection_parse() implementation. For mapping family 253 you don't validate that the packet has at least 21 bytes before reading bytes 19 and 20. Although you have bumped up OP_NCHANNELS_MAX to 18, op_validate_ambisonic_channels() will actually succeed for channel counts much larger than that. I didn't see anything that would then prevent us from trying to decode such streams (and overflowing the statically-sized buffers based on OP_NCHANNELS_MAX). I think this should return O...

...urce). > > Is OPUS_DEMIXING_MATRIX_SIZE_MAX future-proof? I seem to recall much > larger matrices being allowed according to the spec. You'll note that > OPUS_CHANNEL_COUNT_MAX is 255, even though opusfile currently only supports > mappings with up to 8 channels (see the private OP_NCHANNELS_MAX used > internally, for comparison). The idea was that I did not want to break ABI > when we added support for new mappings. > > I will change the define to make it future-proof as well as make it a separate struct (OpusHeadExt, for example) and make the call the opus_head_parse_ext() in...

Hello all, Attached are patches for libopusenc, opusfile and opus-tools in order to provide support for Ambisonics and the Projection API for encoding/decoding channel mapping 253 and 254. Please feel free to ask any questions or give any feedback you might have. :) Cheers, Drew -------------- next part -------------- An HTML attachment was scrubbed... URL:

...o be rebuilt from source). Is OPUS_DEMIXING_MATRIX_SIZE_MAX future-proof? I seem to recall much larger matrices being allowed according to the spec. You'll note that OPUS_CHANNEL_COUNT_MAX is 255, even though opusfile currently only supports mappings with up to 8 channels (see the private OP_NCHANNELS_MAX used internally, for comparison). The idea was that I did not want to break ABI when we added support for new mappings. One way to go about this without breaking ABI might be to add support for "extended" mapping data. I.e., we could create an opus_head_parse_ext() that takes an extra...