Displaying 6 results from an estimated 6 matches for "op_fetch_and_process_page".
2017 Nov 20
0
[PATCH 2/2] op_fetch_and_process_page: fix int64 overflow
check for overflow with a negative diff
---
src/opusfile.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/src/opusfile.c b/src/opusfile.c
index df326af..2bef277 100644
--- a/src/opusfile.c
+++ b/src/opusfile.c
@@ -2078,7 +2078,10 @@ static int op_fetch_and_process_page(OggOpusFile *_of,
&&OP_LIKELY(diff<total_duration)){
cur_packet_gp=prev_packet_gp;
for(pi=0;pi<op_count;pi++){
- diff=durations[pi]-diff;
+ /*Check for overflow.*/
+ if(diff<0&&OP_UNLIKELY(OP_INT64_MAX+diff<...
2017 Nov 20
7
[PATCH 0/2] libopusfile int64 overflows
Just an attempt to avoid overflows with an explicit check, I don't know if
there's a better way to identify corrupt input here.
James Zern (2):
op_pcm_seek: fix int64 overflow
op_fetch_and_process_page: fix int64 overflow
src/opusfile.c | 11 +++++++++--
1 file changed, 9 insertions(+), 2 deletions(-)
--
2.15.0.448.gf294e3d99a-goog
2017 Dec 07
2
[PATCH 0/2] libopusfile int64 overflows
...at 1:07 PM, James Zern <jzern at google.com> wrote:
>> Just an attempt to avoid overflows with an explicit check, I don't know if
>> there's a better way to identify corrupt input here.
>>
>> James Zern (2):
>> op_pcm_seek: fix int64 overflow
>> op_fetch_and_process_page: fix int64 overflow
>>
>> src/opusfile.c | 11 +++++++++--
>> 1 file changed, 9 insertions(+), 2 deletions(-)
>>
>
> Any comments on these?
>
ping.
>> --
>> 2.15.0.448.gf294e3d99a-goog
>>
2017 Dec 07
0
[PATCH 0/2] libopusfile int64 overflows
...;jzern at google.com> wrote:
>>> Just an attempt to avoid overflows with an explicit check, I don't know if
>>> there's a better way to identify corrupt input here.
>>>
>>> James Zern (2):
>>> op_pcm_seek: fix int64 overflow
>>> op_fetch_and_process_page: fix int64 overflow
>>>
>>> src/opusfile.c | 11 +++++++++--
>>> 1 file changed, 9 insertions(+), 2 deletions(-)
>>>
>>
>> Any comments on these?
>>
>
> ping.
Sorry, I can't reply to the original patches because I didn't actual...
2017 Nov 28
0
[PATCH 0/2] libopusfile int64 overflows
On Mon, Nov 20, 2017 at 1:07 PM, James Zern <jzern at google.com> wrote:
> Just an attempt to avoid overflows with an explicit check, I don't know if
> there's a better way to identify corrupt input here.
>
> James Zern (2):
> op_pcm_seek: fix int64 overflow
> op_fetch_and_process_page: fix int64 overflow
>
> src/opusfile.c | 11 +++++++++--
> 1 file changed, 9 insertions(+), 2 deletions(-)
>
Any comments on these?
> --
> 2.15.0.448.gf294e3d99a-goog
>
2017 Dec 07
1
[PATCH 0/2] libopusfile int64 overflows
...han adding a custom overflow check here, we should use
> if(OP_LIKELY(!op_granpos_diff(&discard_count,target_gp,gp))) directly
> (because _pcm_offset == (target_gp - pcm_start) and diff == (gp -
> pcm_start).
>
This works.
> [...]
>
>> @@ -2078,7 +2078,10 @@ static int op_fetch_and_process_page(OggOpusFile
>> *_of,
>> &&OP_LIKELY(diff<total_duration)){
>> cur_packet_gp=prev_packet_gp;
>> for(pi=0;pi<op_count;pi++){
>> - diff=durations[pi]-diff;
>> + /*Check for overflow.*/
>> +...