search for: ondemand_can_multi_conn

...#39;t > advertising stuff that can't pass open? Yes, that's a bug. Also we should skip filenames containg ':' anywhere. > >+/* Since clients that want multi-conn should all pass the same export > >+ * name, this is safe. > >+ */ > >+static int > >+ondemand_can_multi_conn (void *handle) > >+{ > >+ return 1; > >+} > > Hmm. Are you permitting multiple clients to the same export, or did > you decide that was too likely to cause fs corruption, and locking > out users on the same export? The docs above said otherwise, making > this loo...

...my libnbd stuff settles, I'll be able to get back to finalizing how the .list_exports stuff should work in nbdkit. >>> +/* Since clients that want multi-conn should all pass the same export >>> + * name, this is safe. >>> + */ >>> +static int >>> +ondemand_can_multi_conn (void *handle) >>> +{ >>> + return 1; >>> +} >> >> Hmm. Are you permitting multiple clients to the same export, or did >> you decide that was too likely to cause fs corruption, and locking >> out users on the same export? The docs above said othe...

...t_error ("readdir: %s: %m", dir); + return -1; + } + + return 0; +} + +struct handle { + int fd; + int64_t size; + const char *exportname; + bool can_punch_hole; +}; + +/* Since clients that want multi-conn should all pass the same export + * name, this is safe. + */ +static int +ondemand_can_multi_conn (void *handle) +{ + return 1; +} + +static int +ondemand_can_trim (void *handle) +{ +#ifdef FALLOC_FL_PUNCH_HOLE + return 1; +#else + return 0; +#endif +} + +static int +ondemand_can_fua (void *handle) +{ + return NBDKIT_FUA_NATIVE; +} + +/* This creates and runs the full "mkfs" (or w...

...return 0; > +} > + > +struct handle { > + int fd; > + int64_t size; > + const char *exportname; > + bool can_punch_hole; > +}; > + > +/* Since clients that want multi-conn should all pass the same export > + * name, this is safe. > + */ > +static int > +ondemand_can_multi_conn (void *handle) > +{ > + return 1; > +} Hmm. Are you permitting multiple clients to the same export, or did you decide that was too likely to cause fs corruption, and locking out users on the same export? The docs above said otherwise, making this look wrong. > + > +static int &...

...export name is valid. */ if (strlen (h->exportname) > NAME_MAX || @@ -621,6 +627,7 @@ static struct nbdkit_plugin plugin = { .get_ready = ondemand_get_ready, .list_exports = ondemand_list_exports, + .default_export = ondemand_default_export, .can_multi_conn = ondemand_can_multi_conn, .can_trim = ondemand_can_trim, diff --git a/filters/tls-fallback/tls-fallback.c b/filters/tls-fallback/tls-fallback.c index 822748b4..0fcc2bcf 100644 --- a/filters/tls-fallback/tls-fallback.c +++ b/filters/tls-fallback/tls-fallback.c @@ -76,6 +76,15 @@ tls_fallback_get_ready (nbdkit_ne...

...eturn -1; - } - - return 0; -} - struct handle { int fd; int64_t size; @@ -624,8 +575,6 @@ static struct nbdkit_plugin plugin = { .magic_config_key = "size", .get_ready = ondemand_get_ready, - .list_exports = ondemand_list_exports, - .can_multi_conn = ondemand_can_multi_conn, .can_trim = ondemand_can_trim, .can_fua = ondemand_can_fua, diff --git a/plugins/sh/methods.c b/plugins/sh/methods.c index 8e2e4256..bd045b0c 100644 --- a/plugins/sh/methods.c +++ b/plugins/sh/methods.c @@ -225,112 +225,6 @@ struct sh_handle { int can_zero; }; -/* If...

If you're following nbdkit development upstream you'll have seen that we are still making changes to the .list_exports and related APIs. The current .list_exports API upstream is not how it will look finally. The latest set of proposals was here: https://www.redhat.com/archives/libguestfs/2020-August/thread.html#00330 At the same time I'd like to do an nbdkit 1.22 (stable) release.

More patches on the way for improving .list_exports signature and adding .export_description, but this is the promised code showing why nbdkit_string_intern is useful. Patch 4 is somewhat RFC: we could either add new API to take the boilerplate from: foo_config(const char *key, const char *value) { if (strcmp (key, "file") == 0) { CLEANUP_FREE char *tmp = nbdkit_realpath (value);

This is a revision of my .default_export work, plus new work on .export_descriptions and a new exportname filter. I think it is now ready to check in. Things I'd still like in 1.22: - the file plugin should implement .list_exports (patch already posted, but it needs rebasing on this series) - the ext2 filter should override .list_exports when in exportname mode - the nbd plugin should be

It's been several weeks since I posted v2 (I got distracted by improving libnbd to better test things, which in turn surfaced some major memory leak problems in nbdsh that are now fixed). Many of the patches are minor rebases from v2, with the biggest changes being fallout from: - patch 2: rename nbdkit_add_default_export to nbdkit_use_default_export - overall: this missed 1.22, so update