search for: once_had_no_optargs

Hi, This is the part1 of improving btrfs support. This series adds missing parameters to btrfs_subvolume_snapshot and btrfs_subvolume_create, and adds two new API btrfs_subvolume_get_default and btrfs_subvolume_show. Other parts will follow. Regards, Hu changes: v2: - add 'once_had_no_optargs = true' for btrfs_subvolume_snapshot and btrfs_subvolume_create - improved documents for btrfs_subvolume_snapshot and btrfs_subvolume_create - coding style change (patch 5) - add analyze_line (patch 5) - rebase Hu Tao (5): btrfs: add optional parameter `ro' to btrfs_subv...

Here is a preliminary fix for this bug. I'm running the test suite on this now. Rich.

...e"; Pathname "dest"], []; > + style = RErr, [Pathname "source"; Pathname "dest"], [OBool "ro"]; > proc_nr = Some 322; > optional = Some "btrfs"; camel_name = "BTRFSSubvolumeSnapshot"; > tests = [ You must set once_had_no_optargs = true for this action, as it currently has no optional arguments; see generator/README. -- Pino Toscano

..., []; > + style = RErr, [Pathname "dest"], [OString "qgroupid"]; > proc_nr = Some 324; > optional = Some "btrfs"; camel_name = "BTRFSSubvolumeCreate"; > shortdesc = "create a btrfs subvolume"; Like in patch 2, you need once_had_no_optargs = true for this as well. > longdesc = "\ > Create a btrfs subvolume. The C<dest> argument is the destination > -directory and the name of the subvolume, in the form C</path/to/dest/name>." }; > +directory and the name of the subvolume, in the form C</pat...

...required arguments. Therefore we can rename these as non-opts functions (add-drive, mkfs, ntfsresize) and use the same machinery above to generate the "*-opts" variants automatically. Existing callers will not be affected. The patches in this series do just this: 1/6, 2/6: Adds a 'once_had_no_optargs' flag to the generator, allowing functions to be transitioned from non-opts -> opts. This flag must be set to true when this is done so the corresponding backwards- compatibility functions can be generated. 3/6: Adds *-opts aliases in non-C languages. This ensures that non-C bindings won&...

...le = RErr, [String (Device, "device"); String (Key, "key"); String (PlainString, "mapname")], []; + style = RErr, [String (Device, "device"); String (Key, "key"); String (PlainString, "mapname")], [OBool "allowdiscards"]; + once_had_no_optargs = true; optional = Some "luks"; shortdesc = "open a LUKS-encrypted block device"; longdesc = "\ diff --git a/gobject/Makefile.inc b/gobject/Makefile.inc index 067f861a9..a7b856bee 100644 --- a/gobject/Makefile.inc +++ b/gobject/Makefile.inc @@ -86,6 +86,7 @@...

..."], [OString "qgroupid"]; > > > proc_nr = Some 324; > > > optional = Some "btrfs"; camel_name = "BTRFSSubvolumeCreate"; > > > shortdesc = "create a btrfs subvolume"; > > > > Like in patch 2, you need once_had_no_optargs = true for this as well. > > Yes. > > > > > > longdesc = "\ > > > Create a btrfs subvolume. The C<dest> argument is the destination > > > -directory and the name of the subvolume, in the form C</path/to/dest/name>." }; > &...

...ot;; OStringList "excludes"]; + style = RErr, [String "directory"; FileOut "tarfile"], [OString "compress"; OBool "numericowner"; OStringList "excludes"; OBool "xattrs"; OBool "selinux"]; proc_nr = Some 70; once_had_no_optargs = true; cancellable = true; @@ -4854,6 +4854,14 @@ wildcards. If set to true, the output tar file will contain UID/GID numbers instead of user/group names. +=item C<xattrs> + +If set to true, extended attributes are saved in the output tar. + +=item C<selinux> + +If set to true...

...ile>, C<guestfs_is_dir>, C<guestfs_stat>." }; { defaults with name = "is_file"; added = (0, 0, 8); style = RBool "fileflag", [String (Pathname, "path")], [OBool "followsymlinks"]; + impl = OCaml "Is.is_file"; once_had_no_optargs = true; tests = [ InitISOFS, Always, TestResultTrue ( @@ -2138,6 +2139,7 @@ See also C<guestfs_stat>." }; { defaults with name = "is_dir"; added = (0, 0, 8); style = RBool "dirflag", [String (Pathname, "path")], [OBool "followsy...

...rgs <> [] then ( @@ -705,7 +705,7 @@ extern GUESTFS_DLL_PUBLIC void *guestfs_next_private (guestfs_h *g, const char * in let generate_all_headers = List.iter ( - fun ({ name = name; style = ret, args, _ } as f) -> + fun ({ name; style = ret, args, _ } as f) -> (* If once_had_no_optargs is set, then we need to generate a * <name>_opts variant, plus a backwards-compatible wrapper * called just <name> with no optargs. @@ -785,7 +785,7 @@ and generate_internal_actions_h () = pr "\n"; List.iter ( - fun { c_name = c_name; style = style }...

...String "localdir"], []; + style = RErr, [Pathname "remotepath"; String "localdir"], [OBool "numericowner"; OStringList "excludes"; OBool "xattrs"; OBool "selinux"; OBool "acls"]; visibility = VPublicNoFish; + once_had_no_optargs = true; shortdesc = "copy remote files or directories out of an image"; longdesc = "\ C<guestfs_copy_out> copies remote files or directories recursively @@ -3449,7 +3450,39 @@ To download to the current directory, use C<.> as in: C<guestfs_copy_out> /...

The following patch attempts to implement sparsification of LUKS-encrypted partitions. It uses lsblk to pair the underlying LUKS block device with its mapped name. Also, --allow-discards was added by default to luks_open(). There are several potential issues that I can think of: 1) If and entire device is encrypted (not just one of more partitions), the lsblk trick might not work. 2) The

...ot; }; { defaults with name = "umount"; - style = RErr, [String "pathordevice"], []; + style = RErr, [String "pathordevice"], [OBool "force"; OBool "lazyunmount"]; proc_nr = Some 45; fish_alias = ["unmount"]; + once_had_no_optargs = true; tests = [ InitEmpty, Always, TestOutputListOfDevices ( [["part_disk"; "/dev/sda"; "mbr"]; @@ -2785,7 +2786,7 @@ characters does I<not> work, even if the length is specified." }; [["part_disk"; "/dev/sda&qu...

Add a macro STRDUP_RESOLVE_DEVICE_OR_PATH to resolve path or device. Signed-off-by: Wanlong Gao <gaowanlong at cn.fujitsu.com> --- daemon/daemon.h | 16 ++++++++++++++++ daemon/mount.c | 13 ++----------- 2 files changed, 18 insertions(+), 11 deletions(-) diff --git a/daemon/daemon.h b/daemon/daemon.h index 85eec45..f7d0c75 100644 --- a/daemon/daemon.h +++ b/daemon/daemon.h @@ -336,6

This is a follow-up to the other generator changes in: https://www.redhat.com/archives/libguestfs/2017-February/msg00217.html Rich.

...e; deprecated_by = None; optional = None; + fish_output = None; visibility = VPublic; + deprecated_by = None; optional = None; progress = false; camel_name = ""; cancellable = false; config_only = false; once_had_no_optargs = false; blocking = true; @@ -76,7 +76,7 @@ let test_functions = [ { defaults with name = "internal_test"; style = RErr, test_all_args, test_all_optargs; - in_fish = false; in_docs = false; internal = true; cancellable = true; + visibility = VBindTest; cancellable = tru...

...[String (Device, "device"); String (Key, "key"); String (PlainString, "mapname")], []; > + style = RErr, [String (Device, "device"); String (Key, "key"); String (PlainString, "mapname")], [OBool "allowdiscards"]; > + once_had_no_optargs = true; > optional = Some "luks"; > shortdesc = "open a LUKS-encrypted block device"; > longdesc = "\ This is fine. The rest of this patch is fine. I'm losing track of what order these patches would be applied in order to preserve git bisectio...

...something in GObject truncates all integers to 32 bits. BTW also check it works on a 32 bit architecture. (2) OStringList: IIRC I added this type to the generator but was unable / didn't have time to add it to the GObject bindings. (3) Stability of the API: GObject doesn't understand the once_had_no_optargs feature of the generator, which means that converting a no-optargs call to an optargs call (which is now permitted) will break the GObject API. You may or may not care about this. (4) Coverity found a potential bug in header inclusion. It seems that GObject headers recursively include themselves...

...fs support. This series adds missing > parameters to btrfs_subvolume_snapshot and btrfs_subvolume_create, and > adds two new API btrfs_subvolume_get_default and btrfs_subvolume_show. > > Other parts will follow. > > Regards, > Hu > > changes: > v2: > - add 'once_had_no_optargs = true' for btrfs_subvolume_snapshot and > btrfs_subvolume_create > - improved documents for btrfs_subvolume_snapshot and > btrfs_subvolume_create > - coding style change (patch 5) > - add analyze_line (patch 5) > - rebase > > > Hu Tao (5): > bt...

...ers. To add new opt arguments, add them to the second list (currently [] for luks_open). See for example: https://github.com/libguestfs/libguestfs/blob/a754cd43078e43f1a2b5d10e54b684c70c5525d7/generator/actions_core.ml#L213 Because the existing API does not have optional arguments you must add ‘once_had_no_optargs = true’ so that the generator adds the backwards compatibility API. > 3) As it is right now, lsblk is called for every crypto_LUKS device to > see if a corresponding mapping had been created. I *think* it's good > enough, but keeping a list of (blkdev, mapname) in the daemon memory &g...