search for: old_encod

...ic_check(struct drm_connector *connector, crtc_state = drm_atomic_get_new_crtc_state(state, old_crtc); slots = to_intel_crtc_state(crtc_state)->dp_m_n.tu; if (drm_atomic_crtc_needs_modeset(crtc_state) && slots > 0) { - struct drm_dp_mst_topology_mgr *mgr; - struct drm_encoder *old_encoder; - - old_encoder = old_conn_state->best_encoder; - mgr = &enc_to_mst(old_encoder)->primary->dp.mst_mgr; - ret = drm_dp_atomic_release_vcpi_slots(state, mgr, slots); if (ret) DRM_DEBUG_KMS("failed releasing %d vcpi slots:%d\n", slots, ret); @@ -407,8 +408,6 @@ st...

...ic_check(struct drm_connector *connector, crtc_state = drm_atomic_get_new_crtc_state(state, old_crtc); slots = to_intel_crtc_state(crtc_state)->dp_m_n.tu; if (drm_atomic_crtc_needs_modeset(crtc_state) && slots > 0) { - struct drm_dp_mst_topology_mgr *mgr; - struct drm_encoder *old_encoder; - - old_encoder = old_conn_state->best_encoder; - mgr = &enc_to_mst(old_encoder)->primary->dp.mst_mgr; - ret = drm_dp_atomic_release_vcpi_slots(state, mgr, slots); if (ret) DRM_DEBUG_KMS("failed releasing %d vcpi slots:%d\n", slots, ret); @@ -407,8 +408,6 @@ st...

...t;crtc; if (!old_crtc) return ret; - crtc_state = drm_atomic_get_new_crtc_state(state, old_crtc); - slots = to_intel_crtc_state(crtc_state)->dp_m_n.tu; - if (drm_atomic_crtc_needs_modeset(crtc_state) && slots > 0) { - struct drm_dp_mst_topology_mgr *mgr; - struct drm_encoder *old_encoder; + /* Free VCPI, since compute_config() won't be run */ + if (!new_conn_state->crtc) { + crtc_state = drm_atomic_get_new_crtc_state(state, old_crtc); - old_encoder = old_conn_state->best_encoder; - mgr = &enc_to_mst(old_encoder)->primary->dp.mst_mgr; - - ret = drm_dp_ato...

...t;crtc; if (!old_crtc) return ret; - crtc_state = drm_atomic_get_new_crtc_state(state, old_crtc); - slots = to_intel_crtc_state(crtc_state)->dp_m_n.tu; - if (drm_atomic_crtc_needs_modeset(crtc_state) && slots > 0) { - struct drm_dp_mst_topology_mgr *mgr; - struct drm_encoder *old_encoder; + /* Free VCPI, since compute_config() won't be run */ + if (!new_conn_state->crtc) { + crtc_state = drm_atomic_get_new_crtc_state(state, old_crtc); - old_encoder = old_conn_state->best_encoder; - mgr = &enc_to_mst(old_encoder)->primary->dp.mst_mgr; - - ret = drm_dp_ato...

...turn ret; > > - crtc_state = drm_atomic_get_new_crtc_state(state, old_crtc); > - slots = to_intel_crtc_state(crtc_state)->dp_m_n.tu; > - if (drm_atomic_crtc_needs_modeset(crtc_state) && slots > 0) { > - struct drm_dp_mst_topology_mgr *mgr; > - struct drm_encoder *old_encoder; > + /* Free VCPI, since compute_config() won't be run */ > + if (!new_conn_state->crtc) { > + crtc_state = drm_atomic_get_new_crtc_state(state, old_crtc); > > - old_encoder = old_conn_state->best_encoder; > - mgr = &enc_to_mst(old_encoder)->primary->dp....

...t;crtc; if (!old_crtc) return ret; - crtc_state = drm_atomic_get_new_crtc_state(state, old_crtc); - slots = to_intel_crtc_state(crtc_state)->dp_m_n.tu; - if (drm_atomic_crtc_needs_modeset(crtc_state) && slots > 0) { - struct drm_dp_mst_topology_mgr *mgr; - struct drm_encoder *old_encoder; + /* Free VCPI, since compute_config() won't be run */ + if (!new_conn_state->crtc) { + crtc_state = drm_atomic_get_new_crtc_state(state, old_crtc); - old_encoder = old_conn_state->best_encoder; - mgr = &enc_to_mst(old_encoder)->primary->dp.mst_mgr; - - ret = drm_dp_ato...

..._atomic_get_new_crtc_state(state, old_crtc); > > > - slots = to_intel_crtc_state(crtc_state)->dp_m_n.tu; > > > - if (drm_atomic_crtc_needs_modeset(crtc_state) && slots > 0) { > > > - struct drm_dp_mst_topology_mgr *mgr; > > > - struct drm_encoder *old_encoder; > > > + /* Free VCPI, since compute_config() won't be run */ > > > + if (!new_conn_state->crtc) { > > > + crtc_state = drm_atomic_get_new_crtc_state(state, old_crtc); > > > > > > - old_encoder = old_conn_state->best_encoder; > > &g...

...turn ret; > > - crtc_state = drm_atomic_get_new_crtc_state(state, old_crtc); > - slots = to_intel_crtc_state(crtc_state)->dp_m_n.tu; > - if (drm_atomic_crtc_needs_modeset(crtc_state) && slots > 0) { > - struct drm_dp_mst_topology_mgr *mgr; > - struct drm_encoder *old_encoder; > + /* Free VCPI, since compute_config() won't be run */ > + if (!new_conn_state->crtc) { > + crtc_state = drm_atomic_get_new_crtc_state(state, old_crtc); > > - old_encoder = old_conn_state->best_encoder; > - mgr = &enc_to_mst(old_encoder)->primary->dp....

This patchset does some cleaning up of the atomic VCPI helpers for MST, and converts nouveau over to using them. I would have included amdgpu in this patch as well, but at the moment moving them over to the atomic helpers is nontrivial. Cc: Daniel Vetter <daniel at ffwll.ch> Lyude Paul (5): drm/dp_mst: Add some atomic state iterator macros drm/dp_mst: Start tracking per-port VCPI

...; - crtc_state = drm_atomic_get_new_crtc_state(state, old_crtc); > > - slots = to_intel_crtc_state(crtc_state)->dp_m_n.tu; > > - if (drm_atomic_crtc_needs_modeset(crtc_state) && slots > 0) { > > - struct drm_dp_mst_topology_mgr *mgr; > > - struct drm_encoder *old_encoder; > > + /* Free VCPI, since compute_config() won't be run */ > > + if (!new_conn_state->crtc) { > > + crtc_state = drm_atomic_get_new_crtc_state(state, old_crtc); > > > > - old_encoder = old_conn_state->best_encoder; > > - mgr = &enc_to_mst(ol...

This patchset does some cleaning up of the atomic VCPI helpers for MST, and converts nouveau over to using them. I would have included amdgpu in this patch as well, but at the moment moving them over to the atomic helpers is nontrivial. Cc: Daniel Vetter <daniel at ffwll.ch> Lyude Paul (6): drm/dp_mst: Deprecate drm_dp_find_vcpi_slots() drm/dp_mst: Remove all evil duplicate state

...t;crtc; - if (!old_crtc) - return ret; - - crtc_state = drm_atomic_get_new_crtc_state(state, old_crtc); - slots = to_intel_crtc_state(crtc_state)->dp_m_n.tu; - if (drm_atomic_crtc_needs_modeset(crtc_state) && slots > 0) { - struct drm_dp_mst_topology_mgr *mgr; - struct drm_encoder *old_encoder; + if (!old_conn_state->crtc) + return 0; - old_encoder = old_conn_state->best_encoder; - mgr = &enc_to_mst(old_encoder)->primary->dp.mst_mgr; + /* We only want to free VCPI if this state disables the CRTC on this + * connector + */ + if (new_crtc) { + crtc_state = drm_ato...

This patchset does some cleaning up of the atomic VCPI helpers for MST, and converts nouveau over to using them. I would have included amdgpu in this patch as well, but at the moment moving them over to the atomic helpers is nontrivial. Cc: Daniel Vetter <daniel at ffwll.ch> Lyude Paul (4): drm/dp_mst: Add some atomic state iterator macros drm/dp_mst: Start tracking per-port VCPI

...(!old_crtc) - return ret; + return 0; - crtc_state = drm_atomic_get_new_crtc_state(state, old_crtc); - slots = to_intel_crtc_state(crtc_state)->dp_m_n.tu; - if (drm_atomic_crtc_needs_modeset(crtc_state) && slots > 0) { - struct drm_dp_mst_topology_mgr *mgr; - struct drm_encoder *old_encoder; + old_crtc_state = drm_atomic_get_old_crtc_state(state, old_crtc); + if (!old_crtc_state || + !to_intel_crtc_state(old_crtc_state)->dp_m_n.tu) + return 0; - old_encoder = old_conn_state->best_encoder; - mgr = &enc_to_mst(old_encoder)->primary->dp.mst_mgr; + /* If we swit...

..._state(state, old_crtc); > > > > - slots = to_intel_crtc_state(crtc_state)->dp_m_n.tu; > > > > - if (drm_atomic_crtc_needs_modeset(crtc_state) && slots > 0) { > > > > - struct drm_dp_mst_topology_mgr *mgr; > > > > - struct drm_encoder *old_encoder; > > > > + /* Free VCPI, since compute_config() won't be run */ > > > > + if (!new_conn_state->crtc) { > > > > + crtc_state = drm_atomic_get_new_crtc_state(state, old_crtc); > > > > > > > > - old_encoder = old_conn_state->b...

...return 0; > > - crtc_state = drm_atomic_get_new_crtc_state(state, old_crtc); > - slots = to_intel_crtc_state(crtc_state)->dp_m_n.tu; > - if (drm_atomic_crtc_needs_modeset(crtc_state) && slots > 0) { > - struct drm_dp_mst_topology_mgr *mgr; > - struct drm_encoder *old_encoder; > + old_crtc_state = drm_atomic_get_old_crtc_state(state, old_crtc); > + if (!old_crtc_state || !old_crtc_state would be a framework bug. Just remove that check. > + !to_intel_crtc_state(old_crtc_state)->dp_m_n.tu) > + return 0; Hm, why do we need this? Having a DP port pr...

...(!old_crtc) - return ret; + return 0; - crtc_state = drm_atomic_get_new_crtc_state(state, old_crtc); - slots = to_intel_crtc_state(crtc_state)->dp_m_n.tu; - if (drm_atomic_crtc_needs_modeset(crtc_state) && slots > 0) { - struct drm_dp_mst_topology_mgr *mgr; - struct drm_encoder *old_encoder; + old_crtc_state = drm_atomic_get_old_crtc_state(state, old_crtc); + if (!old_crtc_state || + !to_intel_crtc_state(old_crtc_state)->dp_m_n.tu) + return 0; - old_encoder = old_conn_state->best_encoder; - mgr = &enc_to_mst(old_encoder)->primary->dp.mst_mgr; + /* If we swit...

...- slots = to_intel_crtc_state(crtc_state)->dp_m_n.tu; > > > > > > > - if (drm_atomic_crtc_needs_modeset(crtc_state) && slots > 0) { > > > > > > > - struct drm_dp_mst_topology_mgr *mgr; > > > > > > > - struct drm_encoder *old_encoder; > > > > > > > + old_crtc_state = drm_atomic_get_old_crtc_state(state, > > > > > > > old_crtc); > > > > > > > + if (!old_crtc_state || > > > > > > > > > > > > !old_crtc_state would be a framework b...

...tc); > > > > > - slots = to_intel_crtc_state(crtc_state)->dp_m_n.tu; > > > > > - if (drm_atomic_crtc_needs_modeset(crtc_state) && slots > 0) { > > > > > - struct drm_dp_mst_topology_mgr *mgr; > > > > > - struct drm_encoder *old_encoder; > > > > > + old_crtc_state = drm_atomic_get_old_crtc_state(state, > > > > > old_crtc); > > > > > + if (!old_crtc_state || > > > > > > > > !old_crtc_state would be a framework bug. Just remove that check. > > > > &gt...

..._atomic_get_new_crtc_state(state, old_crtc); > > > - slots = to_intel_crtc_state(crtc_state)->dp_m_n.tu; > > > - if (drm_atomic_crtc_needs_modeset(crtc_state) && slots > 0) { > > > - struct drm_dp_mst_topology_mgr *mgr; > > > - struct drm_encoder *old_encoder; > > > + old_crtc_state = drm_atomic_get_old_crtc_state(state, old_crtc); > > > + if (!old_crtc_state || > > > > !old_crtc_state would be a framework bug. Just remove that check. > > > > > + !to_intel_crtc_state(old_crtc_state)->dp_m_n.tu) &gt...