search for: ogievskiy

On Fri, Mar 03, 2023 at 04:17:40PM -0600, Eric Blake wrote: > On Fri, Dec 16, 2022 at 10:32:01PM +0300, Vladimir Sementsov-Ogievskiy wrote: > > s-o-b line missed. > > I'm not sure if the NBD project has a strict policy on including one, > but I don't mind adding it. I've never required it, mostly because it's something that I myself always forget, too, so, *shrug*. (if there were a way in git to...

On Fri, Dec 16, 2022 at 10:32:01PM +0300, Vladimir Sementsov-Ogievskiy wrote: > On 11/15/22 01:46, Eric Blake wrote: > > The spec was silent on how many extents a server could reply with. > > However, both qemu and nbdkit (the two server implementations known to > > have implemented the NBD_CMD_BLOCK_STATUS extension) implement a hard > > ca...

...h RHEL and CentOS 7.6 and 7.7, even though it's not an nbdkit (or qemu) bug. Rich. ---------------------------------------------------------------------- 89aa0d87634e2cb98517509dc8bdb876f26ecf8b is the first bad commit commit 89aa0d87634e2cb98517509dc8bdb876f26ecf8b Author: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> Date: Fri Apr 27 17:20:01 2018 +0300 nbd/client: fix nbd_negotiate_simple_meta_context Initialize received variable. Otherwise, is is possible for server to answer without any contexts, but we will set context_id to something random (received...

...of 64-bit > requests, where a client's request is no longer bounded to 4G and > could thereby produce even more than 8M extents for the corner case > when every 512 bytes is a new extent, if it were not for this > recommendation. s-o-b line missed. Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov at yandex-team.ru> -- Best regards, Vladimir

...s to bother mentioning it as a special case. > > Rich. > > ---------------------------------------------------------------------- > 89aa0d87634e2cb98517509dc8bdb876f26ecf8b is the first bad commit > commit 89aa0d87634e2cb98517509dc8bdb876f26ecf8b > Author: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> > Date: Fri Apr 27 17:20:01 2018 +0300 > > nbd/client: fix nbd_negotiate_simple_meta_context > > Initialize received variable. Otherwise, is is possible for server to > answer without any contexts, but we will set context_id to...

On Wed, Aug 12, 2020 at 04:12:28PM +0300, Vladimir Sementsov-Ogievskiy wrote: > 12.08.2020 15:52, Vladimir Sementsov-Ogievskiy wrote: > >12.08.2020 15:39, Andrey Shinkevich wrote: > >>For the appliance of the QCOW2 format, get the UUID of the disk by > >>reading the first 256k bytes with 'qemu-img dd' command. Then pass the > >...

...3.1.0 printed an error message: qemu-img: Protocol error: invalid payload for NBD_REPLY_TYPE_BLOCK_STATUS So I have bisected this to the following commit: d8b4bad846f08ff0f167b46dc156a5310b750484 is the first bad commit commit d8b4bad846f08ff0f167b46dc156a5310b750484 Author: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> Date: Fri Nov 2 18:11:52 2018 +0300 block/nbd-client: use traces instead of noisy error_report_err Reduce extra noise of nbd-client, change 083 correspondingly. In various commits (be41c100 in 2.10, f140e300 in 2.11, 78a33ab in 2.12), we...

On 3/23/19 7:58 AM, Richard W.M. Jones wrote: >> A good point here is what happens with the block-status branch[1]. >> Let's see: >> >> $ ./nbdkit memory size=64M --run '/home/rjones/d/qemu/qemu-img convert $nbd /var/tmp/out' >> qemu-img: Payload too large >> nbdkit: memory.1: error: write reply: NBD_CMD_BLOCK_STATUS: Broken pipe >> >>

On 8/28/19 8:55 AM, Vladimir Sementsov-Ogievskiy wrote: > 23.08.2019 17:37, Eric Blake wrote: >> See the cross-post cover letter for more details: >> https://www.redhat.com/archives/libguestfs/2019-August/msg00322.html >> >> Based-on: https://lists.gnu.org/archive/html/qemu-devel/2019-08/msg04805.html >> [Andrey S...

On 8/30/19 1:00 PM, Vladimir Sementsov-Ogievskiy wrote: > 23.08.2019 17:37, Eric Blake wrote: >> When creating a read-only image, we are still advertising support for >> TRIM and WRITE_ZEROES to the client, even though the client should not >> be issuing those commands. But seeing this requires looking across >> multip...

On 8/30/19 1:07 PM, Vladimir Sementsov-Ogievskiy wrote: > 23.08.2019 17:37, Eric Blake wrote: >> Commit fe0480d6 and friends added BDRV_REQ_NO_FALLBACK as a way to >> avoid wasting time on a preliminary write-zero request that will later >> be rewritten by actual data, if it is known that the write-zero >> request will...

On Wed, Aug 12, 2020 at 03:52:34PM +0300, Vladimir Sementsov-Ogievskiy wrote: > 12.08.2020 15:39, Andrey Shinkevich wrote: > >For the appliance of the QCOW2 format, get the UUID of the disk by > >reading the first 256k bytes with 'qemu-img dd' command. Then pass the > >read block to the 'file' command. In case of failure, run the &...

On 8/28/19 4:57 AM, Vladimir Sementsov-Ogievskiy wrote: >> Hence, it is desirable to have a way for clients to specify that a >> particular write zero request is being attempted for a fast wipe, and >> get an immediate failure if the zero request would otherwise take the >> same time as a write. Conversely, if the client...

...t sounds like a regression in qemu worth fixing, so I'll whip up a patch. > > So I have bisected this to the following commit: > > d8b4bad846f08ff0f167b46dc156a5310b750484 is the first bad commit > commit d8b4bad846f08ff0f167b46dc156a5310b750484 > Author: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> > Date: Fri Nov 2 18:11:52 2018 +0300 > > block/nbd-client: use traces instead of noisy error_report_err That's also helpful, as it pinpoints where we regressed at flagging the protocol error. -- Eric Blake, Principal Software Engineer Red Hat...

This is a cover letter to a series of patches being proposed in tandem to four different projects: - nbd: Document a new NBD_CMD_FLAG_FAST_ZERO command flag - qemu: Implement the flag for both clients and server - libnbd: Implement the flag for clients - nbdkit: Implement the flag for servers, including the nbd passthrough client If you want to test the patches together, I've pushed a

v2 was here: https://lists.debian.org/nbd/2022/11/msg00030.html The bulk of the changes since then are: - forbid NBD_OPT_EXPORT_NAME once extended headers are negotiated (Wouter) - consistently use 'maximum payload', rather than a haphazard mix of 'maximum block payload' (Vladimir) At this point, I want to make sure we are happy with the spec before re-posting patches for