search for: oggplayvideorgbdata

> I think adding an RGB/RGBA frame type to liboggplay should *also* > happen. yuv2rgb is tedious at best and hard to get right at worst, so I'd added an RGBA type, but if this is going to also carry video, it might be better to merge this with the existing video type, and have a 'type' enum, or just several pointers, only one set being non NULL (makes client code simpler). Would

...the YUV and RGB types would work though. typedef struct { unsigned char *y; unsigned char *u; unsigned char *v; unsigned char *mask; /* may be NULL */ } OggPlayVideoYUVData; typedef struct { unsigned char *data; /* may be RGB or RGBA */ unsigned char *mask; /* may be NULL if RGBA */ } OggPlayVideoRGBData; That sort of thing. -r

> fancy with unions, but since RGB/RGBA is generally chunked and YUV is > generally planar, having two separate types makes more sense. There's OK > typedef struct { > unsigned char *data; /* may be RGB or RGBA */ > unsigned char *mask; /* may be NULL if RGBA */ > } OggPlayVideoRGBData; That's what I have at the moment - two types and something like the above, except that : typedef struct { unsigned char *rgb; /* may be NULL if alpha */ unsigned char *rgba; /* may be NULL if no alpha */ } OggPlayOverlayData; (I think it's probably faster to keep RGBA in one plane,...