search for: oggopusenc

...NULL; if st == NULL it expects the error code to be filled in with the error from opus_*_encoder_create(). This function does NOT return NULL as expected by the caller if opus_*_encoder_create() fails. Rather than allocating this OpusGenericEncoder structure separately and pointing to it from the OggOpusEnc structure, this structure or its two pointer fields could simply be added to OggOpusEnc. This would also avoid an unnecessary level of indirection in every place where the encoder is used. + st->family=0; The family field in this structure is set to the wrong family in _oge_create(). Howev...

Hi Drew, I think the libopusenc patch is better, but there's still a few issues left: 1) The static MAX_PACKET_BUFFER_SIZE value is still problematic because if you link libopusenc with a new version of libopus that supports higher order projection or just more projection channels for order 3, then you will overflow the buffer. I think what you'd want is a _ope_opus_header_get_size() call

...Right now there are other functions with a leading > underscore, so we'll have to fix them as well (not in this patch of > course). Maybe an "opeint_" prefix would do the job here (unless anyone > has a better idea)? > > > +int ope_encoder_deferred_init_with_mapping(OggOpusEnc *enc, int > > family, int streams, > > int coupled_streams, const unsigned char *mapping) { > > int ret; > > int i; > > > > This code is allowing family 253 for a deferred init, but does not > > create a projection encoder in that case, so it loo...

...ading > > underscore, so we'll have to fix them as well (not in this patch of > > course). Maybe an "opeint_" prefix would do the job here (unless > anyone > > has a better idea)? > > > > > +int ope_encoder_deferred_init_with_mapping(OggOpusEnc *enc, int > > > family, int streams, > > > int coupled_streams, const unsigned char *mapping) { > > > int ret; > > > int i; > > > > > > This code is allowing family 253 for a deferred init, but does not > &g...

...em as well (not in this > > patch of > > > course). Maybe an "opeint_" prefix would do the job here > > (unless anyone > > > has a better idea)? > > > > > > > +int ope_encoder_deferred_init_with_mapping(OggOpusEnc *enc, > int > > > > family, int streams, > > > > int coupled_streams, const unsigned char *mapping) { > > > > int ret; > > > > int i; > > > > > > > > This code is al...

...tch of >>> > > course). Maybe an "opeint_" prefix would do the job here >>> > (unless anyone >>> > > has a better idea)? >>> > > >>> > > > +int ope_encoder_deferred_init_with_mapping(OggOpusEnc >>> *enc, int >>> > > > family, int streams, >>> > > > int coupled_streams, const unsigned char *mapping) { >>> > > > int ret; >>> > > > int i; >>> > >...

...#39;t in the public API. Right now there are other functions with a leading underscore, so we'll have to fix them as well (not in this patch of course). Maybe an "opeint_" prefix would do the job here (unless anyone has a better idea)? > +int ope_encoder_deferred_init_with_mapping(OggOpusEnc *enc, int > family, int streams, > int coupled_streams, const unsigned char *mapping) { > int ret; > int i; > > This code is allowing family 253 for a deferred init, but does not > create a projection encoder in that case, so it looks like it will > fail when wri...

...are other functions with a leading > underscore, so we'll have to fix them as well (not in this patch of > course). Maybe an "opeint_" prefix would do the job here (unless anyone > has a better idea)? > > > +int ope_encoder_deferred_init_with_mapping(OggOpusEnc *enc, int > > family, int streams, > >      int coupled_streams, const unsigned char *mapping) { > >    int ret; > >    int i; > > > > This code is allowing family 253 for a deferred init, but does not > > create a projection enc...

...e, so we'll have to fix them as well (not in this > patch of > >     course). Maybe an "opeint_" prefix would do the job here > (unless anyone > >     has a better idea)? > > > >     > +int ope_encoder_deferred_init_with_mapping(OggOpusEnc *enc, int > >     > family, int streams, > >     >      int coupled_streams, const unsigned char *mapping) { > >     >    int ret; > >     >    int i; > >     > > >     > This code is allowing family 253 for a deferred in...

...>> > patch of >> > > course). Maybe an "opeint_" prefix would do the job here >> > (unless anyone >> > > has a better idea)? >> > > >> > > > +int ope_encoder_deferred_init_with_mapping(OggOpusEnc >> *enc, int >> > > > family, int streams, >> > > > int coupled_streams, const unsigned char *mapping) { >> > > > int ret; >> > > > int i; >> > > > >> > &...

...eint_" prefix would do the job here >>>>>>> > (unless anyone >>>>>>> > > has a better idea)? >>>>>>> > > >>>>>>> > > > +int ope_encoder_deferred_init_with_mapping(OggOpusEnc >>>>>>> *enc, int >>>>>>> > > > family, int streams, >>>>>>> > > > int coupled_streams, const unsigned char >>>>>>> *mapping) { >>>>>>> > > &...