search for: ogg_pcm_s8

...have overlooked some). c) I think having separate fields for things like signed/ unsigned/float and bit width is a mistake. I would suggest instead a single field that encodes all this information in a enumeration. Ie: OGG_PCM_U8 /* Unsigned 8 bit */ OGG_PCM_S8 /* Signed 8 bit. */ OGG_PCM_S16 OGG_PCM_S24 OGG_PCM_S32 OGG_PCM_FLOAT32 OGG_PCM_FLOAT64 and so on. This scheme makes it very difficult to get signed/unsigned and bitwith messed up. d) Don't bother implementing unsigned PCM for b...

...c) I think having separate fields for things like signed/ > unsigned/float and bit width is a mistake. I would suggest > instead a single field that encodes all this information > in a enumeration. Ie: > > OGG_PCM_U8 /* Unsigned 8 bit */ > OGG_PCM_S8 /* Signed 8 bit. */ > OGG_PCM_S16 > OGG_PCM_S24 > OGG_PCM_S32 > OGG_PCM_FLOAT32 > OGG_PCM_FLOAT64 > > and so on. This scheme makes it very difficult to get > signed/unsigned and bitwith messed up. With the exception...

Arc wrote: > Ok so we cap it to 64bit, since much more than that doesn't make sense (96bit > would be a "long double" C type) On x86 CPUs, "long double" is 80 bits. > I really don't like this idea, but I will entertain, formatting it as follows: > > ID Type Bits > 0 Int 8 > 1 uInt 8 > 2 Int 16 > 3 Int 24 > 4 Int

...) I think having separate fields for things like signed/ > unsigned/float and bit width is a mistake. I would suggest > instead a single field that encodes all this information > in a enumeration. Ie: > > OGG_PCM_U8 /* Unsigned 8 bit */ > OGG_PCM_S8 /* Signed 8 bit. */ > OGG_PCM_S16 > OGG_PCM_S24 > OGG_PCM_S32 > OGG_PCM_FLOAT32 > OGG_PCM_FLOAT64 > > and so on. This scheme makes it very difficult to get > signed/unsigned and bitwith messed up. > d) Don...

...ds for things like signed/ > > unsigned/float and bit width is a mistake. I would suggest > > instead a single field that encodes all this information > > in a enumeration. Ie: > > > > OGG_PCM_U8 /* Unsigned 8 bit */ > > OGG_PCM_S8 /* Signed 8 bit. */ > > OGG_PCM_S16 > > OGG_PCM_S24 > > OGG_PCM_S32 > > OGG_PCM_FLOAT32 > > OGG_PCM_FLOAT64 > > > > and so on. This scheme makes it very difficult to get > > signed/unsig...