search for: offsval

...d address > space arithmetic > > Micah, > > There are a number of variable names in this patch that don't follow > the naming convention (which specifies that they should start with an > uppercase letter). > > > if (PtrBits < 64) > > - OffsVal = DAG.getNode(ISD::TRUNCATE, getCurDebugLoc(), > > - TLI.getPointerTy(), > > + OffsVal = DAG.getNode(ISD::TRUNCATE, getCurDebugLoc(), > > PtrTy, DAG.getConstant(Offs, MVT::i64)); > > This is not necessarily specific to your patch, but...

Micah, There are a number of variable names in this patch that don't follow the naming convention (which specifies that they should start with an uppercase letter). > if (PtrBits < 64) > - OffsVal = DAG.getNode(ISD::TRUNCATE, getCurDebugLoc(), > - TLI.getPointerTy(), > + OffsVal = DAG.getNode(ISD::TRUNCATE, getCurDebugLoc(), > PtrTy, DAG.getConstant(Offs, MVT::i64)); This is not necessarily specific to your patch, but can you explain the spec...

...t; > Micah, > > > > There are a number of variable names in this patch that don't follow > > the naming convention (which specifies that they should start with > > an uppercase letter). > > > > > if (PtrBits < 64) > > > - OffsVal = DAG.getNode(ISD::TRUNCATE, getCurDebugLoc(), > > > - TLI.getPointerTy(), > > > + OffsVal = DAG.getNode(ISD::TRUNCATE, getCurDebugLoc(), > > > PtrTy, DAG.getConstant(Offs, MVT::i64)); > > > > This is not necessarily sp...

> -----Original Message----- > From: Villmow, Micah > Sent: Friday, August 24, 2012 2:56 PM > To: 'Eli Friedman' > Cc: LLVM Developers Mailing List > Subject: RE: [LLVMdev] RFC: Supporting different sized address space > arithmetic > > Eli, > There is a patch that implements the beginning what I think is the > correct approach to support the backend