search for: offset_r

...al: master: service(imap): child 4904 killed with signal 7 (core dumped) ### gdb Core was generated by `dovecot/imap'. Program terminated with signal 7, Bus error. #0 0x00007fc4a69f293e in mail_cache_lookup_offset (cache=0x7fc4a811a320, view=<optimized out>, seq=<optimized out>, offset_r=offset_r at entry =0x7ffe23a98900) at mail-cache-lookup.c:95 95 while (cache->hdr->file_seq != reset_id) { (gdb) bt #0 0x00007fc4a69f293e in mail_cache_lookup_offset (cache=0x7fc4a811a320, view=<optimized out>, seq=<optimized out>, offset_r=offset_r at entry =0x7ffe23a98900)...

...### gdb > > > > > > Core was generated by `dovecot/imap'. > > > Program terminated with signal 7, Bus error. > > > #0 0x00007fc4a69f293e in mail_cache_lookup_offset (cache=0x7fc4a811a320, > > > view=<optimized out>, seq=<optimized out>, offset_r=offset_r at entry > > > =0x7ffe23a98900) > > > at mail-cache-lookup.c:95 > > > 95 while (cache->hdr->file_seq != reset_id) { > > > (gdb) bt > > > #0 0x00007fc4a69f293e in mail_cache_lookup_offset (cache=0x7fc4a811a320, > > > view=<...

...t; Core was generated by `dovecot/imap'. >> > > > Program terminated with signal 7, Bus error. >> > > > #0 0x00007fc4a69f293e in mail_cache_lookup_offset >> (cache=0x7fc4a811a320, >> > > > view=<optimized out>, seq=<optimized out>, offset_r=offset_r at entry >> > > > =0x7ffe23a98900) >> > > > at mail-cache-lookup.c:95 >> > > > 95 while (cache->hdr->file_seq != reset_id) { >> > > > (gdb) bt >> > > > #0 0x00007fc4a69f293e in mail_cache_lookup_offset &g...

This implements support for MBR logical partitions in nbdkit-partition-filter, complementing existing support in the partitioning plugin. Rich.

.../* Primary partition. */ for (i = 0; i < 4; ++i) { get_mbr_partition (mbr, i, &partition); if (partition.nr_sectors > 0 && partition.part_type_byte != 0 && + !is_extended (partition.part_type_byte) && partnum == i+1) { *offset_r = partition.start_sector * SECTOR_SIZE; *range_r = partition.nr_sectors * SECTOR_SIZE; @@ -86,6 +92,95 @@ find_mbr_partition (struct nbdkit_next_ops *next_ops, void *nxdata, } } + /* Logical partition. */ + + /* Find the extended partition in the primary partition table. */ + fo...

...bdl.so.2...done. Loaded symbols for /lib/libdl.so.2 Reading symbols from /lib/libc.so.6...done. Loaded symbols for /lib/libc.so.6 Reading symbols from /lib/ld-linux.so.2...done. Loaded symbols for /lib/ld-linux.so.2 #0 0x08074026 in mail_cache_lookup_offset (cache=0x80bad88, view=0x80e1468, seq=1, offset_r=0xbffff308) at mail-cache-lookup.c:73 73 if (cache->hdr->file_seq == ext->reset_id) { (gdb) bt #0 0x08074026 in mail_cache_lookup_offset (cache=0x80bad88, view=0x80e1468, seq=1, offset_r=0xbffff308) at mail-cache-lookup.c:73 #1 0x08074304 in mail_cache_foreac...

...ectors > 0 && > partition.part_type_byte != 0 && > + !is_extended (partition.part_type_byte) && > partnum == i+1) { Given a disk with only 2 partitions, but requesting access to partition 3, fails this loop, and falls into: > *offset_r = partition.start_sector * SECTOR_SIZE; > *range_r = partition.nr_sectors * SECTOR_SIZE; > @@ -86,6 +92,95 @@ find_mbr_partition (struct nbdkit_next_ops *next_ops, void *nxdata, > } > } > > + /* Logical partition. */ > + > + /* Find the extended partition...

I think this addresses everything in Eric's v2 review. Note that the first patch is best viewed using ‘-w’ to ignore whitespaces changes. Rich.

This is a revised version of the two series previously posted here: https://www.redhat.com/archives/libguestfs/2019-January/msg00137.html https://www.redhat.com/archives/libguestfs/2019-January/msg00139.html There have been many smaller changes but the highlights are: - Using SECTOR_SIZE instead of hard-coding 512 everywhere. - Additional safety checks that the EBR chain doesn't jump

...0x9425230, seq=1, reset_id_r=0xbf98d42c) at mail-cache-lookup.c:65 cache = (struct mail_cache *) 0x94233b8 map = <value optimized out> data = (const void *) 0x4 offset = <value optimized out> #11 0x080bbb5d in mail_cache_lookup_offset (cache=0x94233b8, view=0x6, seq=16960, offset_r=0xbf98d498) at mail-cache-lookup.c:87 offset = <value optimized out> reset_id = 155333560 ret = <value optimized out> #12 0x080bbc05 in mail_cache_lookup_iter_init (view=0x9425410, seq=1, ctx_r=0xbf98d480) at mail-cache-lookup.c:154 ret = <value optimized out> #13 0x080bc...

...49b] -> /usr/libexec/dovecot/imap(mail_cache_lookup_iter_init+0x6c) [0x809857c] -> /u"... #3 0x080be82f in i_panic (format=0x80cdbdd "file %s: line %d: unreached") at failures.c:213 No locals. #4 0x0809849b in mail_cache_lookup_offset (cache=0x8d4a9b8, view=0x8d4d460, seq=18, offset_r=0x0) at mail-cache-lookup.c:70 map = (struct mail_index_map *) 0x8d4a898 data = (const void *) 0x8d4f4a4 idx = 148024040 i = -1073767072 ret = 0 #5 0x0809857c in mail_cache_lookup_iter_init (view=0x8d4d558, seq=18, ctx_r=0xbfff9d60) at mail-cache-lookup.c:12...

...ile %s: line %d (%s): assertion failed: (%s)") at failures.c:173 #4 0x08082277 in mail_cache_transaction_reserve_more (ctx=0x80cb4a0, block_size=332, commit=true) at mail-cache-transaction.c:257 #5 0x0808248a in mail_cache_transaction_get_space (ctx=0x80cb4a0, min_size=332, max_size=332, offset_r=0x0, available_space_r=0x0, commit=true) at mail-cache-transaction.c:347 #6 0x08082b90 in mail_cache_header_add_field (ctx=0x80cb4a0, field=0) at mail-cache-transaction.c:646 #7 0x08082e0e in mail_cache_add (ctx=0x80cb4a0, seq=1, field=9, data=0x0, data_size=0) at mail-cache-transaction.c:693...

For v3 I reimplemented this using mke2fs -d. This obviously makes the implementation a whole lot simpler, but cannot support multiple directory merging. Patches 1-3 are the same as before. I've also reproduced the notes from v2 below. v2: - Fix inconsistent tab/space. - All 3 plugins now contain a block of text pointing to the other 2 plugins. - TMDIR -> TMPDIR - Unlink the

Another interesting thing you can do with this plugin: https://rwmj.wordpress.com/2019/02/19/nbdkit-linuxdisk-plugin/ v2: - Fix inconsistent tab/space. - All 3 plugins now contain a block of text pointing to the other 2 plugins. - TMDIR -> TMPDIR - Unlink the temporary file and other cleanups along error paths. - fclose -> pclose, and check the return value for errors. -

Turns out Japanese trains are good for coding! In supermin we have a bunch of code to create the libguestfs appliance. It creates it directly using libext2fs (part of e2fsprogs). We can use the same technique to create ext2 virtual disks in nbdkit, which is what this new plugin does. Why a new plugin instead of modifying the floppy plugin? See the 4/4 commit message for an explanation. The