search for: ocfs2_truncate_file

...ince last write./ /5) in cont_prepare_write() it dead loops since bytes(ip_mmu_private) is not / /increased in last prepare write./ BUG is described in s://bug.oraclecorp.com/pls/bug/webbug_print.show?c_rptno=7183894. solution: /1) moves the clearing of page cache truncate_inode_pages() from ocfs2_truncate_file() to/ /ocfs2_set_inode_size() after resizing inode size and i_blocks./ /2) in ocfs2_get_block(), add checks on iblock >= inode->i_blocks. if true, return -EIO. 3) //a kernel bug fix is needed for 2.6.9 kernel. //see https://bugzilla.redhat.com/show_bug.cgi?id=453359/ aops.c | 6 ++++++...

...(num 1) at 192.168.0.82:7777 OCFS2 1.2.1 Tue Jun 6 13:24:15 CEST 2006 (build bd2f25ba0af9677db3572e3ccd92f739) ocfs2_dlm: Nodes in domain ("8B6DD64326394C308A4E2B2259162C78"): 0 1 kjournald starting. Commit interval 5 seconds ocfs2: Mounting device (147,0) on (node 0, slot 1) (16918,0):ocfs2_truncate_file:494 ERROR: bug expression: le64_to_cpu(fe->i_size) != i_size_read(inode) (16918,0):ocfs2_truncate_file:494 ERROR: Inode 42363033, inode i_size = 1129 != di i_size = 1120, i_flags = 0x1 ------------[ cut here ]------------ kernel BUG at /usr/src/ocfs2-1.2.1/fs/ocfs2/file.c:494! invalid opcode: 00...

...ournal_begin_ordered_truncate() after inode has been added to orphan list (new i_size written respectively). That function is called from two places: 1) ocfs2_truncate_for_delete() - easy to fix, just move the call just after the write of the inode. 2) ocfs2_setattr() - we can move the call into ocfs2_truncate_file() but that would mean calling jbd2_journal_begin_ordered_truncate() and consequently ocfs2_write_page() under ip_alloc_sem - not too nice. Furthermore ocfs2_orphan_for_truncate() zeros the last cluster beyond i_size and we cannot do that before writing out previous content... Not sur...

...8:53 web1 kernel: d-con r0: Connection closed Jul 3 10:58:53 web1 kernel: d-con r0: conn( Disconnecting -> StandAlone ) Jul 3 10:58:53 web1 kernel: d-con r0: receiver terminated Jul 3 10:58:53 web1 kernel: d-con r0: Terminating receiver thread Jul 3 10:58:54 web1 kernel: (httpd,11395,3):ocfs2_truncate_file:425 ERROR: bug expression: le64_to_cpu(fe->i_size) != i_size_read(inode) Jul 3 10:58:54 web1 kernel: (httpd,11395,3):ocfs2_truncate_file:425 ERROR: Inode 389752, inode i_size = 28059 != di i_size = 17004, i_flags = 0x1 Jul 3 10:58:54 web1 kernel: ----------- [cut here ] --------- [please bit...

OS: Fedora Core release 4 (Stentz) KERNEL: Linux rack1.ape 2.6.17-1.2142_FC4smp #1 SMP Tue Jul 11 22:57:02 EDT 2006 i686 i686 i386 GNU/Linux CLUSTER: 11 Linux kernels, mixed environment FC4,FC5,FC6 SAN: FC Infortrend storage, QLogic16 port FC switch, FC adapter LSI FC929X (21224,1):ocfs2_truncate_file:242 ERROR: bug expression: le64_to_cpu(fe->i_size) != i_size_read(inode) (21224,1):ocfs2_truncate_file:242 ERROR: Inode 1029752381, inode i_size = 582 != di i_size = 690, i_flags = 0x 1 ------------[ cut here ]------------ kernel BUG at fs/ocfs2/file.c:242! invalid opcode: 0000 [#1] SMP last sys...

...index dc4bce1649c1..b8c3d1702076 100644 --- a/fs/ocfs2/ocfs2_trace.h +++ b/fs/ocfs2/ocfs2_trace.h @@ -1319,6 +1319,8 @@ DEFINE_OCFS2_FILE_OPS(ocfs2_file_splice_write); DEFINE_OCFS2_FILE_OPS(ocfs2_file_read_iter); +DEFINE_OCFS2_FILE_OPS(ocfs2_file_splice_read); + DEFINE_OCFS2_ULL_ULL_ULL_EVENT(ocfs2_truncate_file); DEFINE_OCFS2_ULL_ULL_EVENT(ocfs2_truncate_file_error); @@ -1470,6 +1472,7 @@ TRACE_EVENT(ocfs2_prepare_inode_for_write, ); DEFINE_OCFS2_INT_EVENT(generic_file_read_iter_ret); +DEFINE_OCFS2_INT_EVENT(filemap_splice_read_ret); /* End of trace events for fs/ocfs2/file.c. */

Now in ocfs2_local_free_info(), it returns 0 even if it actually fails. Though it doesn't cause any real problem since the only caller dquot_disable() ignores the return value, we'd better return correct as it is. Signed-off-by: Joseph Qi <joseph.qi at linux.alibaba.com> --- fs/ocfs2/quota_local.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git

...index dc4bce1649c1..b8c3d1702076 100644 --- a/fs/ocfs2/ocfs2_trace.h +++ b/fs/ocfs2/ocfs2_trace.h @@ -1319,6 +1319,8 @@ DEFINE_OCFS2_FILE_OPS(ocfs2_file_splice_write); DEFINE_OCFS2_FILE_OPS(ocfs2_file_read_iter); +DEFINE_OCFS2_FILE_OPS(ocfs2_file_splice_read); + DEFINE_OCFS2_ULL_ULL_ULL_EVENT(ocfs2_truncate_file); DEFINE_OCFS2_ULL_ULL_EVENT(ocfs2_truncate_file_error); @@ -1470,6 +1472,7 @@ TRACE_EVENT(ocfs2_prepare_inode_for_write, ); DEFINE_OCFS2_INT_EVENT(generic_file_read_iter_ret); +DEFINE_OCFS2_INT_EVENT(filemap_splice_read_ret); /* End of trace events for fs/ocfs2/file.c. */

...S(ocfs2_file_aio_write); +DEFINE_OCFS2_FILE_OPS(ocfs2_file_write_iter); DEFINE_OCFS2_FILE_OPS(ocfs2_file_splice_write); DEFINE_OCFS2_FILE_OPS(ocfs2_file_splice_read); -DEFINE_OCFS2_FILE_OPS(ocfs2_file_aio_read); +DEFINE_OCFS2_FILE_OPS(ocfs2_file_read_iter); DEFINE_OCFS2_ULL_ULL_ULL_EVENT(ocfs2_truncate_file); @@ -1474,7 +1474,7 @@ TRACE_EVENT(ocfs2_prepare_inode_for_write, __entry->direct_io, __entry->has_refcount) ); -DEFINE_OCFS2_INT_EVENT(generic_file_aio_read_ret); +DEFINE_OCFS2_INT_EVENT(generic_file_read_iter_ret); /* End of trace events for fs/ocfs2/file.c. */ -- 1.8.3.4

...S(ocfs2_file_aio_write); +DEFINE_OCFS2_FILE_OPS(ocfs2_file_write_iter); DEFINE_OCFS2_FILE_OPS(ocfs2_file_splice_write); DEFINE_OCFS2_FILE_OPS(ocfs2_file_splice_read); -DEFINE_OCFS2_FILE_OPS(ocfs2_file_aio_read); +DEFINE_OCFS2_FILE_OPS(ocfs2_file_read_iter); DEFINE_OCFS2_ULL_ULL_ULL_EVENT(ocfs2_truncate_file); @@ -1474,7 +1474,7 @@ TRACE_EVENT(ocfs2_prepare_inode_for_write, __entry->direct_io, __entry->has_refcount) ); -DEFINE_OCFS2_INT_EVENT(generic_file_aio_read_ret); +DEFINE_OCFS2_INT_EVENT(generic_file_read_iter_ret); /* End of trace events for fs/ocfs2/file.c. */ -- 1.8.1

ocfs2 currently uses the Journaled Block Device (JBD) for its journaling. This is a very stable and tested codebase. However, JBD is limited by architecture to 32bit block numbers. This means an ocfs2 filesystem is limited to 2^32 blocks. With a 4K blocksize, that's 16TB. People want larger volumes. Fortunately, there is now JBD2. JBD2 adds 64bit block number support and some other