search for: ocfs2_start_tran

Currently ocfs2_start_trans/ocfs2_commit_trans are in lock_page/unlock_page. This may cause dead lock. Here is the situation: write -> lock_page -> ocfs2_start_trans -> ocfs2_commit_trans -> unlock_page ocfs2_start_trans/ocfs2_commit_trans calls jbd2_journal_start/jbd2_journal_stop which may also call lock_page....

Hi, here is the second version of OCFS2 quota fixes with Joel's comments fixed. Also I've added a patch defining counts of credits for quota operations as Joel asked. Honza

On 2015/10/14 15:49, Zhangguanghui wrote: > OCFS2 is often used in high-availaibility systems, This patch enhances robustness for the filesystem. > but storage network is unstable?it still triggers a panic? such as ocfs2_start_trans -> __ocfs2_abort ->panic. > The 's_mount_opt' should depend on the mount option set, If errors=continue is set, > mark as a EIO error, change OCFS2_MOUNT_ERRORS_PANIC to OCFS2_MOUNT_ERRORS_CONT in __ocfs2_abort; > it's better than forcing a panic without decreasing avai...

...m> Subject: Re: [Ocfs2-devel] Ocfs2-devel Digest, Vol 138, Issue 31 review On 2015/10/14 15:49, Zhangguanghui wrote: > OCFS2 is often used in high-availaibility systems, This patch enhances robustness for the filesystem. > but storage network is unstable?it still triggers a panic? such as ocfs2_start_trans -> __ocfs2_abort ->panic. > The 's_mount_opt' should depend on the mount option set, If errors=continue is set, > mark as a EIO error, change OCFS2_MOUNT_ERRORS_PANIC to OCFS2_MOUNT_ERRORS_CONT in __ocfs2_abort; > it's better than forcing a panic without decreasing avail...

...t, Vol 138, Issue 31 review >> >> On 2015/10/14 15:49, Zhangguanghui wrote: >> > OCFS2 is often used in high-availaibility systems, This patch enhances robustness for the filesystem. >> > but storage network is unstable?it still triggers a panic? such as ocfs2_start_trans -> __ocfs2_abort ->panic. >> > The 's_mount_opt' should depend on the mount option set, If errors=continue is set, >> > mark as a EIO error, change OCFS2_MOUNT_ERRORS_PANIC to OCFS2_MOUNT_ERRORS_CONT in __ocfs2_abort; >> > it's better tha...

OCFS2 is often used in high-availaibility systems, This patch enhances robustness for the filesystem. but storage network is unstable?it still triggers a panic? such as ocfs2_start_trans -> __ocfs2_abort ->panic. The 's_mount_opt' should depend on the mount option set, If errors=continue is set, mark as a EIO error, change OCFS2_MOUNT_ERRORS_PANIC to OCFS2_MOUNT_ERRORS_CONT in __ocfs2_abort; it's better than forcing a panic without decreasing availability,errors=...

OCFS2 is often used in high-availaibility systems, This patch enhances robustness for the filesystem. but storage network is unstable?it still triggers a panic? such as ocfs2_start_trans -> __ocfs2_abort ->panic. The 's_mount_opt' should depend on the mount option set, If errors=continue is set, mark as a EIO error, change OCFS2_MOUNT_ERRORS_PANIC to OCFS2_MOUNT_ERRORS_CONT in __ocfs2_abort; it's better than forcing a panic without decreasing availability,errors=...

...) diff --git a/fs/ocfs2/ioctl.c b/fs/ocfs2/ioctl.c index f20edcb..c739c24 100644 --- a/fs/ocfs2/ioctl.c +++ b/fs/ocfs2/ioctl.c @@ -101,13 +101,6 @@ static int ocfs2_set_inode_attr(struct inode *inode, unsigned flags, if (!S_ISDIR(inode->i_mode)) flags &= ~OCFS2_DIRSYNC_FL; - handle = ocfs2_start_trans(osb, OCFS2_INODE_UPDATE_CREDITS); - if (IS_ERR(handle)) { - status = PTR_ERR(handle); - mlog_errno(status); - goto bail_unlock; - } - oldflags = ocfs2_inode->ip_attr; flags = flags & mask; flags |= oldflags & ~mask; @@ -120,7 +113,14 @@ static int ocfs2_set_inode_attr(struct in...

...dev, this case run md5sum to verify target file. line 57 run 'sync' before line 58 changes the dm target from dm-linear to dm-error. this case is hanging at line 65. In 266, md5sum calls jbd2 trans pair: ocfs2_[start|commit]_trans to do journal job. but there is only ->j_num_trans+1 in ocfs2_start_trans, the ocfs2_commit_trans doesn't do reduction operation. call flow: ``` [md5sum] vfs_read ocfs2_file_read_iter ocfs2_inode_lock_atime ocfs2_update_inode_atime + ocfs2_start_trans //atomic_inc j_num_trans + ... + ocfs2_commit_trans//no modify j_num_trans sync //no modi...

...m to > verify target file. line 57 run 'sync' before line 58 changes the dm > target from dm-linear to dm-error. this case is hanging at line 65. > > In 266, md5sum calls jbd2 trans pair: ocfs2_[start|commit]_trans to > do journal job. but there is only ->j_num_trans+1 in ocfs2_start_trans, > the ocfs2_commit_trans doesn't do reduction operation. > > call flow: > ``` > [md5sum] > vfs_read > ocfs2_file_read_iter > ocfs2_inode_lock_atime > ocfs2_update_inode_atime > + ocfs2_start_trans //atomic_inc j_num_trans > + ... &gt...

Hi, I did some more in-depth testing of OCFS2 quota code, especially with ECC feature enabled and spotted some problems. First four patches fix them. I need the fifth patch to be able to mount OCFS2 filesystem with 2.6.31-rc3. The sixth patch fixes a potential problem when quota syncing interval is updated while the cluster is running (which is not possible currently). Joel, could you please

...nally, one of the nodes will crash with errors like the following: end_request: I/O error, dev sdc, sector 585159 Aborting journal on device sdc1 end_request: I/O error, dev sdc, sector 528151 Buffer I/O error on device sdc1, logical block 66011 lost page write due to I/O error on sdc1 (2848,1):ocfs2_start_trans:240 ERROR: status = -30 OCFS2: abort (device sdc1): ocfs2_start_trans: Detected aborted journal Kernel panic - not syncing: OCFS2: (device sdc1): panic forced after error <0>Rebooting in 30 seconds..BUG: warning at arch/i386/kernel/smp.c:492/smp_send_reschedule() (Tainted: G ) The ser...

...IO error then trigger RO status. This flow is wrong, we should > > mark RO as early as possible when JBD ABORT happens. In my view, the best place > > is my [2/2] patch code which in ocfs2_commit_cache(). > > > > Agree, but ocfs2_abort() is more appropriate here, see > ocfs2_start_trans(). But ocfs2_abort() may panic system, I'm afraid it > has to change to read-only accordingly. You are right. I ever used ocfs2_abort() then got panic. :) So I changed to ocfs2_error(). I also sent two mails in 2023-4-30 (the first mail has mess format by thunderbird). I copy the mail cont...

...ger RO status. This flow is wrong, we should >>> mark RO as early as possible when JBD ABORT happens. In my view, the best place >>> is my [2/2] patch code which in ocfs2_commit_cache(). >>> >> >> Agree, but ocfs2_abort() is more appropriate here, see >> ocfs2_start_trans(). But ocfs2_abort() may panic system, I'm afraid it >> has to change to read-only accordingly. > > You are right. I ever used ocfs2_abort() then got panic. :) > So I changed to ocfs2_error(). I also sent two mails in 2023-4-30 (the first > mail has mess format by thunderbir...

...cfs2 dev, this case run md5sum to verify target file. Line 57 run 'sync' before line 58 changes the dm target from dm-linear to dm-error. This case is hanging at line 65. The md5sum calls jbd2 trans pair: ocfs2_[start|commit]_trans to do journal job. But there is only ->j_num_trans+1 in ocfs2_start_trans, the ocfs2_commit_trans doesn't do reduction operation, 'sync' neither. finally no function reset ->j_num_trans until umount is triggered. call flow: ``` [md5sum] //line 53 54 vfs_read ocfs2_file_read_iter ocfs2_inode_lock_atime ocfs2_update_inode_atime + ocfs2_start...

...ong, we should > >>> mark RO as early as possible when JBD ABORT happens. In my view, the best place > >>> is my [2/2] patch code which in ocfs2_commit_cache(). > >>> > >> > >> Agree, but ocfs2_abort() is more appropriate here, see > >> ocfs2_start_trans(). But ocfs2_abort() may panic system, I'm afraid it > >> has to change to read-only accordingly. > > > > You are right. I ever used ocfs2_abort() then got panic. :) > > So I changed to ocfs2_error(). I also sent two mails in 2023-4-30 (the first > > mail has...

Found 15 patches (out of 162) that appeared relevant to ocfs2 1.4. Please review. Sunil

...;>>>> mark RO as early as possible when JBD ABORT happens. In my view, the best place >>>>> is my [2/2] patch code which in ocfs2_commit_cache(). >>>>> >>>> >>>> Agree, but ocfs2_abort() is more appropriate here, see >>>> ocfs2_start_trans(). But ocfs2_abort() may panic system, I'm afraid it >>>> has to change to read-only accordingly. >>> >>> You are right. I ever used ocfs2_abort() then got panic. :) >>> So I changed to ocfs2_error(). I also sent two mails in 2023-4-30 (the first >>...

Hi, This is the second batch of Ocfs2 patches intended for the merge window. The 1st batch were sent out previously: http://lkml.org/lkml/2008/12/19/280 The bulk of this set is comprised of Jan Kara's patches to add quota support to Ocfs2. Many of the quota patches are to generic code, which I carried to make merging of the Ocfs2 support easier. All of the non-ocfs2 patches should have

...17 Jun 20 20:42:01 H3CRDS11-RD kernel: [17509.034826] [<ffffffff813188d4>] call_rwsem_down_read_failed+0x14/0x30 Jun 20 20:42:01 H3CRDS11-RD kernel: [17509.034833] [<ffffffff8165b754>] ? down_read+0x24/0x2b Jun 20 20:42:01 H3CRDS11-RD kernel: [17509.034859] [<ffffffffa0553b11>] ocfs2_start_trans+0xe1/0x1e0 [ocfs2] Jun 20 20:42:01 H3CRDS11-RD kernel: [17509.034878] [<ffffffffa052ab35>] ocfs2_write_begin_nolock+0x945/0x1c40 [ocfs2] Jun 20 20:42:01 H3CRDS11-RD kernel: [17509.034903] [<ffffffffa054cb90>] ? ocfs2_inode_is_valid_to_delete+0x1f0/0x1f0 [ocfs2] Jun 20 20:42:01 H3CRDS...