search for: ocfs2_quota_write

ocfs2_quota_write needs to release the lock if it fails to read quota block. So use "goto out" instead of "return err". Cc: Jan Kara <jack at suse.cz> Signed-off-by: Tao Ma <tao.ma at oracle.com> --- fs/ocfs2/quota_global.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)...

Hi Jan, I am now reading quota support in ocfs2 and have some qs. Wish you can help me clarify it. Thanks. ocfs2_quota_write: In the comment, you said that "we know the transaction is already started", so it should be called within a transaction. But in this function, we call ocfs2_extend_no_holes and ocfs2_simple_size_update which will start another transaction. So we can survive with nested transaction o...

There is an error path in ocfs2_quota_write() that doesn't unlock &gqinode->i_mutex(). That seems unintentional. Found by smatch (http://repo.or.cz/w/smatch.git). Compile tested. regards, dan carpenter Signed-off-by: Dan Carpenter <error27 at gmail.com> --- orig/fs/ocfs2/quota_global.c 2009-04-07 19:34:22.000000000 +0...

...hran (1): ocfs2: Initialize the cluster we're writing to in a non-sparse extend Tao Ma (3): ocfs2: Add extra credits and access the modified bh in update_edge_lengths. ocfs2: Use ocfs2_rec_clusters in ocfs2_adjust_adjacent_records. ocfs2/quota: Release lock for error in ocfs2_quota_write. Wengang Wang (3): ocfs2: log the actual return value of ocfs2_file_aio_write() ocfs2: Fix error return in ocfs2_write_cluster() ocfs2: Fail ocfs2_get_block() immediately when a block needs allocation fs/ocfs2/alloc.c | 47 +++++++++++++-- fs/ocfs2/aops.c...

...ad(inode)); v_blkno = 0; while (v_blkno < num_blocks) { status = ocfs2_extent_map_get_blocks(inode, v_blkno, diff --git a/fs/ocfs2/quota_global.c b/fs/ocfs2/quota_global.c index 1ed0f7c..df46418 100644 --- a/fs/ocfs2/quota_global.c +++ b/fs/ocfs2/quota_global.c @@ -210,7 +210,7 @@ ssize_t ocfs2_quota_write(struct super_block *sb, int type, } mutex_lock_nested(&gqinode->i_mutex, I_MUTEX_QUOTA); - if (gqinode->i_size < off + len) { + if (i_size_read(gqinode) < off + len) { down_write(&OCFS2_I(gqinode)->ip_alloc_sem); err = ocfs2_extend_no_holes(gqinode, off + len, off...

Hi, I did some more in-depth testing of OCFS2 quota code, especially with ECC feature enabled and spotted some problems. First four patches fix them. I need the fifth patch to be able to mount OCFS2 filesystem with 2.6.31-rc3. The sixth patch fixes a potential problem when quota syncing interval is updated while the cluster is running (which is not possible currently). Joel, could you please

...+static int ocfs2_unfreeze_fs(struct super_block *sb); static const struct super_operations ocfs2_sops = { .statfs = ocfs2_statfs, @@ -149,6 +153,8 @@ static const struct super_operations ocfs2_sops = { .show_options = ocfs2_show_options, .quota_read = ocfs2_quota_read, .quota_write = ocfs2_quota_write, + .freeze_fs = ocfs2_freeze_fs, + .unfreeze_fs = ocfs2_unfreeze_fs, }; enum { @@ -383,7 +389,7 @@ static const struct file_operations ocfs2_osb_debug_fops = { static int ocfs2_sync_fs(struct super_block *sb, int wait) { - int status; + int status, flush_journal = 0; tid_t target; struc...

Hi, here is the second version of OCFS2 quota fixes with Joel's comments fixed. Also I've added a patch defining counts of credits for quota operations as Joel asked. Honza

Hi, This is the second batch of Ocfs2 patches intended for the merge window. The 1st batch were sent out previously: http://lkml.org/lkml/2008/12/19/280 The bulk of this set is comprised of Jan Kara's patches to add quota support to Ocfs2. Many of the quota patches are to generic code, which I carried to make merging of the Ocfs2 support easier. All of the non-ocfs2 patches should have

Hi, this is the next version of quota support for quota tools. I've addressed all the comments of Tao, Joel and others. Sparse feature disabling also correctly updates quota information now and the patch is merged into the tunefs support patch. Honza

The following series of patches attempts to detach metadata I/O from struct inode. They are currently tied together pretty tightly. Metadata reads happen via the ocfs2_read_blocks() functions, writes via both jbd2 and ocfs2_write_blocks(). - Each inode has a cache of associated metadata blocks stored on its ip_metadata_cache member. The ocfs2_read/write_blocks() functions take a struct