search for: ocfs2_inode_lock_with_pag

My log says suddenly: Dec 14 02:35:16 hp1 kernel: [1492482.232822] o2net: no longer connected to node hp2 (num 1) at 192.168.1.2:7777 Dec 14 02:35:18 hp1 kernel: [1492483.960150] BUG: soft lockup - CPU#1 stuck for 61s! [kvm:32398] I have no idea what happens here and why - but the result are a lot of problems with virtual machines. Viele Gr??e Andreas Rittershofer -- Hier k?nnte keine

...l+0x17a/0xd08 Apr 20 17:31:52 um-fe-1 [ 9123.585958] [<ffffffff8042957d>] ? _spin_unlock_irqrestore+0x7/0xe Apr 20 17:31:52 um-fe-1 [ 9123.585958] [<ffffffffa032915e>] ? :ocfs2:ocfs2_cluster_unlock+0x21d/0x289 Apr 20 17:31:52 um-fe-1 [ 9123.585958] [<ffffffffa032c8d9>] ? :ocfs2:ocfs2_inode_lock_with_page+0x1f/0x5f Apr 20 17:31:52 um-fe-1 [ 9123.585958] [<ffffffffa032311f>] ? :ocfs2:ocfs2_readpage+0x7e/0x33f Apr 20 17:31:52 um-fe-1 [ 9123.585958] [<ffffffff80270eef>] ? find_get_page+0x4a/0x54 Apr 20 17:31:52 um-fe-1 [ 9123.585958] [<ffffffff80272bdc>] ? generic_file_aio_read+0x...

Hi, here comes the next version of OCFS2 lockdep support. I've dropped patches with fixes from the series since they were already merged. As Joel suggested, I've simplified the main patch a bit so that we don't have ifdefs around lock declarations and there are also a few other minor improvements. Honza

...c int ocfs2_readpage(struct file *file, struct page *page) loff_t start = (loff_t)page->index << PAGE_CACHE_SHIFT; int ret, unlock = 1; - mlog_entry("(0x%p, %lu)\n", file, (page ? page->index : 0)); + mlog_entry("(0x%p, %lu)\n", file, page->index); ret = ocfs2_inode_lock_with_page(inode, NULL, 0, page); if (ret != 0) { @@ -344,17 +357,21 @@ static int ocfs2_readpages(struct file *filp, struct address_space *mapping, loff_t start; struct page *last; + mlog_entry("(0x%p, 0x%p, 0x%p, %u)\n", filp, mapping, pages, nr_pages); + /* * Use the nonblocking fla...

...c int ocfs2_readpage(struct file *file, struct page *page) loff_t start = (loff_t)page->index << PAGE_CACHE_SHIFT; int ret, unlock = 1; - mlog_entry("(0x%p, %lu)\n", file, (page ? page->index : 0)); + mlog_entry("(0x%p, %lu)\n", file, page->index); ret = ocfs2_inode_lock_with_page(inode, NULL, 0, page); if (ret != 0) { @@ -344,17 +359,21 @@ static int ocfs2_readpages(struct file *filp, struct address_space *mapping, loff_t start; struct page *last; + mlog_entry("(0x%p, 0x%p, 0x%p, %u)\n", filp, mapping, pages, nr_pages); + /* * Use the nonblocking fla...

...c int ocfs2_readpage(struct file *file, struct page *page) loff_t start = (loff_t)page->index << PAGE_CACHE_SHIFT; int ret, unlock = 1; - mlog_entry("(0x%p, %lu)\n", file, (page ? page->index : 0)); + mlog_entry("(0x%p, %lu)\n", file, page->index); ret = ocfs2_inode_lock_with_page(inode, NULL, 0, page); if (ret != 0) { @@ -344,17 +359,21 @@ static int ocfs2_readpages(struct file *filp, struct address_space *mapping, loff_t start; struct page *last; + mlog_entry("(0x%p, 0x%p, 0x%p, %u)\n", filp, mapping, pages, nr_pages); + /* * Use the nonblocking fla...

Hi, the first four patches in this series fix locking problems in OCFS2 quota code (three of them can lead to potential deadlocks). The fifth patch reorders ip_alloc_sem for directories to be acquired before localalloc locks. Mark would you please merge these? The last two patches implement lockdep annotations for OCFS2 cluster locks. We annotate all the cluster locks except for special ones

Hi, I'm resending this patch series. It's rediffed against linux-next branch of Joel's git tree. The first four patches are obvious fixes of deadlocks in quota code and should go in as soon as possible. The other three patches implement lockdep support for OCFS2 cluster locks. So you can have a look whether the code make sence to you and possibly merge them. They should be NOP when