search for: ocfs2_dismount_volume

Patch 5 has been respun with the recommended change... remove the ex argument in ocfs2_orphan_scan_lock() and ocfs2_orphan_scan_unlock(). Sunil

I can reproduce this in my local VM. I've traced ocfs2_dismount_volume and found that it hasn't been called. So EBUSY is returned in VFS layer. I guess something wrong when doing a copy with linked SQEs (normal copy seems no problem). Thanks, Joseph On 2/24/23 8:32 AM, Heming Zhao wrote: > Hello List, > > I found a weird bug on ocfs2. I am busying with...

...b)) + if (!ocfs2_is_hard_readonly(osb) && !ocfs2_mount_local(osb)) ocfs2_cluster_unlock(osb, &dl->dl_lockres, level); } diff --git a/fs/ocfs2/super.c b/fs/ocfs2/super.c index 5a521c7..395b26f 100644 --- a/fs/ocfs2/super.c +++ b/fs/ocfs2/super.c @@ -1973,7 +1973,8 @@ static void ocfs2_dismount_volume(struct super_block *sb, int mnt_err) * If we failed before we got a uuid_str yet, we can't stop * heartbeat. Otherwise, do it. */ - if (!mnt_err && !ocfs2_mount_local(osb) && osb->uuid_str) + if (!mnt_err && !ocfs2_mount_local(osb) && osb->uuid_st...

On 2/24/23 2:54 PM, Joseph Qi wrote: > I can reproduce this in my local VM. > I've traced ocfs2_dismount_volume and found that it hasn't been called. > So EBUSY is returned in VFS layer. I guess something wrong when doing > a copy with linked SQEs (normal copy seems no problem). > I am inclined to agree with you. I also test liburing examples apps on ext4 partition, everything looks fine. I u...

Hi, All, These four patches are all related to ocfs2 on hard readonly mount. patch 1 fix oops when umount ocfs2 on hard readonly device. Because ocfs2_dismount_volume() will call ocfs2_cluster_hangup() and then call ocfs2_stack_driver_put(), will hit BUG_ON(active_stack == NULL). patch 2 fix oops when do ls or cat in ocfs2 on hard readonly device. Because ocfs2_open_lock() will call ocfs2_cluster_lock() and then call ocfs2_dlm_lock(), but active_stack is NULL...

On 2/24/23 3:48 PM, Heming Zhao via Ocfs2-devel wrote: > On 2/24/23 2:54 PM, Joseph Qi wrote: >> I can reproduce this in my local VM. >> I've traced ocfs2_dismount_volume and found that it hasn't been called. >> So EBUSY is returned in VFS layer. I guess something wrong when doing >> a copy with linked SQEs (normal copy seems no problem). >> > > I am inclined to agree with you. I also test liburing examples apps > on ext4 partition, e...

On 2/24/23 3:52 PM, Joseph Qi wrote: > > > On 2/24/23 3:48 PM, Heming Zhao via Ocfs2-devel wrote: >> On 2/24/23 2:54 PM, Joseph Qi wrote: >>> I can reproduce this in my local VM. >>> I've traced ocfs2_dismount_volume and found that it hasn't been called. >>> So EBUSY is returned in VFS layer. I guess something wrong when doing >>> a copy with linked SQEs (normal copy seems no problem). >>> >> >> I am inclined to agree with you. I also test liburing examples apps >&g...

On 2/24/23 4:03 PM, Heming Zhao wrote: > On 2/24/23 3:52 PM, Joseph Qi wrote: >> >> >> On 2/24/23 3:48 PM, Heming Zhao via Ocfs2-devel wrote: >>> On 2/24/23 2:54 PM, Joseph Qi wrote: >>>> I can reproduce this in my local VM. >>>> I've traced ocfs2_dismount_volume and found that it hasn't been called. >>>> So EBUSY is returned in VFS layer. I guess something wrong when doing >>>> a copy with linked SQEs (normal copy seems no problem). >>>> >>> >>> I am inclined to agree with you. I also test liburing...

In commit ea455f8ab68338ba69f5d3362b342c115bea8e13, we move the dentry lock put process into ocfs2_wq. This is OK for most case, but as for umount, it lead to at least 2 bugs. See http://oss.oracle.com/bugzilla/show_bug.cgi?id=1133 and http://oss.oracle.com/bugzilla/show_bug.cgi?id=1135. And it happens easily if we have opened a lot of inodes. For 1135, the reason is that during umount will call

...e a crash. BUG: KASAN: slab-use-after-free in timer_delete+0x54/0xc0 Read of size 8 at addr ffff8880389a8208 by task umount/669 ... Call Trace: <TASK> ... timer_delete+0x54/0xc0 try_to_grab_pending+0x31/0x230 __cancel_work_timer+0x6c/0x270 ocfs2_disable_quotas.isra.0+0x3e/0xf0 [ocfs2] ocfs2_dismount_volume+0xdd/0x450 [ocfs2] generic_shutdown_super+0xaa/0x280 kill_block_super+0x46/0x70 deactivate_locked_super+0x4d/0xb0 cleanup_mnt+0x135/0x1f0 ... </TASK> Allocated by task 632: kasan_save_stack+0x1c/0x40 kasan_set_track+0x21/0x30 __kasan_kmalloc+0x8b/0x90 ocfs2_local_read_info+0xe3/0x9...

...i wrote: >>>>> >>>>> >>>>> On 2/24/23 3:48 PM, Heming Zhao via Ocfs2-devel wrote: >>>>>> On 2/24/23 2:54 PM, Joseph Qi wrote: >>>>>>> I can reproduce this in my local VM. >>>>>>> I've traced ocfs2_dismount_volume and found that it hasn't been called. >>>>>>> So EBUSY is returned in VFS layer. I guess something wrong when doing >>>>>>> a copy with linked SQEs (normal copy seems no problem). >>>>>>> >>>>>> >>>>&gt...

...te: > > On 2/24/23 3:52 PM, Joseph Qi wrote: > >> > >> > >> On 2/24/23 3:48 PM, Heming Zhao via Ocfs2-devel wrote: > >>> On 2/24/23 2:54 PM, Joseph Qi wrote: > >>>> I can reproduce this in my local VM. > >>>> I've traced ocfs2_dismount_volume and found that it hasn't been called. > >>>> So EBUSY is returned in VFS layer. I guess something wrong when doing > >>>> a copy with linked SQEs (normal copy seems no problem). > >>>> > >>> > >>> I am inclined to agree with y...

Dear Sirs and Madams, I run a small visual effects production company, Hammerhead Productions. We'd like to have an easily extensible inexpensive relatively high-performance storage network using open-source components. I was hoping that OCFS2 would be that system. I have a half-dozen 2 TB fileservers I'd like the rest of the network to see as a single 12 TB disk, with the aggregate

...PM, Joseph Qi wrote: > > >> > > >> > > >> On 2/24/23 3:48 PM, Heming Zhao via Ocfs2-devel wrote: > > >>> On 2/24/23 2:54 PM, Joseph Qi wrote: > > >>>> I can reproduce this in my local VM. > > >>>> I've traced ocfs2_dismount_volume and found that it hasn't been called. > > >>>> So EBUSY is returned in VFS layer. I guess something wrong when doing > > >>>> a copy with linked SQEs (normal copy seems no problem). > > >>>> > > >>> > > >>> I am...

...;>> >>>>>> >>>>>> On 2/24/23 3:48 PM, Heming Zhao via Ocfs2-devel wrote: >>>>>>> On 2/24/23 2:54 PM, Joseph Qi wrote: >>>>>>>> I can reproduce this in my local VM. >>>>>>>> I've traced ocfs2_dismount_volume and found that it hasn't been called. >>>>>>>> So EBUSY is returned in VFS layer. I guess something wrong when doing >>>>>>>> a copy with linked SQEs (normal copy seems no problem). >>>>>>>> >>>>>>> &gt...

...val 5 seconds (11637,3):ocfs2_broadcast_vote:434 ERROR: status = -75 (11637,3):ocfs2_do_request_vote:504 ERROR: status = -75 (11637,3):ocfs2_mount_volume:1117 ERROR: status = -75 (11637,3):ocfs2_broadcast_vote:434 ERROR: status = -75 (11637,3):ocfs2_do_request_vote:504 ERROR: status = -75 (11637,3):ocfs2_dismount_volume:1179 ERROR: status = -75 ocfs2: Unmounting device (8,17) on (node 1) o2net: no longer connected to node serv_i386 (num 0) at 19X.XXX.69.194:7777 -------------------- and in serv_i386's these -------------------- o2net: accepted connection from node serv_x86_64 (num 1) at 19X.XXX.69.196:7777 o...

Hello List, I found a weird bug on ocfs2. I am busying with other jobs, if anyone have time he/she could fix it. This bug is blocking fstest generic/013 test case, and also blocking fstest to do later test cases. How to trigger: ``` git clone git://git.kernel.dk/liburing.git cd liburing make cd examples mount -t ocfs2 /dev/sda /mnt cp /etc/hosts /mnt/a ./link-cp /mnt/a /mnt/b umount /mnt ```

...er_delete+0x54/0xc0 > Read of size 8 at addr ffff8880389a8208 by task umount/669 > ... > Call Trace: > <TASK> > ... > timer_delete+0x54/0xc0 > try_to_grab_pending+0x31/0x230 > __cancel_work_timer+0x6c/0x270 > ocfs2_disable_quotas.isra.0+0x3e/0xf0 [ocfs2] > ocfs2_dismount_volume+0xdd/0x450 [ocfs2] > generic_shutdown_super+0xaa/0x280 > kill_block_super+0x46/0x70 > deactivate_locked_super+0x4d/0xb0 > cleanup_mnt+0x135/0x1f0 > ... > </TASK> > > Allocated by task 632: > kasan_save_stack+0x1c/0x40 > kasan_set_track+0x21/0x30 > __...

On Fri, 26 May 2023 09:36:25 +0800 Joseph Qi <joseph.qi at linux.alibaba.com> wrote: > Hi Andrew, > > There is an updated version v2, which describe more clearly about the > case: > https://lore.kernel.org/ocfs2-devel/e9fc4b2f-1fcc-7c31-f346-59eccff50f9b at linux.alibaba.com/T/#u Sigh. Thanks. As you can see from the above link, the email never hit ocfs2-devel and never

...e a crash. BUG: KASAN: slab-use-after-free in timer_delete+0x54/0xc0 Read of size 8 at addr ffff8880389a8208 by task umount/669 ... Call Trace: <TASK> ... timer_delete+0x54/0xc0 try_to_grab_pending+0x31/0x230 __cancel_work_timer+0x6c/0x270 ocfs2_disable_quotas.isra.0+0x3e/0xf0 [ocfs2] ocfs2_dismount_volume+0xdd/0x450 [ocfs2] generic_shutdown_super+0xaa/0x280 kill_block_super+0x46/0x70 deactivate_locked_super+0x4d/0xb0 cleanup_mnt+0x135/0x1f0 ... </TASK> Allocated by task 632: kasan_save_stack+0x1c/0x40 kasan_set_track+0x21/0x30 __kasan_kmalloc+0x8b/0x90 ocfs2_local_read_info+0xe3/0x9...