search for: ocfs2_abort

...new >>> IOs will trigger IO error then trigger RO status. This flow is wrong, we should >>> mark RO as early as possible when JBD ABORT happens. In my view, the best place >>> is my [2/2] patch code which in ocfs2_commit_cache(). >>> >> >> Agree, but ocfs2_abort() is more appropriate here, see >> ocfs2_start_trans(). But ocfs2_abort() may panic system, I'm afraid it >> has to change to read-only accordingly. > > You are right. I ever used ocfs2_abort() then got panic. :) > So I changed to ocfs2_error(). I also sent two mails in 20...

...serspace, then the new > > IOs will trigger IO error then trigger RO status. This flow is wrong, we should > > mark RO as early as possible when JBD ABORT happens. In my view, the best place > > is my [2/2] patch code which in ocfs2_commit_cache(). > > > > Agree, but ocfs2_abort() is more appropriate here, see > ocfs2_start_trans(). But ocfs2_abort() may panic system, I'm afraid it > has to change to read-only accordingly. You are right. I ever used ocfs2_abort() then got panic. :) So I changed to ocfs2_error(). I also sent two mails in 2023-4-30 (the first mail...

...l trigger IO error then trigger RO status. This flow is wrong, we should > >>> mark RO as early as possible when JBD ABORT happens. In my view, the best place > >>> is my [2/2] patch code which in ocfs2_commit_cache(). > >>> > >> > >> Agree, but ocfs2_abort() is more appropriate here, see > >> ocfs2_start_trans(). But ocfs2_abort() may panic system, I'm afraid it > >> has to change to read-only accordingly. > > > > You are right. I ever used ocfs2_abort() then got panic. :) > > So I changed to ocfs2_error(). I...

...ror then trigger RO status. This flow is wrong, we should >>>>> mark RO as early as possible when JBD ABORT happens. In my view, the best place >>>>> is my [2/2] patch code which in ocfs2_commit_cache(). >>>>> >>>> >>>> Agree, but ocfs2_abort() is more appropriate here, see >>>> ocfs2_start_trans(). But ocfs2_abort() may panic system, I'm afraid it >>>> has to change to read-only accordingly. >>> >>> You are right. I ever used ocfs2_abort() then got panic. :) >>> So I changed to ocf...

fstest generic cases 347 361 628 629 trigger a same issue: When jbd2 enter ABORT status, ocfs2 ignores it and keep going to commit journal. This commit gives ocfs2 ability to handle jbd2 ABORT case. Signed-off-by: Heming Zhao <heming.zhao at suse.com> --- fs/ocfs2/alloc.c | 10 ++++++---- fs/ocfs2/journal.c | 5 +++++ fs/ocfs2/localalloc.c | 3 +++ 3 files changed, 14

On 10/14/2015 03:57 AM, Joseph Qi wrote: > On 2015/10/14 16:45, Zhangguanghui wrote: >> Hi, >> "status = -30" means it has encountered EROFS when start transaction. >> And system panic is because s_mount_opt is set to OCFS2_MOUNT_ERRORS_PANIC in __ocfs2_abort, >> ideal with OCFS2_MOUNT_ERRORS_PANIC first in ocfs2_handle_error. >> so I think that it is not reasonable, Therefore, this setting shall be canceled in __ocfs2_abort. >> thanks >> > The option is set when mounting and __ocfs2_abort does the check and > then perfo...

Hi, "status = -30" means it has encountered EROFS when start transaction. And system panic is because s_mount_opt is set to OCFS2_MOUNT_ERRORS_PANIC in __ocfs2_abort, ideal with OCFS2_MOUNT_ERRORS_PANIC first in ocfs2_handle_error. so I think that it is not reasonable, Therefore, this setting shall be canceled in __ocfs2_abort. thanks ________________________________ zhangguanghui From: Joseph Qi<mailto:joseph.qi at huawei.com> Date: 2015-10-14 16:13...