search for: ocamlmklib

Pass the LDFLAGS properly as arguments for the C linker when using ocamlmklibs via the -ldopt option. Followup of commit 34c23403c51a4d59d826c8045e06f9aabc2ceb16. --- ocaml/Makefile.am | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ocaml/Makefile.am b/ocaml/Makefile.am index 752fc109c..4d13eed97 100644 --- a/ocaml/Makefile.am +++ b/ocaml/Makefile.a...

...iles that it generates. > noinst_LIBRARIES = libguestfsocaml.a > > You'll need to change all the places where > $(libguestfsocaml_a_OBJECTS) is used instead, eg something like this > untested change: > > stamp-mlguestfs: libguestfsocaml.a $(guestfs_cmm) > $(OCAMLMKLIB) -o mlguestfs \ > $(libguestfsocaml_a_OBJECTS) guestfs.cmo \ > $(LDFLAGS) \ > $(LTLIBINTL) \ > - -L../lib/.libs -lguestfs > + -L../lib/.libs -lguestfs \ > + -L../gnulib/lib/.libs -lgnu > if HAVE_OCAMLOPT > $(...

Use the ocamlmklib -ldopt flag to pass the general $(LDFLAGS) when calling gcc to link dllmlhivex.so. We were already passing $(CFLAGS) when building the object file. When building using Fedora's standard hardening flags this gives: ocamlmklib -o mlhivex hivex_c.o hivex.cmo \ -verbose -ldopt '-Wl,-z,re...

On Fri, Sep 01, 2017 at 04:28:52AM -0400, Yongkui Guo wrote: > > stamp-mlguestfs: libguestfsocaml.a $(guestfs_cmm) > > $(OCAMLMKLIB) -o mlguestfs \ > > $(libguestfsocaml_a_OBJECTS) guestfs.cmo \ > > $(LDFLAGS) \ > > $(LTLIBINTL) \ > > - -L../lib/.libs -lguestfs > > + -L../lib/.libs -lguestfs \ > > + -L../gnulib/lib/.libs -lgnu [...] &gt...

Pino alerted me to this problem -- it's quite clear if you try to compile libguestfs from git on RHEL 7. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats, disk stats,

...FLMPSUVYZX-3 -package unix -c guestfs.ml -o guestfs.cmx rm -f libguestfsocaml.a ar cr libguestfsocaml.a libguestfsocaml_a-guestfs-c.o libguestfsocaml_a-guestfs-c-actions.o libguestfsocaml_a-guestfs-c-errnos.o ../common/utils/libguestfsocaml_a-utils.o ../gnulib/lib/libgnu.la ranlib libguestfsocaml.a ocamlmklib -o mlguestfs \ libguestfsocaml_a-guestfs-c.o libguestfsocaml_a-guestfs-c-actions.o libguestfsocaml_a-guestfs-c-errnos.o ../common/utils/libguestfsocaml_a-utils.o guestfs.cmo \ -fprofile-arcs -ftest-coverage -lgcov \ \ -L../lib/.libs -lguestfs Unknown option -fprofile-arcs Unknown option -f...

...> > ^ This makes building the OCaml subdirectory very slow (I normally > build with MAKEFLAGS=-j9). Was there a reason for adding this? I think I added this because both the mlguestfs.cma and mlguestfs.cmxa targets generate libmlguestfs.a: mlguestfs.cma: libguestfsocaml.a guestfs.cmo $(OCAMLMKLIB) -o mlguestfs \ $(libguestfsocaml_a_OBJECTS) guestfs.cmo \ -L$(top_builddir)/src/.libs -lguestfs mlguestfs.cmxa: libguestfsocaml.a guestfs.cmx $(OCAMLMKLIB) -o mlguestfs \ $(libguestfsocaml_a_OBJECTS) guestfs.cmx \ -L$(top_builddir)/src/.libs -lguestfs As far as I know, those are the...

...s # library; we link with the object files that it generates. noinst_LIBRARIES = libguestfsocaml.a You'll need to change all the places where $(libguestfsocaml_a_OBJECTS) is used instead, eg something like this untested change: stamp-mlguestfs: libguestfsocaml.a $(guestfs_cmm) $(OCAMLMKLIB) -o mlguestfs \ $(libguestfsocaml_a_OBJECTS) guestfs.cmo \ $(LDFLAGS) \ $(LTLIBINTL) \ - -L../lib/.libs -lguestfs + -L../lib/.libs -lguestfs \ + -L../gnulib/lib/.libs -lgnu if HAVE_OCAMLOPT $(OCAMLMKLIB) -o mlguestfs \ $(...

...| 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/ocaml/Makefile.am b/ocaml/Makefile.am index fbeefc9..eac9b84 100644 --- a/ocaml/Makefile.am +++ b/ocaml/Makefile.am @@ -49,12 +49,12 @@ noinst_LIBRARIES = libguestfsocaml.a mlguestfs.cma: libguestfsocaml.a guestfs.cmo $(OCAMLMKLIB) -o mlguestfs \ - $(am_libguestfsocaml_a_OBJECTS) guestfs.cmo \ + $(libguestfsocaml_a_OBJECTS) guestfs.cmo \ -L$(top_builddir)/src/.libs -lguestfs mlguestfs.cmxa: libguestfsocaml.a guestfs.cmx $(OCAMLMKLIB) -o mlguestfs \ - $(am_libguestfsocaml_a_OBJECTS) guestfs.cmx \ + $(libguestf...

From: "Richard W.M. Jones" <rjones at redhat.com> --- configure.ac | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/configure.ac b/configure.ac index fa97479..6e42423 100644 --- a/configure.ac +++ b/configure.ac @@ -141,6 +141,10 @@ if test "$gl_gcc_warnings" = yes; then # Work around warning in src/inspect.c. This seems to be a bug in gcc

...the same time, they will stomp on or # corrupt each others copy. Hence we have to serialize the calls. -CLEANFILES += stamp-mlguestfs - -mlguestfs.cma mlguestfs.cmxa: stamp-mlguestfs - -stamp-mlguestfs: libguestfsocaml.a guestfs.cmo guestfs.cmx +mlguestfs.cma: libguestfsocaml.a guestfs.cmo $(OCAMLMKLIB) -o mlguestfs \ $(libguestfsocaml_a_OBJECTS) guestfs.cmo \ -L$(top_builddir)/src/.libs -lguestfs + +mlguestfs.cmxa: libguestfsocaml.a guestfs.cmx $(OCAMLMKLIB) -o mlguestfs \ $(libguestfsocaml_a_OBJECTS) guestfs.cmx \ -L$(top_builddir)/src/.libs -lguestfs - touch $@ libguestfso...

...ion is 3.12.1 > OCaml library path is /usr/lib/ocaml > checking for ocamlopt... ocamlopt > checking for ocamlc.opt... no > checking for ocamlopt.opt... no > checking for ocaml... ocaml > checking for ocamldep... ocamldep > checking for ocamlmktop... ocamlmktop > checking for ocamlmklib... ocamlmklib > checking for ocamldoc... ocamldoc > checking for ocamlbuild... ocamlbuild > checking for bash... /bin/bash > checking for python... /usr/bin/python > checking for python version >= 2.3 ... yes > checking how to run the C preprocessor... gcc -E > checking for...

I believe this patch has now been superseded by Hilko's commit here: https://github.com/libguestfs/libguestfs/commit/f75142c577255b30f2a8e1d27baa5fd185594197 Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming blog: http://rwmj.wordpress.com Fedora now supports 80 OCaml packages (the OPEN alternative to F#)

...$(LIBINTL) -lncurses -lcrypt \ -L../src/.libs -lutils \ -L../gnulib/lib/.libs -lgnu diff --git a/ocaml/Makefile.am b/ocaml/Makefile.am index 41270a6..9723af9 100644 --- a/ocaml/Makefile.am +++ b/ocaml/Makefile.am @@ -66,10 +66,12 @@ endif stamp-mlguestfs: libguestfsocaml.a $(guestfs_cmm) $(OCAMLMKLIB) -o mlguestfs \ $(libguestfsocaml_a_OBJECTS) guestfs.cmo \ + $(LTLIBINTL) \ -L$(top_builddir)/src/.libs -lguestfs if HAVE_OCAMLOPT $(OCAMLMKLIB) -o mlguestfs \ $(libguestfsocaml_a_OBJECTS) guestfs.cmx \ + $(LTLIBINTL) \ -L$(top_builddir)/src/.libs -lguestfs endif touch $@...

* Richard W.M. Jones: > (1) Removing .NOTPARALLEL. This fails, as expected. > > (2) mlguestfs.cmxa: mlguestfs.cma -- fails > > (3) mlguestfs.cmxa: | mlguestfs.cma -- fails after a longer time I find it strange that (2) and (3) fail. > (4) The attached patch which is derived from dce94f -- this ran > without failing for 120 iterations (and still going). The patch looks

...th... yes checking for ocamlc... ocamlc OCaml version is 3.11.2 OCaml library path is /usr/lib/ocaml checking for ocamlopt... ocamlopt checking for ocamlc.opt... ocamlc.opt checking for ocamlopt.opt... ocamlopt.opt checking for ocamldep... ocamldep checking for ocamlmktop... ocamlmktop checking for ocamlmklib... ocamlmklib checking for ocamldoc... ocamldoc checking for ocamlbuild... ocamlbuild checking for ocamlfind... ocamlfind checking for OCaml findlib package xmlm... found checking for OCaml findlib package type_conv... not found configure: creating ./config.status config.status: creating Makefile c...

Even if ocamlopt is available, always build a bytecode version of ‘common/mlstdutils’. Furthermore, because this library is pure OCaml, we should not be using ‘ocamlmklib’. We should use ‘ocaml{c,opt} -a’ instead. This doesn't make any difference for native code, but for bytecode it was building a broken library. The original reason for making this change is because the generator is always built as bytecode, and it depended on ‘../common/mlstdutils/guestfs_co...

Even if ocamlopt is available, always build a bytecode version of ‘common/mlstdutils’. Furthermore, because this library is pure OCaml, we should not be using ‘ocamlmklib’. We should use ‘ocaml{c,opt} -a’ instead. This doesn't make any difference for native code, but for bytecode it was building a broken library. The original reason for making this change is because the generator is always built as bytecode, and it depended on ‘../common/mlstdutils/guestfs_co...

On Thursday, 13 July 2017 16:38:14 CEST Richard W.M. Jones wrote: > Even if ocamlopt is available, always build a bytecode version of > ‘common/mlstdutils’. > > Furthermore, because this library is pure OCaml, we should not be > using ‘ocamlmklib’. We should use ‘ocaml{c,opt} -a’ instead. This > doesn't make any difference for native code, but for bytecode it was > building a broken library. > > The original reason for making this change is because the generator is > always built as bytecode, and it depended on > ‘....

...bs -lutils \ > -L../gnulib/lib/.libs -lgnu > > diff --git a/ocaml/Makefile.am b/ocaml/Makefile.am > index 41270a6..9723af9 100644 > --- a/ocaml/Makefile.am > +++ b/ocaml/Makefile.am > @@ -66,10 +66,12 @@ endif > stamp-mlguestfs: libguestfsocaml.a $(guestfs_cmm) > $(OCAMLMKLIB) -o mlguestfs \ > $(libguestfsocaml_a_OBJECTS) guestfs.cmo \ > + $(LTLIBINTL) \ > -L$(top_builddir)/src/.libs -lguestfs > if HAVE_OCAMLOPT > $(OCAMLMKLIB) -o mlguestfs \ > $(libguestfsocaml_a_OBJECTS) guestfs.cmx \ > + $(LTLIBINTL) \ > -L$(top_builddir...