search for: obirvalger

Patch supplied by Mikhail Gordeev, posting for review. I have compile tested it and checked the code and it looks all fine to me, so ACK from my point of view. I did not actually run it because I don't have an ALT Linux install, but it doesn't seem as if it would affect any other distro. Rich.

From: Mikhail Gordeev <obirvalger@altlinux.org> --- v2v/convert_linux.ml | 49 +++++++++++++++++++++++++++++++++++++++++++ v2v/convert_linux.mli | 2 +- 2 files changed, 50 insertions(+), 1 deletion(-) diff --git a/v2v/convert_linux.ml b/v2v/convert_linux.ml index a871d754f4..5ae83a2f66 100644 --- a/v2v/convert_linux.ml +++...

On Monday, 24 August 2020 19:48:07 CEST Richard W.M. Jones wrote: > From: Mikhail Gordeev <obirvalger@altlinux.org> > It would be nicer to have few more details in the commit message and/or comments in the code, as there are things that definitely deserve explanations. Also, IMHO, it would be nice to have it split in different parts: 1) a simple patch that adds the ALT_family, in case it i...

Split code to patches, as suggested. Now there is no need for ALT_family in the code. But the code that checking family fails without adding it. ALT is not RHEL nor Debian based distro, so what family should be used if not adding ALT_family? I wrongly asumed that modules should be added to existing initrd instead of recreation. Now the part of code creating initrd is much shorter and simpler.

Add patches in the git format-patch format. -- Mikhail Gordeev