search for: obergfel

...iggers: virtio_net expected napi to be run immediately. One way to cause do_softirq to be executed is by invoking local_bh_enable(). As __napi_schedule is normally called from bh or irq context, this seems to make sense: disable bh before __napi_schedule and enable afterwards. Reported-by: Ulrich Obergfell <uobergfe at redhat.com> Tested-by: Ulrich Obergfell <uobergfe at redhat.com> Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- To test, one can hack try_fill_recv to always report oom. I'm not sure it's not too late for 3.4, but we can try. Rusty, could you revi...

...iggers: virtio_net expected napi to be run immediately. One way to cause do_softirq to be executed is by invoking local_bh_enable(). As __napi_schedule is normally called from bh or irq context, this seems to make sense: disable bh before __napi_schedule and enable afterwards. Reported-by: Ulrich Obergfell <uobergfe at redhat.com> Tested-by: Ulrich Obergfell <uobergfe at redhat.com> Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- To test, one can hack try_fill_recv to always report oom. I'm not sure it's not too late for 3.4, but we can try. Rusty, could you revi...

...his point, seeing msix is disabled, it may try to notify us with an IRQ, which is totally unexpected thus will not be handled. In this case the guest hangs. Let's reset the device so that it will not generate any interrupts. Link: https://bugzilla.redhat.com/show_bug.cgi?id=1128424 Cc: Ulrich Obergfell <uobergfe at redhat.com> Signed-off-by: Fam Zheng <famz at redhat.com> --- drivers/virtio/virtio_pci.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/drivers/virtio/virtio_pci.c b/drivers/virtio/virtio_pci.c index d34ebfa..cd7be6f 100644 --- a/drivers/virtio/virtio_pci.c...

...his point, seeing msix is disabled, it may try to notify us with an IRQ, which is totally unexpected thus will not be handled. In this case the guest hangs. Let's reset the device so that it will not generate any interrupts. Link: https://bugzilla.redhat.com/show_bug.cgi?id=1128424 Cc: Ulrich Obergfell <uobergfe at redhat.com> Signed-off-by: Fam Zheng <famz at redhat.com> --- drivers/virtio/virtio_pci.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/drivers/virtio/virtio_pci.c b/drivers/virtio/virtio_pci.c index d34ebfa..cd7be6f 100644 --- a/drivers/virtio/virtio_pci.c...

...sts complete. > > If true and implemented correctly, I don't see what else > needs to be done. > > You will need to debug this some more. First of all I was wrong about the fs driver above, scratch that, I'm sorry for the misleading. Regarding the hang in shutdown, Ulrich Obergfell has already pointed out that the vcpu is "busy/stuck in interrupt processing": https://bugzilla.redhat.com/attachment.cgi?id=998391 (RHBZ 1199155) Summary: The reason it is stuck is that an IRQ from virtio-scsi-pci is not handled. Why is there that IRQ? Because pci core code disabled m...

...sts complete. > > If true and implemented correctly, I don't see what else > needs to be done. > > You will need to debug this some more. First of all I was wrong about the fs driver above, scratch that, I'm sorry for the misleading. Regarding the hang in shutdown, Ulrich Obergfell has already pointed out that the vcpu is "busy/stuck in interrupt processing": https://bugzilla.redhat.com/attachment.cgi?id=998391 (RHBZ 1199155) Summary: The reason it is stuck is that an IRQ from virtio-scsi-pci is not handled. Why is there that IRQ? Because pci core code disabled m...

...rk, to be set by devices that wish to skip disabling msi on shutdown, relying on bus master instead. We set this quirk in virtio core. Reported-by: Fam Zheng <famz at redhat.com> Cc: Bjorn Helgaas <bhelgaas at google.com> Cc: Yinghai Lu <yhlu.kernel.send at gmail.com> Cc: Ulrich Obergfell <uobergfe at redhat.com> Cc: Rusty Russell <rusty at rustcorp.com.au> Cc: "Eric W. Biederman" <ebiederm at xmission.com> Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- changes from v6: limit changes to virtio only changes from v5: rebased on...

...rk, to be set by devices that wish to skip disabling msi on shutdown, relying on bus master instead. We set this quirk in virtio core. Reported-by: Fam Zheng <famz at redhat.com> Cc: Bjorn Helgaas <bhelgaas at google.com> Cc: Yinghai Lu <yhlu.kernel.send at gmail.com> Cc: Ulrich Obergfell <uobergfe at redhat.com> Cc: Rusty Russell <rusty at rustcorp.com.au> Cc: "Eric W. Biederman" <ebiederm at xmission.com> Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- changes from v6: limit changes to virtio only changes from v5: rebased on...

...tdown, relying on bus master instead. >> >> We set this quirk in virtio core. >> >> Reported-by: Fam Zheng <famz at redhat.com> >> Cc: Bjorn Helgaas <bhelgaas at google.com> >> Cc: Yinghai Lu <yhlu.kernel.send at gmail.com> >> Cc: Ulrich Obergfell <uobergfe at redhat.com> >> Cc: Rusty Russell <rusty at rustcorp.com.au> >> Cc: "Eric W. Biederman" <ebiederm at xmission.com> >> Signed-off-by: Michael S. Tsirkin <mst at redhat.com> > > Eric, what do you think of this? You had many comme...

...tdown, relying on bus master instead. >> >> We set this quirk in virtio core. >> >> Reported-by: Fam Zheng <famz at redhat.com> >> Cc: Bjorn Helgaas <bhelgaas at google.com> >> Cc: Yinghai Lu <yhlu.kernel.send at gmail.com> >> Cc: Ulrich Obergfell <uobergfe at redhat.com> >> Cc: Rusty Russell <rusty at rustcorp.com.au> >> Cc: "Eric W. Biederman" <ebiederm at xmission.com> >> Signed-off-by: Michael S. Tsirkin <mst at redhat.com> > > Eric, what do you think of this? You had many comme...

...ip disabling msi on > shutdown, relying on bus master instead. > > We set this quirk in virtio core. > > Reported-by: Fam Zheng <famz at redhat.com> > Cc: Bjorn Helgaas <bhelgaas at google.com> > Cc: Yinghai Lu <yhlu.kernel.send at gmail.com> > Cc: Ulrich Obergfell <uobergfe at redhat.com> > Cc: Rusty Russell <rusty at rustcorp.com.au> > Cc: "Eric W. Biederman" <ebiederm at xmission.com> > Signed-off-by: Michael S. Tsirkin <mst at redhat.com> Eric, what do you think of this? You had many comments on previous versi...

On Wed, 03/11 10:06, Michael S. Tsirkin wrote: > On Wed, Mar 11, 2015 at 04:09:17PM +0800, Fam Zheng wrote: > > Currently shutdown is nop for virtio devices, but the core code could > > remove things behind us such as MSI-X handler etc. For example in the > > case of virtio-scsi-pci, the device may still try to send interupts, > > which will be on IRQ lines seeing MSI-X

On Wed, 03/11 10:06, Michael S. Tsirkin wrote: > On Wed, Mar 11, 2015 at 04:09:17PM +0800, Fam Zheng wrote: > > Currently shutdown is nop for virtio devices, but the core code could > > remove things behind us such as MSI-X handler etc. For example in the > > case of virtio-scsi-pci, the device may still try to send interupts, > > which will be on IRQ lines seeing MSI-X

...;tyhicks@canonical.com> Ugis <ugis22@gmail.com> Ulf Hansson <ulf.hansson@linaro.org> Ulf Hansson <ulf.hansson@stericsson.com> Ulisses Furquim <ulisses@profusion.mobi> Ulrich Drepper <drepper@gmail.com> Ulrich Hecht <ulrich.hecht@gmail.com> Ulrich Obergfell <uobergfe@redhat.com> Ulrich Weber <ulrich.weber@sophos.com> Uri Habusha <urih@mellanox.com> Uri Yosef <uri.y@variscite.com> Uros Bizjak <ubizjak@gmail.com> Ursula Braun <ubraun@linux.vnet.ibm.com> Ursula Braun <ursula.braun@de.ibm.com> Uwe K...

...;tyhicks@canonical.com> Ugis <ugis22@gmail.com> Ulf Hansson <ulf.hansson@linaro.org> Ulf Hansson <ulf.hansson@stericsson.com> Ulisses Furquim <ulisses@profusion.mobi> Ulrich Drepper <drepper@gmail.com> Ulrich Hecht <ulrich.hecht@gmail.com> Ulrich Obergfell <uobergfe@redhat.com> Ulrich Weber <ulrich.weber@sophos.com> Uri Habusha <urih@mellanox.com> Uri Yosef <uri.y@variscite.com> Uros Bizjak <ubizjak@gmail.com> Ursula Braun <ubraun@linux.vnet.ibm.com> Ursula Braun <ursula.braun@de.ibm.com> Uwe K...

...;tyhicks@canonical.com> Ugis <ugis22@gmail.com> Ulf Hansson <ulf.hansson@linaro.org> Ulf Hansson <ulf.hansson@stericsson.com> Ulisses Furquim <ulisses@profusion.mobi> Ulrich Drepper <drepper@gmail.com> Ulrich Hecht <ulrich.hecht@gmail.com> Ulrich Obergfell <uobergfe@redhat.com> Ulrich Weber <ulrich.weber@sophos.com> Uri Habusha <urih@mellanox.com> Uri Yosef <uri.y@variscite.com> Uros Bizjak <ubizjak@gmail.com> Ursula Braun <ubraun@linux.vnet.ibm.com> Ursula Braun <ursula.braun@de.ibm.com> Uwe K...

...;tyhicks@canonical.com> Ugis <ugis22@gmail.com> Ulf Hansson <ulf.hansson@linaro.org> Ulf Hansson <ulf.hansson@stericsson.com> Ulisses Furquim <ulisses@profusion.mobi> Ulrich Drepper <drepper@gmail.com> Ulrich Hecht <ulrich.hecht@gmail.com> Ulrich Obergfell <uobergfe@redhat.com> Ulrich Weber <ulrich.weber@sophos.com> Uri Habusha <urih@mellanox.com> Uri Yosef <uri.y@variscite.com> Uros Bizjak <ubizjak@gmail.com> Ursula Braun <ubraun@linux.vnet.ibm.com> Ursula Braun <ursula.braun@de.ibm.com> Uwe K...

...;tyhicks@canonical.com> Ugis <ugis22@gmail.com> Ulf Hansson <ulf.hansson@linaro.org> Ulf Hansson <ulf.hansson@stericsson.com> Ulisses Furquim <ulisses@profusion.mobi> Ulrich Drepper <drepper@gmail.com> Ulrich Hecht <ulrich.hecht@gmail.com> Ulrich Obergfell <uobergfe@redhat.com> Ulrich Weber <ulrich.weber@sophos.com> Uri Habusha <urih@mellanox.com> Uri Yosef <uri.y@variscite.com> Uros Bizjak <ubizjak@gmail.com> Ursula Braun <ubraun@linux.vnet.ibm.com> Ursula Braun <ursula.braun@de.ibm.com> Uwe K...

...;tyhicks@canonical.com> Ugis <ugis22@gmail.com> Ulf Hansson <ulf.hansson@linaro.org> Ulf Hansson <ulf.hansson@stericsson.com> Ulisses Furquim <ulisses@profusion.mobi> Ulrich Drepper <drepper@gmail.com> Ulrich Hecht <ulrich.hecht@gmail.com> Ulrich Obergfell <uobergfe@redhat.com> Ulrich Weber <ulrich.weber@sophos.com> Uri Habusha <urih@mellanox.com> Uri Yosef <uri.y@variscite.com> Uros Bizjak <ubizjak@gmail.com> Ursula Braun <braunu@de.ibm.com> Ursula Braun <ubraun@linux.vnet.ibm.com> Ursula Brau...

...;tyhicks@canonical.com> Ugis <ugis22@gmail.com> Ulf Hansson <ulf.hansson@linaro.org> Ulf Hansson <ulf.hansson@stericsson.com> Ulisses Furquim <ulisses@profusion.mobi> Ulrich Drepper <drepper@gmail.com> Ulrich Hecht <ulrich.hecht@gmail.com> Ulrich Obergfell <uobergfe@redhat.com> Ulrich Weber <ulrich.weber@sophos.com> Uri Habusha <urih@mellanox.com> Uri Yosef <uri.y@variscite.com> Uros Bizjak <ubizjak@gmail.com> Ursula Braun <braunu@de.ibm.com> Ursula Braun <ubraun@linux.vnet.ibm.com> Ursula Brau...