search for: oabi

vhost is currently broken on the some ARM configs. The reason is that that uses apcs-gnu which is the ancient OABI that is been deprecated for a long time. Given that virtio support on such ancient systems is not needed in the first place, let's just add something along the lines of depends on !ARM || AEABI to the virtio Kconfig declaration, and add a comment that it has to do with struct member alignme...

vhost is currently broken on the some ARM configs. The reason is that that uses apcs-gnu which is the ancient OABI that is been deprecated for a long time. Given that virtio support on such ancient systems is not needed in the first place, let's just add something along the lines of depends on !ARM || AEABI to the virtio Kconfig declaration, and add a comment that it has to do with struct member alignme...

On Thu, Apr 16, 2020 at 06:20:20PM -0400, Michael S. Tsirkin wrote: > vhost is currently broken on the some ARM configs. > > The reason is that that uses apcs-gnu which is the ancient OABI that is been > deprecated for a long time. > > Given that virtio support on such ancient systems is not needed in the > first place, let's just add something along the lines of > > depends on !ARM || AEABI > > to the virtio Kconfig declaration, and add a comment that...

...es > it, then alignment assumed by the host's compiler might be > greater than the actual alignment of the pointer. > compiler on the host from assuming pointer is aligned. > > This actually triggers on ARM with -mabi=apcs-gnu - which is a > deprecated configuration. With this OABI, compiler assumes that > all structures are 4 byte aligned - which is stronger than > virtio guarantees for available and used rings, which are > merely 2 bytes. Thus a guest without -mabi=apcs-gnu running > on top of host with -mabi=apcs-gnu will be broken. > > The correct fix is...

...n ARM system . Oh - I forgot it's randconfig. This part is wrong, sorry. I decided to just force 2-byte alignment instead (seems more robust) but I'll take this into account if we do decide to add this dependency. > > > The reason is that that uses apcs-gnu which is the ancient OABI that is been > > deprecated for a long time. > > > > Given that virtio support on such ancient systems is not needed in the > > first place, let's just add something along the lines of > > > > depends on !ARM || AEABI > > > > to the virtio...

On Mon, Apr 6, 2020 at 2:12 PM Michael S. Tsirkin <mst at redhat.com> wrote: > > +config VHOST_DPN > + bool "VHOST dependencies" > + depends on !ARM || AEABI > + default y > + help > + Anything selecting VHOST or VHOST_RING must depend on VHOST_DPN. > + This excludes the deprecated ARM ABI since that forces a 4 byte

On Mon, Apr 6, 2020 at 3:02 PM Michael S. Tsirkin <mst at redhat.com> wrote: > > On Mon, Apr 06, 2020 at 02:50:32PM +0200, Arnd Bergmann wrote: > > On Mon, Apr 6, 2020 at 2:12 PM Michael S. Tsirkin <mst at redhat.com> wrote: > > > > > > > > +config VHOST_DPN > > > + bool "VHOST dependencies" > > > + depends on

vhost is currently broken on the default ARM config. The reason is that that uses apcs-gnu which is the ancient OABI that is been deprecated for a long time. Given that virtio support on such ancient systems is not needed in the first place, let's just add something along the lines of depends on !ARM || AEABI to the virtio Kconfig declaration, and add a comment that it has to do with struct member alignme...

vhost is currently broken on the default ARM config. The reason is that that uses apcs-gnu which is the ancient OABI that is been deprecated for a long time. Given that virtio support on such ancient systems is not needed in the first place, let's just add something along the lines of depends on !ARM || AEABI to the virtio Kconfig declaration, and add a comment that it has to do with struct member alignme...

On Mon, Apr 06, 2020 at 02:50:32PM +0200, Arnd Bergmann wrote: > On Mon, Apr 6, 2020 at 2:12 PM Michael S. Tsirkin <mst at redhat.com> wrote: > > > > > +config VHOST_DPN > > + bool "VHOST dependencies" > > + depends on !ARM || AEABI > > + default y > > + help > > + Anything selecting VHOST or

On Mon, Apr 06, 2020 at 02:50:32PM +0200, Arnd Bergmann wrote: > On Mon, Apr 6, 2020 at 2:12 PM Michael S. Tsirkin <mst at redhat.com> wrote: > > > > > +config VHOST_DPN > > + bool "VHOST dependencies" > > + depends on !ARM || AEABI > > + default y > > + help > > + Anything selecting VHOST or

...host then gets and dereferences it, then alignment assumed by the host's compiler might be greater than the actual alignment of the pointer. compiler on the host from assuming pointer is aligned. This actually triggers on ARM with -mabi=apcs-gnu - which is a deprecated configuration. With this OABI, compiler assumes that all structures are 4 byte aligned - which is stronger than virtio guarantees for available and used rings, which are merely 2 bytes. Thus a guest without -mabi=apcs-gnu running on top of host with -mabi=apcs-gnu will be broken. The correct fix is to force alignment of struct...

...host then gets and dereferences it, then alignment assumed by the host's compiler might be greater than the actual alignment of the pointer. compiler on the host from assuming pointer is aligned. This actually triggers on ARM with -mabi=apcs-gnu - which is a deprecated configuration. With this OABI, compiler assumes that all structures are 4 byte aligned - which is stronger than virtio guarantees for available and used rings, which are merely 2 bytes. Thus a guest without -mabi=apcs-gnu running on top of host with -mabi=apcs-gnu will be broken. The correct fix is to force alignment of struct...

...rbik<gor at linux.ibm.com> >>>> Cc: Christian Borntraeger<borntraeger at de.ibm.com> >>>> Reported-by: Geert Uytterhoeven<geert at linux-m68k.org> >>>> Signed-off-by: Jason Wang<jasowang at redhat.com> >>> I rebased this on top of OABI fix since that >>> seems more orgent to fix. >>> Pushed to my vhost branch pls take a look and >>> if possible test. >>> Thanks! >> >> I test this patch by generating the defconfigs that wants vhost_net or >> vhost_vsock. All looks fine. >&gt...

...rbik<gor at linux.ibm.com> >>>> Cc: Christian Borntraeger<borntraeger at de.ibm.com> >>>> Reported-by: Geert Uytterhoeven<geert at linux-m68k.org> >>>> Signed-off-by: Jason Wang<jasowang at redhat.com> >>> I rebased this on top of OABI fix since that >>> seems more orgent to fix. >>> Pushed to my vhost branch pls take a look and >>> if possible test. >>> Thanks! >> >> I test this patch by generating the defconfigs that wants vhost_net or >> vhost_vsock. All looks fine. >&gt...

On Mon, Jul 4, 2016 at 10:12 AM, Geert Uytterhoeven <geert at linux-m68k.org> wrote: > JFYI, when comparing v4.7-rc6[1] to v4.7-rc5[3], the summaries are: > - build errors: +3/-2 + /home/kisskb/slave/src/drivers/vhost/vhost.c: error: call to '__compiletime_assert_844' declared with attribute error: BUILD_BUG_ON failed: __alignof__ *vq->avail > VRING_AVAIL_ALIGN_SIZE:

On Mon, Jul 4, 2016 at 10:12 AM, Geert Uytterhoeven <geert at linux-m68k.org> wrote: > JFYI, when comparing v4.7-rc6[1] to v4.7-rc5[3], the summaries are: > - build errors: +3/-2 + /home/kisskb/slave/src/drivers/vhost/vhost.c: error: call to '__compiletime_assert_844' declared with attribute error: BUILD_BUG_ON failed: __alignof__ *vq->avail > VRING_AVAIL_ALIGN_SIZE:

...about ‘uclibc’. There is no ‘_IO_getc’ in libc.a of uclibc, but clang&llc compile ‘getc’ in C source to ‘_IO_getc’ in assembler. I tried to use newer version of buildroot which support ‘glibc’ (like 'buildroot-2014.11'), but the newer version doesn’t support to set the ’Target ABI’ to ‘OABI’, someone says OABI rather EABI is necessary if want the executable run on simplescalar. So I don’t know how to solve this issue. ---------------------------------- 2. Then, I change the toolchain from ‘buildroot’ to ’Sourcery CodeBench’: arm-none-linux-gnueabi-gcc, I compile ’susan’ in MiBench as...

...>>>>>> Cc: Christian Borntraeger<borntraeger at de.ibm.com> >>>>>> Reported-by: Geert Uytterhoeven<geert at linux-m68k.org> >>>>>> Signed-off-by: Jason Wang<jasowang at redhat.com> >>>>> I rebased this on top of OABI fix since that >>>>> seems more orgent to fix. >>>>> Pushed to my vhost branch pls take a look and >>>>> if possible test. >>>>> Thanks! >>>> I test this patch by generating the defconfigs that wants vhost_net or >>>&g...

...>>>>>> Cc: Christian Borntraeger<borntraeger at de.ibm.com> >>>>>> Reported-by: Geert Uytterhoeven<geert at linux-m68k.org> >>>>>> Signed-off-by: Jason Wang<jasowang at redhat.com> >>>>> I rebased this on top of OABI fix since that >>>>> seems more orgent to fix. >>>>> Pushed to my vhost branch pls take a look and >>>>> if possible test. >>>>> Thanks! >>>> I test this patch by generating the defconfigs that wants vhost_net or >>>&g...