search for: o2hb_heartbeat_group_drop_item

...atomic instructions usage which seem be racy at fs/ocfs2/cluster/heartbeat.c in Linux 2.6.35. I am reporting this issue while I read the recent code. Since I do not have much background, I am not certain whether it is correct or not. But I hope this report is helpful. Please examine the code. In o2hb_heartbeat_group_drop_item(), there are following codes: 1626 if (atomic_read(&reg->hr_steady_iterations) != 0) { 1627 atomic_set(&reg->hr_steady_iterations, 0); It first checks &reg->hr_steady_iterations and then updates its value. In the case where other threads manipulate th...

...param.type = fs_value_is_string; 182 } 183 184 ret = vfs_parse_fs_param(fc, &param); 185 kfree(param.string); 186 return ret; 187 } There are a couple OCFS functions which call this sleeping function while holding a spinlock. o2hb_heartbeat_group_drop_item() <- disables preempt o2hb_region_inc_user() <- disables preempt -> o2hb_region_pin() -> o2nm_depend_item() -> configfs_depend_item() -> configfs_pin_fs() -> simple_pin_fs() -> vfs_kern_mount() -> vfs_parse_fs...

All, This is hopefully the final drop of the patches for adding global heartbeat to the o2cb stack. The diff from the previous set is here: http://oss.oracle.com/~smushran/global-hb-diff-2010-10-07 Implemented most of the suggestions provided by Joel and Wengang. The most important one was to activate the feature only at the end, Also, got mostly a clean run with checkpatch.pl. Sunil