search for: nvsetown

Just some runtime PM fixes for some much less noticeable runtime PM ref tracking issues that I got reminded of when fixing some unrelated issues with nouveau. Lyude Paul (2): drm/nouveau/dispnv04: Grab/put runtime PM refs on DPMS on/off drm/nouveau/dispnv50: Fix runtime PM ref tracking for non-blocking modesets drivers/gpu/drm/nouveau/dispnv04/crtc.c | 18 +++---------

...rivers/gpu/drm/nouveau/dispnv04/crtc.c @@ -183,6 +183,10 @@ nv_crtc_dpms(struct drm_crtc *crtc, int mode) return; nv_crtc->last_dpms = mode; + if (mode == DRM_MODE_DPMS_ON) + pm_runtime_get_noresume(dev->dev); + else + pm_runtime_put_noidle(dev->dev); if (nv_two_heads(dev)) NVSetOwner(dev, nv_crtc->index); @@ -1045,7 +1049,6 @@ nouveau_crtc_set_config(struct drm_mode_set *set, dev = set->crtc->dev; - /* get a pm reference here */ ret = pm_runtime_get_sync(dev->dev); if (ret < 0 && ret != -EACCES) return ret; @@ -1061,19 +1064,6 @@ nouveau_cr...

...void nouveau_overlay_init(struct drm_device *device); static inline bool nv_two_heads(struct drm_device *dev) diff --git a/drm/nouveau/dispnv04/hw.h b/drm/nouveau/dispnv04/hw.h index 3a2be47f..2afda90a 100644 --- a/drm/nouveau/dispnv04/hw.h +++ b/drm/nouveau/dispnv04/hw.h @@ -43,7 +43,7 @@ void NVSetOwner(struct drm_device *, int owner); void NVBlankScreen(struct drm_device *, int head, bool blank); int nouveau_hw_get_pllvals(struct drm_device *, enum nvbios_pll_type plltype, struct nvkm_pll_vals *pllvals); -int nouveau_hw_pllvals_to_clk(struct nvkm_pll_vals *pllvals); +int nouveau_hw_pll...

The various register access wrappers in nouveau_hw.h are so noisy when drm.debug > 0, that some of them can overflow the kernel message buffer. Add nouveau.ko parameter 'reg_debug', a bitmask that enables each of the wrapper debug messages individually. By default, nothing is printed. Signed-off-by: Pekka Paalanen <pq at iki.fi> --- drivers/gpu/drm/nouveau/nouveau_drv.c | 6

...licitly disables the crtc (well, should, nv_crtc_disable doesn't seem to shut down hw), and I think would leak your runtime PM reference here. At least temporarily. No idea how to best fix that. Aside from "use atomic" :-) Cheers, Daniel > > if (nv_two_heads(dev)) > NVSetOwner(dev, nv_crtc->index); > @@ -1045,7 +1049,6 @@ nouveau_crtc_set_config(struct drm_mode_set *set, > > dev = set->crtc->dev; > > - /* get a pm reference here */ > ret = pm_runtime_get_sync(dev->dev); > if (ret < 0 && ret != -EACCES) > retur...

...i * 4); + } + } +} + void nouveau_hw_save_vga_fonts(struct drm_device *dev, bool save) { - struct drm_nouveau_private *dev_priv = dev->dev_private; uint8_t misc, gr4, gr5, gr6, seq2, seq4; bool graphicsmode; - int i; + unsigned plane; + void __iomem *iovram; if (nv_two_heads(dev)) NVSetOwner(dev, 0); @@ -552,10 +572,19 @@ nouveau_hw_save_vga_fonts(struct drm_device *dev, bool save) graphicsmode = NVReadVgaAttr(dev, 0, NV_CIO_AR_MODE_INDEX) & 1; NVSetEnablePalette(dev, 0, false); - if (graphicsmode) /* graphics mode => framebuffer => no need to save */ + if (graphicsmo...

...au_hw.c | 9 +++++++++ 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_hw.c b/drivers/gpu/drm/nouveau/nouveau_hw.c index 6f55f55..d270d6f 100644 --- a/drivers/gpu/drm/nouveau/nouveau_hw.c +++ b/drivers/gpu/drm/nouveau/nouveau_hw.c @@ -87,8 +87,17 @@ NVSetOwner(struct drm_device *dev, int owner) if (owner == 1) owner *= 3; + if (dev_priv->chipset == 0x11) { + /* This might seem stupid, but the blob does it and + * omitting it often locks the system up. + */ + NVReadVgaCrtc(dev, 0, NV_CIO_SR_LOCK_INDEX); + NVReadVgaCrtc(dev, 1, NV_CIO_SR...

...[<f0e57cc3>] nouveau_run_vbios_init+0x1fb/0x2a9 [nouveau] [<f0e58a6b>] nouveau_bios_init+0xcfa/0x102c [nouveau] [<c101fed6>] ? vmalloc_sync_all+0x116/0x116 [<c125152a>] ? error_code+0x5a/0x60 [<f0e3f630>] ? nouveau_stub_init+0x7/0x7 [nouveau] [<f0e4a501>] ? NVSetOwner+0x150/0x228 [nouveau] [<f0e3f630>] ? nouveau_stub_init+0x7/0x7 [nouveau] [<f0e404ba>] nouveau_card_init+0xe51/0x146c [nouveau] [<f0e4116e>] nouveau_load+0x5c8/0x607 [nouveau] [<f0c31809>] drm_get_pci_dev+0x12e/0x20e [drm] [<f0ec02bd>] nouveau_pci_probe+0xd/0xf [...

...should be straightforward as they seem to be all documented. Another patchset follows with some DDX modifications needed to make use of this. [PATCH 01/12] drm: Fix drm_cvt_mode() for interlaced modes. [PATCH 02/12] drm: Add more standard TV properties. [PATCH 03/12] drm/nouveau: Fix a lock up at NVSetOwner with nv11. [PATCH 04/12] drm/nouveau: Fix fbcon with multiple outputs connected. [PATCH 05/12] drm/nouveau: Use drm_encoder_slave instead of drm_encoder. [PATCH 06/12] drm/nouveau: Prepare the connector code for TV-out. [PATCH 07/12] drm/nouveau: Restructure the nv04 modesetting code. [PATCH 08/1...

Hello, while I debugged an issue in the imx-lcdc driver I was constantly irritated about struct drm_device pointer variables being named "dev" because with that name I usually expect a struct device pointer. I think there is a big benefit when these are all renamed to "drm_dev". I have no strong preference here though, so "drmdev" or "drm" are fine for me,

Hello, while I debugged an issue in the imx-lcdc driver I was constantly irritated about struct drm_device pointer variables being named "dev" because with that name I usually expect a struct device pointer. I think there is a big benefit when these are all renamed to "drm_dev". I have no strong preference here though, so "drmdev" or "drm" are fine for me,