search for: nvputimage

https://bugs.freedesktop.org/show_bug.cgi?id=63263 Priority: medium Bug ID: 63263 Assignee: nouveau at lists.freedesktop.org Summary: X server crash in nouveau_xv.c:NVPutImage (NVCopyNV12ColorPlanes) QA Contact: xorg-team at lists.x.org Severity: normal Classification: Unclassified OS: Linux (All) Reporter: imirkin at alum.mit.edu Hardware: x86-64 (AMD64) Status: NEW Vers...

...if (newTTSize <= destination_buffer->size) { ... // Used in this scope ... 1248: } else { ... // Used in this scope ... 1316: } // Not used in this scope Warning reported by gcc 8.2: nouveau_xv.c: In function ‘NVPutImage’: nouveau_xv.c:1195:7: warning: declaration of ‘i’ shadows a previous local [-Wshadow] int i = 0; ^ nouveau_xv.c:1073:11: note: shadowed declaration is here int ret, i; ^ Signed-off-by: Rhys Kidd <rhyskidd at gmail.com> --- src/nouveau_xv.c | 1 - 1 file changed, 1 de...

Warning reported by gcc 8.2: nouveau_xv.c: In function ‘NVPutImage’: nouveau_xv.c:1369:7: warning: declaration of ‘ret’ shadows a previous local [-Wshadow] int ret = BadImplementation; ^~~ nouveau_xv.c:1073:6: note: shadowed declaration is here int ret, i; ^~~ Fixes: a50bba6 ("xv: misc cleanups") Cc: Ben Skeggs <bskeggs at redhat.co...

...ed height as the driver is capable of + * @param data unused */ static void NVQueryBestSize(ScrnInfoPtr pScrnInfo, Bool motion, @@ -673,6 +852,22 @@ NVQueryBestSize(ScrnInfoPtr pScrnInfo, Bool motion, *p_h = drw_h; } +/** + * NVCopyData420 + * TODO: use DMA instead of CPU copy + * used by NVPutImage() function to copy (image)data from + * system RAM to VRAM and change data order. + * + * @param src1 source buffer (luma ?) + * @param src2 source buffer (chroma1 ?) + * @param src3 source buffer (chroma2 ?) + * @param dst1 destination buffer + * @param srcPitch pitch of src1 + * @param srcPitch2...

...(1): Fix colormap handling at screen depth 30. (v2) Rhys Kidd (27): Check for xf86CursorResetCursor() xv: Silence build warning regarding const qualifier wfb: Fix missing init function decls behind FB_ACCESS_WRAPPER xv: Avoid shadowed declaration of 'int i' in NVPutImage xv: Avoid shadowed declaration of 'int ret' in NVPutImage wfb: Remove declaration for undefined function nouveau_wfb_init() dri2: Mark local create/destroy buffer and copy region functions as static xv: Mark local NVSetupTexturedVideo function as static xv/nv30...

Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu> --- src/nouveau_xv.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/nouveau_xv.c b/src/nouveau_xv.c index 8eafcf0..567e30c 100644 --- a/src/nouveau_xv.c +++ b/src/nouveau_xv.c @@ -552,8 +552,11 @@ NVCopyNV12ColorPlanes(unsigned char *src1, unsigned char *src2, if (e) { unsigned short *vud = (unsigned

...tic-analyzer/nouveau src/nouveau_xv.c | 114 ++++++++++++++++++++++++++---------------------------- 1 files changed, 55 insertions(+), 59 deletions(-) diff --git a/src/nouveau_xv.c b/src/nouveau_xv.c index 4437aa6..eb43207 100644 --- a/src/nouveau_xv.c +++ b/src/nouveau_xv.c @@ -920,7 +920,6 @@ NVPutImage(ScrnInfoPtr pScrn, short src_x, short src_y, short drw_x, { NVPortPrivPtr pPriv = (NVPortPrivPtr)data; NVPtr pNv = NVPTR(pScrn); - PixmapPtr ppix; /* source box */ INT32 xa = 0, xb = 0, ya = 0, yb = 0; /* size to allocate in VRAM and in GART respectively */ @@ -1249,11 +1248,29 @@ CPU_co...

...s are gone when the image is dragged partially off the screen on the left. src/nouveau_xv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/nouveau_xv.c b/src/nouveau_xv.c index f7dc2bc..8eafcf0 100644 --- a/src/nouveau_xv.c +++ b/src/nouveau_xv.c @@ -1095,7 +1095,7 @@ NVPutImage(ScrnInfoPtr pScrn, short src_x, short src_y, short drw_x, NVCopyNV12ColorPlanes(buf + s2offset, buf + s3offset, dst, line_len, srcPitch2, - nlines, line_len); + nlines, npixels); } } else { for (i = 0; i < nlines; i++) { @@ -1161,7...

memcpy() goes from taking 45% to 66% of total function time, which translates to a 30% decrease in NVPutImage runtime. Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu> --- src/nouveau_xv.c | 33 ++++++++++++++++++++++++++------- 1 file changed, 26 insertions(+), 7 deletions(-) diff --git a/src/nouveau_xv.c b/src/nouveau_xv.c index 567e30c..5569b7c 100644 --- a/src/nouveau_xv.c +++ b/src/nouvea...

...ut>, src_pitch=<value optimized out>, dstBox=0x7fffd2c324c0, x1=0, y1=0, x2=62914560, y2=47185920, width=960, height=720, src_w=480, src_h=360, drw_w=960, drw_h=720, clipBoxes=0x7fffd2c325c0, ppix=0x1c412f0, pPriv=0x8213b8) at nv40_xv_tex.c:356 #6 0x00002b79db187d64 in NVPutImage (pScrn=0x7fb940, src_x=0, src_y=0, drw_x=32, drw_y=51, src_w=960, src_h=720, drw_w=960, drw_h=720, id=842094169, buf=0x2b79e6015000 "", width=960, height=720, Sync=0, clipBoxes=0x7fffd2c325c0, data=0x8213b8, pDraw=0x17b9330) at nouveau_xv.c:1465 #7 0x0000000000487d02 i...

http://bugs.freedesktop.org/show_bug.cgi?id=12825 Summary: TvTime shows only the upper left corner (~ 1280x1024) in Randr1.2 Product: xorg Version: unspecified Platform: x86 (IA32) OS/Version: Linux (All) Status: NEW Severity: normal Priority: medium Component: Driver/nouveau