search for: nvkm_therm_compute_linear_duty

...base.c b/drm/nouveau/nvkm/subdev/therm/base.c index 8894fee..df949fa 100644 --- a/drm/nouveau/nvkm/subdev/therm/base.c +++ b/drm/nouveau/nvkm/subdev/therm/base.c @@ -64,10 +64,9 @@ nvkm_therm_update_trip(struct nvkm_therm *therm) } static int -nvkm_therm_update_linear(struct nvkm_therm *therm) +nvkm_therm_compute_linear_duty(struct nvkm_therm *therm, u8 linear_min_temp, + u8 linear_max_temp) { - u8 linear_min_temp = therm->fan->bios.linear_min_temp; - u8 linear_max_temp = therm->fan->bios.linear_max_temp; u8 temp = therm->func->temp_get(therm); u16 duty; @@ -85,...

...t; index 8894fee..df949fa 100644 > --- a/drm/nouveau/nvkm/subdev/therm/base.c > +++ b/drm/nouveau/nvkm/subdev/therm/base.c > @@ -64,10 +64,9 @@ nvkm_therm_update_trip(struct nvkm_therm *therm) > } > > static int > -nvkm_therm_update_linear(struct nvkm_therm *therm) > +nvkm_therm_compute_linear_duty(struct nvkm_therm *therm, u8 linear_min_temp, > + u8 linear_max_temp) > { > - u8 linear_min_temp = therm->fan->bios.linear_min_temp; > - u8 linear_max_temp = therm->fan->bios.linear_max_temp; > u8 temp = therm->func->temp_get(th...

Adds Nouveau controlled thermal throttling for Kepler+ GPUs. With this I feel safe enough to add support for Maxwell2 reclocking later on (still hidden behind a switch, but we can be fairly sure to not overheat hardware if a user isn't carefull enough) Contains all patches from my clk update series, but I thought it makes sense to include those in this series as well for completness. Please

...unc->temp_get(therm); + int temp; u16 duty, i; + WARN_ON(nvkm_therm_temp_get(therm, &temp) < 0); + /* look for the trip point corresponding to the current temperature */ cur_trip = NULL; for (i = 0; i < therm->fan->bios.nr_fan_trip; i++) { @@ -70,9 +77,11 @@ static int nvkm_therm_compute_linear_duty(struct nvkm_therm *therm, u8 linear_min_temp, u8 linear_max_temp) { - u8 temp = therm->func->temp_get(therm); + int temp; u16 duty; + WARN_ON(nvkm_therm_temp_get(therm, &temp) < 0); + /* handle the non-linear part first */ if (temp < linear_...

...use I never send out the patch to use them. > > /* look for the trip point corresponding to the current temperature */ > > cur_trip = NULL; > > for (i = 0; i < therm->fan->bios.nr_fan_trip; i++) { > > @@ -70,9 +77,11 @@ static int > > nvkm_therm_compute_linear_duty(struct nvkm_therm *therm, u8 linear_min_temp, > > u8 linear_max_temp) > > { > > - u8 temp = therm->func->temp_get(therm); > > + int temp; > > u16 duty; > > > > + WARN_ON(nvkm_therm_temp_get(t...

...;func->temp_get(therm, &temp); > + if (ret < 0) > + return ret; > + > /* look for the trip point corresponding to the current temperature */ > cur_trip = NULL; > for (i = 0; i < therm->fan->bios.nr_fan_trip; i++) { > @@ -67,9 +71,13 @@ static int > nvkm_therm_compute_linear_duty(struct nvkm_therm *therm, u8 linear_min_temp, > u8 linear_max_temp) > { > - u8 temp = therm->func->temp_get(therm); > + int temp, ret; > u16 duty; > > + ret = therm->func->temp_get(therm, &temp); > + if (ret < 0) >...

Last update here: https://lists.freedesktop.org/archives/nouveau/2017-September/028848.html Basically big cleanup, reordering, simplifications and some renaming to make the code easier to read and to review. I also moved some bugfixes to the front so they can be merged prior the other patches. There was also a bug related to the therm daemon triggering a pstate change leading to PMU lockups,

...;func->temp_get(therm, &temp); > + if (ret < 0) > + return ret; > + > /* look for the trip point corresponding to the current temperature */ > cur_trip = NULL; > for (i = 0; i < therm->fan->bios.nr_fan_trip; i++) { > @@ -67,9 +71,13 @@ static int > nvkm_therm_compute_linear_duty(struct nvkm_therm *therm, u8 linear_min_temp, > u8 linear_max_temp) > { > - u8 temp = therm->func->temp_get(therm); > + int temp, ret; > u16 duty; > > + ret = therm->func->temp_get(therm, &temp); > + if (ret < 0) >...

...erm); u16 duty, i; + ret = therm->func->temp_get(therm, &temp); + if (ret < 0) + return ret; + /* look for the trip point corresponding to the current temperature */ cur_trip = NULL; for (i = 0; i < therm->fan->bios.nr_fan_trip; i++) { @@ -67,9 +71,13 @@ static int nvkm_therm_compute_linear_duty(struct nvkm_therm *therm, u8 linear_min_temp, u8 linear_max_temp) { - u8 temp = therm->func->temp_get(therm); + int temp, ret; u16 duty; + ret = therm->func->temp_get(therm, &temp); + if (ret < 0) + return ret; + /* handle the non-linear p...

...return ret; >>> + >>> /* look for the trip point corresponding to the current temperature */ >>> cur_trip = NULL; >>> for (i = 0; i < therm->fan->bios.nr_fan_trip; i++) { >>> @@ -67,9 +71,13 @@ static int >>> nvkm_therm_compute_linear_duty(struct nvkm_therm *therm, u8 linear_min_temp, >>> u8 linear_max_temp) >>> { >>> - u8 temp = therm->func->temp_get(therm); >>> + int temp, ret; >>> u16 duty; >>> >>> + ret = therm...

...But in theory that could be causing random errors getting reported. > /* look for the trip point corresponding to the current temperature */ > cur_trip = NULL; > for (i = 0; i < therm->fan->bios.nr_fan_trip; i++) { > @@ -70,9 +77,11 @@ static int > nvkm_therm_compute_linear_duty(struct nvkm_therm *therm, u8 linear_min_temp, > u8 linear_max_temp) > { > - u8 temp = therm->func->temp_get(therm); > + int temp; > u16 duty; > > + WARN_ON(nvkm_therm_temp_get(therm, &temp) < 0); > + &g...

Just wanted to post updated versions of my last series/patches. Reviews welcomed. It would be also nice if we agree on features I should focus upstreaming, so that this work can be better splitted or reordered. Sadly most of my patches depend on the rather big clk subdev rework and I think those patches shows best, why I think this rework is actually needed and makes things much easier to add

...erm); u16 duty, i; + ret = therm->func->temp_get(therm, &temp); + if (ret < 0) + return ret; + /* look for the trip point corresponding to the current temperature */ cur_trip = NULL; for (i = 0; i < therm->fan->bios.nr_fan_trip; i++) { @@ -67,9 +71,13 @@ static int nvkm_therm_compute_linear_duty(struct nvkm_therm *therm, u8 linear_min_temp, u8 linear_max_temp) { - u8 temp = therm->func->temp_get(therm); + int temp, ret; u16 duty; + ret = therm->func->temp_get(therm, &temp); + if (ret < 0) + return ret; + /* handle the non-linear p...

...rn the error here. > > > /* look for the trip point corresponding to the current temperature */ > > > cur_trip = NULL; > > > for (i = 0; i < therm->fan->bios.nr_fan_trip; i++) { > > > @@ -70,9 +77,11 @@ static int > > > nvkm_therm_compute_linear_duty(struct nvkm_therm *therm, u8 linear_min_temp, > > > u8 linear_max_temp) > > > { > > > - u8 temp = therm->func->temp_get(therm); > > > + int temp; > > > u16 duty; > > > > > > +...

...t < 0) >> + return ret; >> + >> /* look for the trip point corresponding to the current temperature */ >> cur_trip = NULL; >> for (i = 0; i < therm->fan->bios.nr_fan_trip; i++) { >> @@ -67,9 +71,13 @@ static int >> nvkm_therm_compute_linear_duty(struct nvkm_therm *therm, u8 linear_min_temp, >> u8 linear_max_temp) >> { >> - u8 temp = therm->func->temp_get(therm); >> + int temp, ret; >> u16 duty; >> >> + ret = therm->func->temp_get(therm...

We should simply return errors while the GPU is turned off, because the sensors aren't accessable and setting any kind of value doesn't make any sense. Fixes sensors values reported by "sensors" Before: nouveau-pci-0100 Adapter: PCI adapter GPU core: +0.60 V (min = +0.60 V, max = +1.20 V) temp1: -0.0°C (high = +95.0°C, hyst = +3.0°C) (crit

Commit d32656373857 ("drm/nouveau/therm/gp100: initial implementation of new gp1xx temperature sensor") added support for reading finer-grain temperatures, but continued to report temperatures in 1 degree Celsius increments via nvkm_therm_temp_get(). Rather than altering nvkm_therm_temp_get() to report finer-grain temperatures, which would be inconvenient for other users of the