search for: nvkm_msgqueue_recv

...c @@ -59,6 +59,13 @@ static void nvkm_sec2_recv(struct work_struct *work) { struct nvkm_sec2 *sec2 = container_of(work, typeof(*sec2), work); + + if (!sec2->queue) { + nvkm_warn(&sec2->engine.subdev, + "recv function called while no firmware set!\n"); + return; + } + nvkm_msgqueue_recv(sec2->queue); } diff --git a/drm/nouveau/nvkm/falcon/msgqueue.c b/drm/nouveau/nvkm/falcon/msgqueue.c index 18111d66d3d4..07e752603bae 100644 --- a/drm/nouveau/nvkm/falcon/msgqueue.c +++ b/drm/nouveau/nvkm/falcon/msgqueue.c @@ -511,11 +511,10 @@ nvkm_msgqueue_del(struct nvkm_msgqueue **queue)...

Hello Alexandre Courbot, This is a semi-automatic email about new static checker warnings. The patch 9b536e9d5251: "drm/nouveau/falcon: add msgqueue interface" from Jan 19, 2017, leads to the following Smatch complaint: drivers/gpu/drm/nouveau/nvkm/falcon/msgqueue.c:514 nvkm_msgqueue_recv() error: we previously assumed 'queue' could be null (see line 513) drivers/gpu/drm/nouveau/nvkm/falcon/msgqueue.c 512 { 513 if (!queue || !queue->func || !queue->func->recv) { ^^^^^^ Check. 514 const struct nvkm_subdev *subdev = queue->falcon...

GP10B is the chip used in Tegra X2 SoCs. This patchset adds support for its base engines after reworking secboot a bit to accomodate its calling convention better. This patchset has been tested rendering simple off-screen buffers using Mesa and yielded the expected result. Alexandre Courbot (15): secboot: allow to boot multiple falcons secboot: pass instance to LS firmware loaders secboot: