search for: nvkm_memory_new

Two trivial PMU-related fixes for Tegra: - Add a dummy func member to GK20A, since nvkm_pmmu_pgob() unconditionally dereferences it - Check whether a PMU actually exists before calling nvkm_pmmu_pgob(). During early bringup we are likely to not have a PMU Alexandre Courbot (2): pmu/gk20a: add dummy func gr/gf100: do not assume a PMU is present drm/nouveau/nvkm/engine/gr/gf100.c | 3 ++-

...re+0x123/0x1c0 [nouveau] [ 9.917565] ? nvbios_rd08+0x1b/0x70 [nouveau] [ 9.922239] nvkm_instobj_new+0x1e3/0x520 [nouveau] [ 9.927353] ? nvbios_rd08+0x1b/0x70 [nouveau] [ 9.932017] ? nvbios_pll_parse+0x8d7/0xcf0 [nouveau] [ 9.937218] ? kmem_cache_alloc+0x1f0/0x2d0 [ 9.941624] nvkm_memory_new+0x4b/0xc0 [nouveau] [ 9.946461] ? nvkm_longopt+0x17/0x60 [nouveau] [ 9.951208] gf100_fb_oneinit+0x7b/0x1c0 [nouveau] [ 9.956218] nvkm_fb_oneinit+0x89/0x2e0 [nouveau] [ 9.961144] nvkm_subdev_init+0x92/0x600 [nouveau] [ 9.966085] ? ktime_get+0x64/0x110 [ 9.969815] nvkm_device_...

...252778.062050] [<ffffffffa089189b>] nv50_instobj_acquire+0x4b/0x70 [nouveau] [252778.062564] [<ffffffffa0890887>] nvkm_instobj_acquire_slow+0x17/0x30 [nouveau] [252778.063080] [<ffffffffa0890c2f>] nvkm_instobj_new+0x6f/0x180 [nouveau] [252778.063587] [<ffffffffa08475c4>] nvkm_memory_new+0x44/0x80 [nouveau] [252778.064108] [<ffffffffa0895b3f>] nvkm_vm_get+0x15f/0x250 [nouveau] [252778.064611] [<ffffffffa08f5a52>] nouveau_bo_vma_add+0x32/0xa0 [nouveau] [252778.065124] [<ffffffffa08f3c2a>] ? nouveau_bo_map+0x7a/0xa0 [nouveau] [252778.065627] [<ffffffffa0906f5...

...u] [ 398.040933] [<ffffffffa017d966>] nv50_instobj_acquire+0x46/0x70 [nouveau] [ 398.040960] [<ffffffffa017cae2>] nvkm_instobj_acquire_slow+0x12/0x30 [nouveau] [ 398.040984] [<ffffffffa017ce26>] nvkm_instobj_new+0x56/0x150 [nouveau] [ 398.041003] [<ffffffffa0140100>] nvkm_memory_new+0x30/0x50 [nouveau] [ 398.041010] [<ffffffffa013ef99>] nvkm_gpuobj_new+0x119/0x200 [nouveau] [ 398.041010] [<ffffffffa01b4657>] nv50_gr_chan_bind+0x27/0x60 [nouveau] [ 398.041010] [<ffffffffa0140ee2>] nvkm_object_bind+0x12/0x20 [nouveau] [ 398.041010] [<ffffffffa01a8804...

...changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nvkm/core/memory.c b/drivers/gpu/drm/nouveau/nvkm/core/memory.c index 4cc186262d34..38130ef272d6 100644 --- a/drivers/gpu/drm/nouveau/nvkm/core/memory.c +++ b/drivers/gpu/drm/nouveau/nvkm/core/memory.c @@ -140,7 +140,7 @@ nvkm_memory_new(struct nvkm_device *device, enum nvkm_memory_target target, { struct nvkm_instmem *imem = device->imem; struct nvkm_memory *memory; - int ret = -ENOSYS; + int ret; if (unlikely(target != NVKM_MEM_TARGET_INST || !imem)) return -ENOSYS; -- 2.25.0

...int ret, i, j; > > - nvkm_pmu_pgob(device->pmu, false); > + if (device->pmu) > + nvkm_pmu_pgob(device->pmu, false); I'd probably just change the condition in nvkm_pmu_pgob() to (pmu && pmu->func->pgob) ? > > ret = nvkm_memory_new(device, NVKM_MEM_TARGET_INST, 0x1000, 256, false, > &gr->unk4188b4); > -- > 2.5.1 > > _______________________________________________ > Nouveau mailing list > Nouveau at lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinf...

...8.209122] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 8.209124] CR2: 00007f19eccdcb18 CR3: 00000001a5818000 CR4: 00000000000006e0 [ 8.209126] Call Trace: [ 8.209182] nv50_instobj_acquire+0xb1/0xf0 [nouveau] [ 8.209216] nvkm_instobj_new+0xe2/0x160 [nouveau] [ 8.209245] nvkm_memory_new+0x31/0x50 [nouveau] [ 8.209278] nvkm_mmu_ptc_get.part.4+0x1ae/0x230 [nouveau] [ 8.209311] nvkm_vmm_iter.constprop.13+0x458/0x790 [nouveau] [ 8.209344] ? nvkm_vmm_map_choose+0xb0/0xb0 [nouveau] [ 8.209348] ? kvmalloc_node+0x3e/0x70 [ 8.209381] ? nvkm_vmm_ctor+0x1ce/0x250 [nouveau...

...t;ffffffffa0175482>] nv50_instobj_boot+0xc2/0x120 [nouveau] [<ffffffffa017539b>] nv50_instobj_acquire+0x4b/0x70 [nouveau] [<ffffffffa01743c7>] nvkm_instobj_acquire_slow+0x17/0x30 [nouveau] [<ffffffffa017473a>] nvkm_instobj_new+0x6a/0x170 [nouveau] [<ffffffffa01363f4>] nvkm_memory_new+0x44/0x80 [nouveau] [<ffffffffa0178e7f>] nvkm_vm_get+0x15f/0x250 [nouveau] [<ffffffffa01d1b00>] nouveau_bo_vma_add+0x30/0x90 [nouveau] [<ffffffffa01e34a9>] nouveau_channel_prep+0x1d9/0x2a0 [nouveau] [<ffffffffa01e35c7>] nouveau_channel_new+0x57/0x6e0 [nouveau] [<ffff...

This v4 is now a 3 piece series (since v4), after Alexandre pointed out that both GF 100 and NV50 are affected by the same issue, and that a related issue has been solved already for Tegra in commit 9d0394c6bed5 ("drm/nouveau/instmem/gk20a: set DMA mask early"). The issue that this series addresses is the fact that the Nouveau driver invokes the DMA API before setting the DMA mask. In

...rent object, removing PTP from cache * if there's no more free slots left. @@ -203,6 +205,8 @@ nvkm_mmu_ptc_get(struct nvkm_mmu *mmu, u32 size, u32 align, bool zero) return NULL; pt->ptc = ptc; pt->sub = false; + pt->ptei_shift = 3; + pt->page_shift = PAGE_SHIFT; ret = nvkm_memory_new(mmu->subdev.device, NVKM_MEM_TARGET_INST, size, align, zero, &pt->memory); diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/mmu/priv.h b/drivers/gpu/drm/nouveau/nvkm/subdev/mmu/priv.h index 479b02344271..f2162bb35bea 100644 --- a/drivers/gpu/drm/nouveau/nvkm/subdev/mmu/priv.h ++...

..._instobj_boot+0x89/0x100 [nouveau] čen 23 22:11:07 blackgate kernel: nv50_instobj_acquire+0x4b/0x70 [nouveau] čen 23 22:11:07 blackgate kernel: nvkm_instobj_acquire_slow+0x17/0x30 [nouveau] čen 23 22:11:07 blackgate kernel: nvkm_instobj_new+0x6e/0x180 [nouveau] čen 23 22:11:07 blackgate kernel: nvkm_memory_new+0x44/0x80 [nouveau] čen 23 22:11:07 blackgate kernel: nvkm_vm_get+0x14a/0x240 [nouveau] čen 23 22:11:07 blackgate kernel: nvkm_gpuobj_map+0x33/0x60 [nouveau] čen 23 22:11:07 blackgate kernel: gm200_secboot_run_blob+0x8d/0x180 [nouveau] čen 23 22:11:07 blackgate kernel: ? flush_work+0x3f/0x1b0 č...

hmm_range_fault() returns an array of page frame numbers and flags for how the pages are mapped in the requested process' page tables. The PFN can be used to get the struct page with hmm_pfn_to_page() and the page size order can be determined with compound_order(page) but if the page is larger than order 0 (PAGE_SIZE), there is no indication that the page is mapped using a larger page size. To

From: Jérôme Glisse <jglisse at redhat.com> (mm is cced just to allow exposure of device driver work without ccing a long list of peoples. I do not think there is anything usefull to discuss from mm point of view but i might be wrong, so just for the curious :)). git://people.freedesktop.org/~glisse/linux branch: nouveau-hmm-v00

These patches apply to linux-5.8.0-rc1. Patches 1-3 should probably go into 5.8, the others can be queued for 5.9. Patches 4-6 improve the HMM self tests. Patch 7-8 prepare nouveau for the meat of this series which adds support and testing for compound page mapping of system memory (patches 9-11) and compound page migration to device private memory (patches 12-16). Since these changes are split