Displaying 6 results from an estimated 6 matches for "nvkm_iccsense_create_sensor".
2016 Jun 02
2
[PATCH] drm/nouveau/iccsense: fix memory leak on default sensor->type case
From: Colin Ian King <colin.king at canonical.com>
The default sensor->type case leaks memory allocated to rail. Fix
this by free'ing rail before we continue with the next loop iteration.
Signed-off-by: Colin Ian King <colin.king at canonical.com>
---
drivers/gpu/drm/nouveau/nvkm/subdev/iccsense/base.c | 1 +
1 file changed, 1 insertion(+)
diff --git
2016 Mar 25
0
[PATCH 3/4] iccsense: split sensor into own struct
...each_entry_safe(rail, tmp, &iccsense->rails, head)
+ list_for_each_entry_safe(sensor, tmps, &iccsense->sensors, head)
+ kfree(sensor);
+ list_for_each_entry_safe(rail, tmpr, &iccsense->rails, head)
kfree(rail);
return iccsense;
}
+static struct nvkm_iccsense_sensor*
+nvkm_iccsense_create_sensor(struct nvkm_iccsense *iccsense, u8 id)
+{
+
+ struct nvkm_subdev *subdev = &iccsense->subdev;
+ struct nvkm_bios *bios = subdev->device->bios;
+ struct nvkm_i2c *i2c = subdev->device->i2c;
+ struct nvbios_extdev_func extdev;
+ struct nvkm_i2c_bus *i2c_bus;
+ struct nvkm_iccsense_...
2016 Jul 27
0
[PATCH] nvkm/iccsense: Parse the resistors and config the right way
...ubdev;
+ nvkm_trace(subdev, "write config of extdev %i: 0x%04x\n", sensor->id, sensor->config);
+ nv_wr16i2cr(sensor->i2c, sensor->addr, 0x00, sensor->config);
}
int
@@ -196,7 +148,6 @@ nvkm_iccsense_dtor(struct nvkm_subdev *subdev)
static struct nvkm_iccsense_sensor*
nvkm_iccsense_create_sensor(struct nvkm_iccsense *iccsense, u8 id)
{
-
struct nvkm_subdev *subdev = &iccsense->subdev;
struct nvkm_bios *bios = subdev->device->bios;
struct nvkm_i2c *i2c = subdev->device->i2c;
@@ -245,7 +196,7 @@ nvkm_iccsense_create_sensor(struct nvkm_iccsense *iccsense, u8 id)
se...
2016 Mar 25
7
[PATCH 0/4] Configure Power Sensors
The power sensors can be configured to sample the readout values over time.
Nvidia does this too, so nouveau should probably do that too.
Karol Herbst (4):
iccsense: remove read function
iccsense: convert to linked list
iccsense: split sensor into own struct
iccsense: configure sensors like nvidia does
drm/nouveau/include/nvkm/subdev/iccsense.h | 6 +-
drm/nouveau/nouveau_hwmon.c
2016 Jun 03
0
[PATCH] drm/nouveau/iccsense: fix memory leak on default sensor->type case
Hi Colin,
thanks for pointing this out, but I am quite sure this continue
statement won't ever be hit, ever.
check the nvkm_iccsense_create_sensor function. A sensor object will
only be created for one of those three types and others don't exist.
I've just added that default statement to shut GCC I think.
The thing is I reworked that code already and will check if this
situation still applies there.
2016-06-02 12:28 GMT+02:00 Colin...
2016 Mar 28
4
[PATCH v2 0/4] Configure Power Sensors
The power sensors can be configured to sample the readout values over time.
Nvidia does this too, so nouveau should probably do that too.
v2: use list_del and rework an error message
Karol Herbst (4):
iccsense: remove read function
iccsense: convert to linked list
iccsense: split sensor into own struct
iccsense: configure sensors like nvidia does