search for: nvkm_get_temp

The current hwmon code doesn't check if the returned value was actually an error. Since Kepler temperature sensors are able to report negative values. Since Pascal (and maybe earlier) we have sensors with improved precision. Adjust the nvkm_get_temp method to be able to deal with those changes and let hwmon return an error properly. Signed-off-by: Karol Herbst <karolherbst at gmail.com> --- drm/nouveau/include/nvkm/subdev/therm.h | 2 +- drm/nouveau/nouveau_hwmon.c | 15 +++++++++------ drm/nouveau/nvkm/subdev/therm/base.c...

...le to report negative values. Those negative values are not for error reporting, but rather when you buried your GPU in snow somewhere in Antarctica and still want a valid temperature to be reported (unverified). Since Pascal (and maybe earlier) we have sensors with improved precision. Adjust the nvkm_get_temp method to be able to deal with those changes and let hwmon return an error properly. Signed-off-by: Karol Herbst <karolherbst at gmail.com> --- drm/nouveau/include/nvkm/subdev/clk.h | 4 ++-- drm/nouveau/include/nvkm/subdev/therm.h | 2 +- drm/nouveau/nouveau_hwmon.c | 15 ++...

...are not for error reporting, but rather when you buried >> your GPU in snow somewhere in Antarctica and still want a valid >> temperature to be reported (unverified). >> >> Since Pascal (and maybe earlier) we have sensors with improved precision. >> >> Adjust the nvkm_get_temp method to be able to deal with those changes >> and let hwmon return an error properly. > > Where did you get this information? And if it is the case, then we will > royally screw up the value because we don't even know on how many bits > 0x20400 uses... > > If you are i...

...gative values. I assume those negative values are not for error reporting, but more if you buried your GPU in the snow somewhere in the Antarctic and still want a valid temperature to be reported. > Since Pascal (and maybe earlier) we have sensors with improved precision. > > Adjust the nvkm_get_temp method to be able to deal with those changes > and let hwmon return an error properly. > > Signed-off-by: Karol Herbst <karolherbst at gmail.com> > --- > drm/nouveau/include/nvkm/subdev/therm.h | 2 +- > drm/nouveau/nouveau_hwmon.c | 15 +++++++++------ > d...

...ing, but rather when you buried >>> your GPU in snow somewhere in Antarctica and still want a valid >>> temperature to be reported (unverified). >>> >>> Since Pascal (and maybe earlier) we have sensors with improved precision. >>> >>> Adjust the nvkm_get_temp method to be able to deal with those changes >>> and let hwmon return an error properly. >> >> Where did you get this information? And if it is the case, then we will >> royally screw up the value because we don't even know on how many bits >> 0x20400 uses... &g...

...> negative values are not for error reporting, but rather when you buried > your GPU in snow somewhere in Antarctica and still want a valid > temperature to be reported (unverified). > > Since Pascal (and maybe earlier) we have sensors with improved precision. > > Adjust the nvkm_get_temp method to be able to deal with those changes > and let hwmon return an error properly. Where did you get this information? And if it is the case, then we will royally screw up the value because we don't even know on how many bits 0x20400 uses... If you are indeed right, I would like to see...

...: N/A (min = +0.60 V, max = +1.20 V) temp1: N/A (high = +95.0°C, hyst = +3.0°C) (crit = +105.0°C, hyst = +5.0°C) (emerg = +135.0°C, hyst = +5.0°C) power1: N/A Karol Herbst (3): therm: split return code and value in nvkm_get_temp hwmon: properly check for errors subdev/volt/gk104: return error when read fails drm/nouveau/include/nvkm/subdev/therm.h | 2 +- drm/nouveau/nouveau_hwmon.c | 48 ++++++++++++++++++++++++--------- drm/nouveau/nvkm/subdev/therm/base.c | 19 +++++++++---- drm/nouveau/nvkm/subdev...

...ecause the timer wasn't disabled on fini. I think we are getting close with this and hope we can merge this soon. Karol Herbst (32): bios/vpstate: There are some fermi vbios with no boost or tdp entry debugfs: Wake up GPU before doing any reclocking therm: Split return code and value in nvkm_get_temp hwmon: Properly check for errors clk: Improve names of pstate/cstate related variables and fields clk: Add NVKM_CLK_PSTATE_BOOT clk: Rename NVKM_CLK_CSTATE_HIGHEST to NVKM_CLK_CSTATE_AUTO clk: Rename nvkm_clk.states to pstates clk: Rename nvkm_pstate.list to cstates clk: Remove dstate...

...arts need to be updated 19-20: Hacky Workaround for enabling Maxwell2 reclocking (hidden behind module parameter) 21-23: debugfs file to change boost mode 24-29: Parse battery vpstate to throttle clocks when system is running on battery Karol Herbst (29): therm: split return code and value in nvkm_get_temp hwmon: properly check for errors subdev/volt/gk104: return error when read fails clk: Rename nvkm_pstate_calc to nvkm_clk_update and export it clk: Remove dstate clk: Make pstate a pointer to nvkm_pstate clk: Hold information about the current cstate status clk: We should pass the pst...