search for: nvkm_device_init

nvkm_device_fini is never called if a failure occurs in nvkm_device_init, even when unloading the module. This can lead to a resources leak (one example is the Tegra interrupt which would never be freed in that case). Fix this by calling nvkm_device_fini in nvkm_device_init's failure path. Signed-off-by: Alexandre Courbot <acourbot at nvidia.com> --- drm/nou...

Should these get back-ported to any released kernels? On Mon, Jan 25, 2016 at 4:44 AM, Alexandre Courbot <acourbot at nvidia.com> wrote: > nvkm_device_fini is never called if a failure occurs in > nvkm_device_init, even when unloading the module. This can lead to a > resources leak (one example is the Tegra interrupt which would never be > freed in that case). Fix this by calling nvkm_device_fini in > nvkm_device_init's failure path. > > Signed-off-by: Alexandre Courbot <acourbot at nvi...

...t. Looking at the code, only NV40+ do have a therm engine. Therefore, shouldn’t nvkm_therm_clkgate_enable(), nvkm_therm_clkgate_fini() and nvkm_therm_clkgate_oneinit() all check for therm being not NULL, on top of their check for the clkgate_* hooks being there? Or instead, maybe have the check in nvkm_device_init() nvkm_device_init()? Pierre -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 833 bytes Desc: not available URL: <https://lists.freedesktop.org/archives/nouveau/attachments/20180214/f849de72/attachment.sig&gt...

...ode, only NV40+ do have a therm engine. Therefore, shouldn’t > nvkm_therm_clkgate_enable(), nvkm_therm_clkgate_fini() and > nvkm_therm_clkgate_oneinit() all check for therm being not NULL, on top of > their check for the clkgate_* hooks being there? Or instead, maybe have the > check in nvkm_device_init() nvkm_device_init()? > > Pierre -- Cheers, Lyude Paul

...0x84 [ 2.154083] nvkm_firmware_mem_map+0x84/0xc4 [ 2.154094] nvkm_falcon_fw_oneinit+0xc8/0x320 [ 2.154101] nvkm_acr_oneinit+0x428/0x5b0 [ 2.154109] nvkm_subdev_oneinit_+0x50/0x104 [ 2.154114] nvkm_subdev_init_+0x3c/0x12c [ 2.154119] nvkm_subdev_init+0x60/0xa0 [ 2.154125] nvkm_device_init+0x14c/0x2a0 [ 2.154133] nvkm_udevice_init+0x60/0x9c [ 2.154140] nvkm_object_init+0x48/0x1b0 [ 2.154144] nvkm_ioctl_new+0x168/0x254 [ 2.154149] nvkm_ioctl+0xd0/0x220 [ 2.154153] nvkm_client_ioctl+0x10/0x1c [ 2.154162] nvif_object_ctor+0xf4/0x22c [ 2.154168] nvif_device_ct...

On Wed, Feb 14, 2018 at 9:29 AM, Meelis Roos <mroos at linux.ee> wrote: >> This is 4.16-rc1+todays git on a lowly P4 with NV5, worked fine in 4.15: > > NV5 in another PC (secondary card in x86-64) made the systrem crash on > boot, in nvkm_therm_clkgate_fini. Mind booting with nouveau.debug=trace? That should hopefully tell us more exactly which thing is dying. If you have a

...00080050033 [ 56.593200] CR2: 00007efcd12de370 CR3: 000000044c8bb000 CR4: 00000000003406e0 [ 56.593200] Call Trace: [ 56.593252] ? nvkm_pmu_reset+0x94/0x160 [nouveau] [ 56.593268] nvkm_pmu_preinit+0x12/0x20 [nouveau] [ 56.593276] nvkm_subdev_preinit+0x34/0x120 [nouveau] [ 56.593291] nvkm_device_init+0x60/0x270 [nouveau] [ 56.593305] nvkm_udevice_init+0x48/0x60 [nouveau] [ 56.593313] nvkm_object_init+0x40/0x190 [nouveau] [ 56.593320] nvkm_object_init+0x80/0x190 [nouveau] [ 56.593328] nvkm_client_init+0xe/0x10 [nouveau] [ 56.593343] nvkm_client_resume+0xe/0x10 [nouveau] [ 56.593...

...au] [<000000004ecaa918>] gt215_ram_init+0xc5/0x2f0 [nouveau] [<00000000007ba1a0>] nvkm_ram_init+0x1a/0x20 [nouveau] [<0000000050abf84b>] nvkm_fb_init+0x27/0xe0 [nouveau] [<00000000fae7fedc>] nvkm_subdev_init+0xbc/0x210 [nouveau] [<00000000a67b86e4>] nvkm_device_init+0x12a/0x280 [nouveau] [<00000000c02ac03e>] nvkm_udevice_init+0x48/0x60 [nouveau] [<0000000048f35641>] nvkm_object_init+0x43/0x110 [nouveau] [<00000000c6f92dc0>] nvkm_object_init+0x74/0x110 [nouveau] [<00000000c6f92dc0>] nvkm_object_init+0x74/0x110 [nouveau]...

...m_memory_new+0x4b/0xc0 [nouveau] [ 9.946461] ? nvkm_longopt+0x17/0x60 [nouveau] [ 9.951208] gf100_fb_oneinit+0x7b/0x1c0 [nouveau] [ 9.956218] nvkm_fb_oneinit+0x89/0x2e0 [nouveau] [ 9.961144] nvkm_subdev_init+0x92/0x600 [nouveau] [ 9.966085] ? ktime_get+0x64/0x110 [ 9.969815] nvkm_device_init+0x169/0x2a0 [nouveau] [ 9.974922] nvkm_udevice_init+0x7e/0xf0 [nouveau] [ 9.979924] nvkm_object_init+0x6a/0x2e0 [nouveau] [ 9.984932] nvkm_ioctl_new+0x198/0x430 [nouveau] [ 9.989846] ? nvif_vmm_init+0x340/0x340 [nouveau] [ 9.994864] ? nvkm_udevice_rd08+0x90/0x90 [nouveau] [ 10...

...ch+0x24/0x26 [ 7.399368] nvkm_therm_clkgate_fini+0x14d/0x174 [nouveau] [ 7.399638] ? nvkm_device_subdev+0x1b9/0x1fa [nouveau] [ 7.399907] nvkm_device_fini+0x113/0x3e9 [nouveau] [ 7.400010] ? ktime_get+0x4b/0x135 [ 7.400253] ? nvkm_devinit_post+0x35/0xbf [nouveau] [ 7.400519] nvkm_device_init+0x228/0x5b0 [nouveau] [ 7.400626] ? kmem_cache_alloc+0xbd/0x12a [ 7.400893] nvkm_udevice_init+0x51/0xa9 [nouveau] [ 7.401137] nvkm_object_init+0xc8/0x442 [nouveau] [ 7.401244] ? check_preempt_wakeup+0xc2/0x1c1 [ 7.401487] ? nvkm_client_child_new+0x1d/0x38 [nouveau] [ 7.401729...

...0000) GS:ffff8a307fd80000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 00007fefceb1c020 CR3: 000000026fbc5000 CR4: 00000000003406e0 Call Trace: gm107_ltc_oneinit+0x7c/0x90 [nouveau] nvkm_ltc_oneinit+0x13/0x20 [nouveau] nvkm_subdev_init+0x50/0x210 [nouveau] nvkm_device_init+0x151/0x270 [nouveau] nvkm_udevice_init+0x48/0x60 [nouveau] nvkm_object_init+0x40/0x190 [nouveau] nvkm_ioctl_new+0x179/0x290 [nouveau] ? nvkm_client_notify+0x30/0x30 [nouveau] ? nvkm_udevice_rd08+0x30/0x30 [nouveau] nvkm_ioctl+0x168/0x240 [nouveau] ? nvif_client_init+0x42/0x110 [nouveau] nv...

...6b 10 00 02 15 6b 6b ...kkkkkkk....kk 6b 6b 6b 6b 6b 6b 6b 6b 00 00 00 6b 6b 6b 6b 6b kkkkkkkk...kkkkk backtrace: [<000000000f9caea9>] nvkm_iccsense_oneinit+0x231/0x1cf0 [nouveau] [<00000000d7f5cb68>] nvkm_subdev_init+0x155/0x9a0 [nouveau] [<00000000b2b0e9d8>] nvkm_device_init+0x332/0x5a0 [nouveau] [<000000003b736a7c>] nvkm_udevice_init+0x93/0xe0 [nouveau] [<00000000cc1011dc>] nvkm_object_init+0xcb/0x610 [nouveau] [<0000000006253ff8>] nvkm_ioctl_new+0x412/0x9a0 [nouveau] [<00000000db03ae9a>] nvkm_ioctl+0x3b4/0xbe0 [nouveau] [&l...

...6b 10 00 02 15 6b 6b ...kkkkkkk....kk 6b 6b 6b 6b 6b 6b 6b 6b 00 00 00 6b 6b 6b 6b 6b kkkkkkkk...kkkkk backtrace: [<000000000f9caea9>] nvkm_iccsense_oneinit+0x231/0x1cf0 [nouveau] [<00000000d7f5cb68>] nvkm_subdev_init+0x155/0x9a0 [nouveau] [<00000000b2b0e9d8>] nvkm_device_init+0x332/0x5a0 [nouveau] [<000000003b736a7c>] nvkm_udevice_init+0x93/0xe0 [nouveau] [<00000000cc1011dc>] nvkm_object_init+0xcb/0x610 [nouveau] [<0000000006253ff8>] nvkm_ioctl_new+0x412/0x9a0 [nouveau] [<00000000db03ae9a>] nvkm_ioctl+0x3b4/0xbe0 [nouveau] [&l...

...[<000000007c0d0ac3>] __kmalloc+0x337/0x500 [<00000000551bfaeb>] nvbios_iccsense_parse+0xf7/0x280 [nouveau] [<00000000e3e8968b>] nvkm_iccsense_oneinit+0x6c/0x4e0 [nouveau] [<00000000287e7701>] nvkm_subdev_init+0x58/0xd0 [nouveau] [<0000000008e4793e>] nvkm_device_init+0x118/0x1a0 [nouveau] [<000000008cd3afa3>] nvkm_udevice_init+0x48/0x60 [nouveau] [<000000007e047aee>] nvkm_object_init+0x43/0x110 [nouveau] [<000000006c56b3a4>] nvkm_ioctl_new+0x184/0x210 [nouveau] [<0000000080abc890>] nvkm_ioctl+0xf0/0x190 [nouveau] [&lt...

...ware_mem_map+0x84/0xc4 > [ 2.154094] nvkm_falcon_fw_oneinit+0xc8/0x320 > [ 2.154101] nvkm_acr_oneinit+0x428/0x5b0 > [ 2.154109] nvkm_subdev_oneinit_+0x50/0x104 > [ 2.154114] nvkm_subdev_init_+0x3c/0x12c > [ 2.154119] nvkm_subdev_init+0x60/0xa0 > [ 2.154125] nvkm_device_init+0x14c/0x2a0 > [ 2.154133] nvkm_udevice_init+0x60/0x9c > [ 2.154140] nvkm_object_init+0x48/0x1b0 > [ 2.154144] nvkm_ioctl_new+0x168/0x254 > [ 2.154149] nvkm_ioctl+0xd0/0x220 > [ 2.154153] nvkm_client_ioctl+0x10/0x1c > [ 2.154162] nvif_object_ctor+0xf4/0x22c...

...00000080050033 [ 20.839935] CR2: 00007fefceb1c020 CR3: 000000026fbc5000 CR4: 00000000003406e0 [ 20.841918] Call Trace: [ 20.843972] gm107_ltc_oneinit+0x7c/0x90 [nouveau] [ 20.845952] nvkm_ltc_oneinit+0x13/0x20 [nouveau] [ 20.847991] nvkm_subdev_init+0x50/0x210 [nouveau] [ 20.849977] nvkm_device_init+0x151/0x270 [nouveau] [ 20.851997] nvkm_udevice_init+0x48/0x60 [nouveau] [ 20.853944] nvkm_object_init+0x40/0x190 [nouveau] [ 20.855924] nvkm_ioctl_new+0x179/0x290 [nouveau] [ 20.857838] ? nvkm_client_notify+0x30/0x30 [nouveau] [ 20.859794] ? nvkm_udevice_rd08+0x30/0x30 [nouveau] [...

...u] [ 1102.005105]  gf100_gr_init_ctxctl_ext+0x59/0x500 [nouveau] [ 1102.005136]  gf100_gr_init_ctxctl+0x19/0x270 [nouveau] [ 1102.005167]  ? gf100_gr_init+0x533/0x570 [nouveau] [ 1102.005181]  nvkm_engine_init+0xa2/0x120 [nouveau] [ 1102.005196]  nvkm_subdev_init+0x8d/0xc0 [nouveau] [ 1102.005226]  nvkm_device_init+0x107/0x190 [nouveau] [ 1102.005255]  nvkm_udevice_init+0x3c/0x60 [nouveau] [ 1102.005269]  nvkm_object_init+0x39/0x100 [nouveau] [ 1102.005284]  nvkm_object_init+0x6c/0x100 [nouveau] [ 1102.005299]  nvkm_object_init+0x6c/0x100 [nouveau] [ 1102.005328]  nouveau_do_resume+0x23/0xb0 [nouveau] [ 1102....

...oc_node+0x3e/0x70 [ 8.209381] ? nvkm_vmm_ctor+0x1ce/0x250 [nouveau] [ 8.209413] nvkm_vmm_ptes_get+0x2e/0x80 [nouveau] [ 8.209446] nvkm_vmm_boot+0x3e/0x80 [nouveau] [ 8.209475] nv50_bar_oneinit+0xe8/0x310 [nouveau] [ 8.209504] nvkm_subdev_init+0x4b/0x1f0 [nouveau] [ 8.209538] nvkm_device_init+0x12c/0x260 [nouveau] [ 8.209573] nvkm_udevice_init+0x41/0x60 [nouveau] [ 8.209602] nvkm_object_init+0x3a/0x180 [nouveau] [ 8.209630] nvkm_ioctl_new+0x19d/0x260 [nouveau] [ 8.209658] ? nvkm_client_notify+0x30/0x30 [nouveau] [ 8.209692] ? nvkm_udevice_rd08+0x20/0x20 [nouveau] [...

We are working with new desktop that have the NVIDIA NV118 chipset. During boot, the display becomes unusable at the point where the nouveau driver loads. We have reproduced on 4.8, 4.11 and linux master (4.12-rc3). Dmesg log is attached. Is this a known issue? Anything we can do to help? Thanks -------------- next part -------------- An HTML attachment was scrubbed... URL:

...0x37/0x40 [ 70.135306] setup_irq_thread+0x37/0x90 [ 70.135312] __setup_irq+0x4e0/0x7c0 [ 70.135318] request_threaded_irq+0xf8/0x160 [ 70.135371] nvkm_pci_oneinit+0x4c/0x70 [nouveau] [ 70.135399] nvkm_subdev_init+0x60/0x1e0 [nouveau] [ 70.135449] nvkm_device_init+0x10b/0x240 [nouveau] [ 70.135506] nvkm_udevice_init+0x49/0x70 [nouveau] [ 70.135531] nvkm_object_init+0x3d/0x180 [nouveau] [ 70.135555] nvkm_ioctl_new+0x1a1/0x260 [nouveau] [ 70.135578] nvkm_ioctl+0x10a/0x240 [nouveau] [ 70.135600] nvif_object_ctor+0xeb...