search for: nvc0_vm_map_sg

...happens in the bug. I haven't figured out the root cause of this, but it's getting well into the "I have no idea how TTM works" space. However this seems like a bit of defensive programming -- nouveau_vm_map_sg will pass node->pages as a list down, which will be dereferenced by nvc0_vm_map_sg. Perhaps the other arguments should make that dereferencing not happen, but it definitely was happening here, as you can see in the bug. Ben/Maarten, I'll let you judge whether this check is appropriate, since like I hope I was able to convey above, I'm just not really sure :) drivers/gp...

...et/nouveau/debug/nouveau-kernel-crash01.jpg http://pasik.reaktio.net/nouveau/debug/nouveau-kernel-crash02.jpg hand-written bits from the kernel crash: Pid: 1208, comm: Xorg Not tainted 3.8.11-200.fc18.x86_64 #1 LENOVO 2349H2G/2349H2G RIP: 0010:[<ffffffffa01abb7e>] [<ffffffffa01abb7e>] nvc0_vm_map_sg+0x8e/0x110 [nouveau] RSP: 0018:ffff8803298357c8 EFLAGS: 00010206 .. Process Xorg (pid: 1208,..) .. Call Trace: .. nouveau_vm_map_sg+0xc2/0x130 [nouveau] .. nouveau_vma_getmap.isra.11+0x68/0xa0 [nouveau] .. nouveau_bo_move_m2mf.isra.12+0x85/0x140 [nouveau] .. ? nouveau_vm_map_at+0x153/0x1c0 [nouveau...

...d out the root cause of this, but it's getting > > well into the "I have no idea how TTM works" space. However this seems > > like a bit of defensive programming -- nouveau_vm_map_sg will pass > > node->pages as a list down, which will be dereferenced by > > nvc0_vm_map_sg. Perhaps the other arguments should make that > > dereferencing not happen, but it definitely was happening here, as you > > can see in the bug. > > > > Ben/Maarten, I'll let you judge whether this check is appropriate, > > since like I hope I was able to convey ab...

...gured out the root cause of this, but it's getting >> well into the "I have no idea how TTM works" space. However this seems >> like a bit of defensive programming -- nouveau_vm_map_sg will pass >> node->pages as a list down, which will be dereferenced by >> nvc0_vm_map_sg. Perhaps the other arguments should make that >> dereferencing not happen, but it definitely was happening here, as you >> can see in the bug. >> >> Ben/Maarten, I'll let you judge whether this check is appropriate, >> since like I hope I was able to convey above,...

...t it's getting > >>> well into the "I have no idea how TTM works" space. However this seems > >>> like a bit of defensive programming -- nouveau_vm_map_sg will pass > >>> node->pages as a list down, which will be dereferenced by > >>> nvc0_vm_map_sg. Perhaps the other arguments should make that > >>> dereferencing not happen, but it definitely was happening here, as you > >>> can see in the bug. > >>> > >>> Ben/Maarten, I'll let you judge whether this check is appropriate, > >>> s...

..., but it's getting >>>> well into the "I have no idea how TTM works" space. However this seems >>>> like a bit of defensive programming -- nouveau_vm_map_sg will pass >>>> node->pages as a list down, which will be dereferenced by >>>> nvc0_vm_map_sg. Perhaps the other arguments should make that >>>> dereferencing not happen, but it definitely was happening here, as you >>>> can see in the bug. >>>> >>>> Ben/Maarten, I'll let you judge whether this check is appropriate, >>>> since...

...I haven't figured out the root cause of this, but it's getting > well into the "I have no idea how TTM works" space. However this seems > like a bit of defensive programming -- nouveau_vm_map_sg will pass > node->pages as a list down, which will be dereferenced by > nvc0_vm_map_sg. Perhaps the other arguments should make that > dereferencing not happen, but it definitely was happening here, as you > can see in the bug. > > Ben/Maarten, I'll let you judge whether this check is appropriate, > since like I hope I was able to convey above, I'm just not rea...

...I haven't figured out the root cause of this, but it's getting > well into the "I have no idea how TTM works" space. However this seems > like a bit of defensive programming -- nouveau_vm_map_sg will pass > node->pages as a list down, which will be dereferenced by > nvc0_vm_map_sg. Perhaps the other arguments should make that > dereferencing not happen, but it definitely was happening here, as you > can see in the bug. > > Ben/Maarten, I'll let you judge whether this check is appropriate, > since like I hope I was able to convey above, I'm just not rea...

...ng >> >>> well into the "I have no idea how TTM works" space. However this seems >> >>> like a bit of defensive programming -- nouveau_vm_map_sg will pass >> >>> node->pages as a list down, which will be dereferenced by >> >>> nvc0_vm_map_sg. Perhaps the other arguments should make that >> >>> dereferencing not happen, but it definitely was happening here, as you >> >>> can see in the bug. >> >>> >> >>> Ben/Maarten, I'll let you judge whether this check is appropriate, &gt...

...gt;>>> well into the "I have no idea how TTM works" space. However this seems >>>>>> like a bit of defensive programming -- nouveau_vm_map_sg will pass >>>>>> node->pages as a list down, which will be dereferenced by >>>>>> nvc0_vm_map_sg. Perhaps the other arguments should make that >>>>>> dereferencing not happen, but it definitely was happening here, as you >>>>>> can see in the bug. >>>>>> >>>>>> Ben/Maarten, I'll let you judge whether this check is appr...

...of this, but it's getting > > > well into the "I have no idea how TTM works" space. However this seems > > > like a bit of defensive programming -- nouveau_vm_map_sg will pass > > > node->pages as a list down, which will be dereferenced by > > > nvc0_vm_map_sg. Perhaps the other arguments should make that > > > dereferencing not happen, but it definitely was happening here, as you > > > can see in the bug. > > > > > > Ben/Maarten, I'll let you judge whether this check is appropriate, > > > since like I hop...

...ot cause of this, but it's getting >>> well into the "I have no idea how TTM works" space. However this seems >>> like a bit of defensive programming -- nouveau_vm_map_sg will pass >>> node->pages as a list down, which will be dereferenced by >>> nvc0_vm_map_sg. Perhaps the other arguments should make that >>> dereferencing not happen, but it definitely was happening here, as you >>> can see in the bug. >>> >>> Ben/Maarten, I'll let you judge whether this check is appropriate, >>> since like I hope I was ab...

...ng > >>>> well into the "I have no idea how TTM works" space. However this seems > >>>> like a bit of defensive programming -- nouveau_vm_map_sg will pass > >>>> node->pages as a list down, which will be dereferenced by > >>>> nvc0_vm_map_sg. Perhaps the other arguments should make that > >>>> dereferencing not happen, but it definitely was happening here, as you > >>>> can see in the bug. > >>>> > >>>> Ben/Maarten, I'll let you judge whether this check is appropriate, &gt...

...well into the "I have no idea how TTM works" space. However this seems > >>>>>> like a bit of defensive programming -- nouveau_vm_map_sg will pass > >>>>>> node->pages as a list down, which will be dereferenced by > >>>>>> nvc0_vm_map_sg. Perhaps the other arguments should make that > >>>>>> dereferencing not happen, but it definitely was happening here, as you > >>>>>> can see in the bug. > >>>>>> > >>>>>> Ben/Maarten, I'll let you judge whethe...

...2 target) return phys; } -void +static void nvc0_vm_map(struct nouveau_vma *vma, struct nouveau_gpuobj *pgt, struct nouveau_mem *mem, u32 pte, u32 cnt, u64 phys, u64 delta) { @@ -80,7 +80,7 @@ nvc0_vm_map(struct nouveau_vma *vma, struct nouveau_gpuobj *pgt, } } -void +static void nvc0_vm_map_sg(struct nouveau_vma *vma, struct nouveau_gpuobj *pgt, struct nouveau_mem *mem, u32 pte, u32 cnt, dma_addr_t *list) { @@ -95,7 +95,7 @@ nvc0_vm_map_sg(struct nouveau_vma *vma, struct nouveau_gpuobj *pgt, } } -void +static void nvc0_vm_unmap(struct nouveau_gpuobj *pgt, u32 pte, u32 cnt...

...gt;tag->offset + (delta >> 17); + phys |= (u64)tag << (32 + 12); + next |= (u64)1 << (32 + 12); + ltcg->tags_clear(ltcg, tag, cnt); + } + while (cnt--) { nv_wo32(pgt, pte + 0, lower_32_bits(phys)); nv_wo32(pgt, pte + 4, upper_32_bits(phys)); @@ -85,10 +137,12 @@ nvc0_vm_map_sg(struct nouveau_vma *vma, struct nouveau_gpuobj *pgt, struct nouveau_mem *mem, u32 pte, u32 cnt, dma_addr_t *list) { u32 target = (vma->access & NV_MEM_ACCESS_NOSNOOP) ? 7 : 5; + /* compressed storage types are invalid for system memory */ + u32 memtype = nvc0_pte_storage_type_map...