search for: nvc0_screen_creat

This series is to allow NVIDIA chips with shared memory to operate more efficiently (and to operate at all once we disable VRAM from the kernel driver) by allowing nouveau_screen to specify a domain to use for objects originally allocated into VRAM. If the domain is not overridden, the default NOUVEAU_BO_VRAM is used. A NV_VRAM_DOMAIN() macro is then introduced to be used in place of

...err); \ > - nvc0_screen_destroy(pscreen); \ > - return NULL; \ > + goto fail; \ > } while(0) > > struct nouveau_screen * > @@ -650,6 +649,7 @@ nvc0_screen_create(struct nouveau_device *dev) > if (!screen) > return NULL; > pscreen = &screen->base.base; > + pscreen->destroy = nvc0_screen_destroy; > > ret = nouveau_screen_init(&screen->base, dev); > if (ret) { > @@ -672,7 +672,6 @@ nvc0_screen_...

From: Ben Skeggs <bskeggs at redhat.com> Signed-off-by: Ben Skeggs <bskeggs at redhat.com> --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 4016871..c02ee61 100644 --- a/configure.ac +++ b/configure.ac @@ -73,7 +73,7 @@ LIBDRM_RADEON_REQUIRED=2.4.56 LIBDRM_AMDGPU_REQUIRED=2.4.63 LIBDRM_INTEL_REQUIRED=2.4.61

...gt; diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0_screen.c b/src/gallium/drivers/nouveau/nvc0/nvc0_screen.c > index ac5823e4a8d5..ad143cd9a140 100644 > --- a/src/gallium/drivers/nouveau/nvc0/nvc0_screen.c > +++ b/src/gallium/drivers/nouveau/nvc0/nvc0_screen.c > @@ -620,6 +620,16 @@ nvc0_screen_create(struct nouveau_device *dev) > return NULL; > pscreen = &screen->base.base; > > + /* Recognize chipsets with no VRAM */ > + switch (dev->chipset) { > + /* GK20A */ > + case 0xea: > + screen->base.vram_domain = NOUVEAU_BO_GART; I think yo...

From: Ben Skeggs <bskeggs at redhat.com> Signed-off-by: Ben Skeggs <bskeggs at redhat.com> --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 4016871..c02ee61 100644 --- a/configure.ac +++ b/configure.ac @@ -73,7 +73,7 @@ LIBDRM_RADEON_REQUIRED=2.4.56 LIBDRM_AMDGPU_REQUIRED=2.4.63 LIBDRM_INTEL_REQUIRED=2.4.61

...c0_screen_destroy(pscreen); \ >>> - return NULL; \ >>> + goto fail; \ >>> } while(0) >>> >>> struct nouveau_screen * >>> @@ -650,6 +649,7 @@ nvc0_screen_create(struct nouveau_device *dev) >>> if (!screen) >>> return NULL; >>> pscreen = &screen->base.base; >>> + pscreen->destroy = nvc0_screen_destroy; >>> >>> ret = nouveau_screen_init(&screen->base, dev); >>&...

From: Ben Skeggs <bskeggs at redhat.com> v2. forgot bump for non-gallium driver Signed-off-by: Ben Skeggs <bskeggs at redhat.com> --- configure.ac | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index b6680d0..965c6f7 100644 --- a/configure.ac +++ b/configure.ac @@ -72,8 +72,8 @@ LIBDRM_REQUIRED=2.4.60

This series is to allow NVIDIA chips with shared memory to operate more efficiently (and to operate at all once we disable VRAM from the kernel driver) by allowing nouveau_screen to specify a domain to use for objects originally allocated into VRAM. If the domain is not overridden, the default NOUVEAU_BO_VRAM is used. A NV_VRAM_DOMAIN() macro is then introduced to be used in place of

...nvc0_screen_destroy(struct pipe_screen *pscreen) FREE(screen->tic.entries); - nouveau_mm_destroy(screen->mm_VRAM_fe0); - nouveau_object_del(&screen->eng3d); nouveau_object_del(&screen->eng2d); nouveau_object_del(&screen->m2mf); @@ -1027,7 +1025,6 @@ nvc0_screen_create(struct nouveau_device *dev) mm_config.nvc0.tile_mode = 0; mm_config.nvc0.memtype = 0xfe0; - screen->mm_VRAM_fe0 = nouveau_mm_create(dev, NOUVEAU_BO_VRAM, &mm_config); if (!nvc0_blitter_create(screen)) goto fail; diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0_scr...

...lt;< 17, size, + ret = nouveau_bo_new(screen->base.device, NV_VRAM_DOMAIN(&screen->base), 1 << 17, size, NULL, &bo); if (ret) { NOUVEAU_ERR("failed to allocate TLS area, size: 0x%"PRIx64"\n", size); @@ -812,7 +812,7 @@ nvc0_screen_create(struct nouveau_device *dev) nvc0_magic_3d_init(push, screen->eng3d->oclass); - ret = nouveau_bo_new(dev, NOUVEAU_BO_VRAM, 1 << 17, 1 << 20, NULL, + ret = nouveau_bo_new(dev, NV_VRAM_DOMAIN(&screen->base), 1 << 17, 1 << 20, NULL,...

...\ NOUVEAU_ERR(str, err); \ - nvc0_screen_destroy(pscreen); \ - return NULL; \ + goto fail; \ } while(0) struct nouveau_screen * @@ -650,6 +649,7 @@ nvc0_screen_create(struct nouveau_device *dev) if (!screen) return NULL; pscreen = &screen->base.base; + pscreen->destroy = nvc0_screen_destroy; ret = nouveau_screen_init(&screen->base, dev); if (ret) { @@ -672,7 +672,6 @@ nvc0_screen_create(struct nouveau_device *dev)...

...gt; diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0_screen.c b/src/gallium/drivers/nouveau/nvc0/nvc0_screen.c > index cccfe2bba23d..95e5ef81cd79 100644 > --- a/src/gallium/drivers/nouveau/nvc0/nvc0_screen.c > +++ b/src/gallium/drivers/nouveau/nvc0/nvc0_screen.c > @@ -702,7 +702,14 @@ nvc0_screen_create(struct nouveau_device *dev) > obj_class = NVF0_3D_CLASS; > break; > case 0xe0: > - obj_class = NVE4_3D_CLASS; > + switch (dev->chipset) { > + case 0xea: > + obj_class = NVEA_3D_CLASS; Again, would be nice to be consistent with the w...

...et = nouveau_bo_new(screen->base.device, NV_VRAM_DOMAIN(&screen->base), 1 << 17, size, > NULL, &bo); > if (ret) { > NOUVEAU_ERR("failed to allocate TLS area, size: 0x%"PRIx64"\n", size); > @@ -812,7 +812,7 @@ nvc0_screen_create(struct nouveau_device *dev) > > nvc0_magic_3d_init(push, screen->eng3d->oclass); > > - ret = nouveau_bo_new(dev, NOUVEAU_BO_VRAM, 1 << 17, 1 << 20, NULL, > + ret = nouveau_bo_new(dev, NV_VRAM_DOMAIN(&screen->base), 1 << 17, 1 << 20...

...changed, 1 insertion(+) diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0_screen.c b/src/gallium/drivers/nouveau/nvc0/nvc0_screen.c index 3e4c4f44ba92..c9042fc00447 100644 --- a/src/gallium/drivers/nouveau/nvc0/nvc0_screen.c +++ b/src/gallium/drivers/nouveau/nvc0/nvc0_screen.c @@ -903,6 +903,7 @@ nvc0_screen_create(struct nouveau_device *dev) case 0x130: switch (dev->chipset) { case 0x130: + case 0x13b: obj_class = GP100_3D_CLASS; break; default: -- 2.12.0

...splayed > >>> when trying to initialize a nvc0_screen on the Tegra X1's GM20B: > >>> > >>> [ 34.431210] nouveau 57000000.gpu: pmu:hpq: timeout waiting for queue ready > >>> [ 34.438145] nouveau 57000000.gpu: gr: init failed, -110 > >>> nvc0_screen_create:1075 - Error allocating PGRAPH context for M2MF: -110 > >>> failed to create GPU screen > >> > >> Thx for the report. Hmmm. No reply so far. :-/ Apologies for the delay and thanks to Thorsten for bringing it up again, Does the attached patch fix it? if you say it d...

...\ >> - nvc0_screen_destroy(pscreen); \ >> - return NULL; \ >> + goto fail; \ >> } while(0) >> >> struct nouveau_screen * >> @@ -650,6 +649,7 @@ nvc0_screen_create(struct nouveau_device *dev) >> if (!screen) >> return NULL; >> pscreen = &screen->base.base; >> + pscreen->destroy = nvc0_screen_destroy; >> >> ret = nouveau_screen_init(&screen->base, dev); >> if (ret) { >>...

...1-rc5 the following error message is displayed > > when trying to initialize a nvc0_screen on the Tegra X1's GM20B: > > > > [ 34.431210] nouveau 57000000.gpu: pmu:hpq: timeout waiting for queue ready > > [ 34.438145] nouveau 57000000.gpu: gr: init failed, -110 > > nvc0_screen_create:1075 - Error allocating PGRAPH context for M2MF: -110 > > failed to create GPU screen > > Thx for the report. Hmmm. No reply so far. :-/ > > Diogo, maybe report this here as well: > https://gitlab.freedesktop.org/drm/nouveau/-/issues/ > > Afterwards drop a link to the ti...

...ret = nouveau_bo_new(screen->base.device, NV_VRAM_DOMAIN(&screen->base), 1 << 17, size, > NULL, &bo); > if (ret) { > NOUVEAU_ERR("failed to allocate TLS area, size: 0x%"PRIx64"\n", size); > @@ -812,7 +812,7 @@ nvc0_screen_create(struct nouveau_device *dev) > > nvc0_magic_3d_init(push, screen->eng3d->oclass); > > - ret = nouveau_bo_new(dev, NOUVEAU_BO_VRAM, 1 << 17, 1 << 20, NULL, > + ret = nouveau_bo_new(dev, NV_VRAM_DOMAIN(&screen->base), 1 << 17, 1 << 20, NULL,...

New revision of this patchset that prevents VRAM objects from being allocated on VRAM-less systems like Tegra. This is required for Mesa to work on such systems. Changes since v2: - Use vram_size to detect systems without VRAM and set the correct domain instead of expecting each chip to set its domain explicitly. Alexandre Courbot (2): nouveau: support for custom VRAM domains nvc0: use

...owing error message is displayed >>> when trying to initialize a nvc0_screen on the Tegra X1's GM20B: >>> >>> [ 34.431210] nouveau 57000000.gpu: pmu:hpq: timeout waiting for queue ready >>> [ 34.438145] nouveau 57000000.gpu: gr: init failed, -110 >>> nvc0_screen_create:1075 - Error allocating PGRAPH context for M2MF: -110 >>> failed to create GPU screen >> >> Thx for the report. Hmmm. No reply so far. :-/ >> >> Diogo, maybe report this here as well: >> https://gitlab.freedesktop.org/drm/nouveau/-/issues/ >> >> A...