search for: nvbios_therm_fan_linear

...uveau/nvkm/subdev/bios/fan.c index 43006db..80fed7e 100644 --- a/drm/nouveau/nvkm/subdev/bios/fan.c +++ b/drm/nouveau/nvkm/subdev/bios/fan.c @@ -83,6 +83,7 @@ nvbios_fan_parse(struct nvkm_bios *bios, struct nvbios_therm_fan *fan) fan->type = NVBIOS_THERM_FAN_UNK; } + fan->fan_mode = NVBIOS_THERM_FAN_LINEAR; fan->min_duty = nvbios_rd08(bios, data + 0x02); fan->max_duty = nvbios_rd08(bios, data + 0x03); -- 2.6.2

...dev/bios/fan.c >> +++ b/drm/nouveau/nvkm/subdev/bios/fan.c >> @@ -83,6 +83,7 @@ nvbios_fan_parse(struct nvkm_bios *bios, struct >> nvbios_therm_fan *fan) >> fan->type = NVBIOS_THERM_FAN_UNK; >> } >> >> + fan->fan_mode = NVBIOS_THERM_FAN_LINEAR; >> fan->min_duty = nvbios_rd08(bios, data + 0x02); >> fan->max_duty = nvbios_rd08(bios, data + 0x03); >> >> > > Ben, can you merge this patch? It is kind of critical :s And it should > be CCed to stable too, without it, some kepler/maxwel...

From: Martin Peres <martin.peres at labri.fr> This should fix a deadlock that has been reported to us where fan_update() would hold the fan lock and try to grab the alarm_program_lock to reschedule an update. On an other CPU, the alarm_program_lock would have been taken before calling fan_update(), leading to a deadlock. We should Cc: <stable at vger.kernel.org> # 3.9+ Reported-by:

...bdev/bios/fan.c >>>> @@ -83,6 +83,7 @@ nvbios_fan_parse(struct nvkm_bios *bios, struct >>>> nvbios_therm_fan *fan) >>>> fan->type = NVBIOS_THERM_FAN_UNK; >>>> } >>>> >>>> + fan->fan_mode = NVBIOS_THERM_FAN_LINEAR; >>>> fan->min_duty = nvbios_rd08(bios, data + 0x02); >>>> fan->max_duty = nvbios_rd08(bios, data + 0x03); >>>> >>>> >>> Ben, can you merge this patch? It is kind of critical :s And it should be >>> CCed t...

...43006db..80fed7e 100644 > --- a/drm/nouveau/nvkm/subdev/bios/fan.c > +++ b/drm/nouveau/nvkm/subdev/bios/fan.c > @@ -83,6 +83,7 @@ nvbios_fan_parse(struct nvkm_bios *bios, struct nvbios_therm_fan *fan) > fan->type = NVBIOS_THERM_FAN_UNK; > } > > + fan->fan_mode = NVBIOS_THERM_FAN_LINEAR; > fan->min_duty = nvbios_rd08(bios, data + 0x02); > fan->max_duty = nvbios_rd08(bios, data + 0x03); > > Ben, can you merge this patch? It is kind of critical :s And it should be CCed to stable too, without it, some kepler/maxwell get 0% fan power which is kind of dange...

...+++ b/drm/nouveau/nvkm/subdev/bios/fan.c >>> @@ -83,6 +83,7 @@ nvbios_fan_parse(struct nvkm_bios *bios, struct >>> nvbios_therm_fan *fan) >>> fan->type = NVBIOS_THERM_FAN_UNK; >>> } >>> >>> + fan->fan_mode = NVBIOS_THERM_FAN_LINEAR; >>> fan->min_duty = nvbios_rd08(bios, data + 0x02); >>> fan->max_duty = nvbios_rd08(bios, data + 0x03); >>> >>> >> >> Ben, can you merge this patch? It is kind of critical :s And it should be >> CCed to stable too, wit...

...>>> @@ -83,6 +83,7 @@ nvbios_fan_parse(struct nvkm_bios *bios, struct >>>>> nvbios_therm_fan *fan) >>>>> fan->type = NVBIOS_THERM_FAN_UNK; >>>>> } >>>>> >>>>> + fan->fan_mode = NVBIOS_THERM_FAN_LINEAR; >>>>> fan->min_duty = nvbios_rd08(bios, data + 0x02); >>>>> fan->max_duty = nvbios_rd08(bios, data + 0x03); >>>>> >>>>> >>>> Ben, can you merge this patch? It is kind of critical :s And it >>&...

...to this there was a conversation on #nouveau: Reverting a part of the above noted patch: - /* starting from fermi, fan management is always linear */ - if (nv_device(bios)->card_type >= NV_C0 && - fan->fan_mode == NVBIOS_THERM_FAN_OTHER) { - fan->fan_mode = NVBIOS_THERM_FAN_LINEAR; - } hides the bug away again. -- You are receiving this mail because: You are the assignee for the bug. -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.freedesktop.org/archives/nouveau/attachments/20150129/3c8c188d/attachment.html>

Adds Nouveau controlled thermal throttling for Kepler+ GPUs. With this I feel safe enough to add support for Maxwell2 reclocking later on (still hidden behind a switch, but we can be fairly sure to not overheat hardware if a user isn't carefull enough) Contains all patches from my clk update series, but I thought it makes sense to include those in this series as well for completness. Please

Last update here: https://lists.freedesktop.org/archives/nouveau/2017-September/028848.html Basically big cleanup, reordering, simplifications and some renaming to make the code easier to read and to review. I also moved some bugfixes to the front so they can be merged prior the other patches. There was also a bug related to the therm daemon triggering a pstate change leading to PMU lockups,

Just wanted to post updated versions of my last series/patches. Reviews welcomed. It would be also nice if we agree on features I should focus upstreaming, so that this work can be better splitted or reordered. Sadly most of my patches depend on the rather big clk subdev rework and I think those patches shows best, why I think this rework is actually needed and makes things much easier to add