search for: nv50_fbcon_imageblit

...gt;flags & FBINFO_HWACCEL_DISABLED) && RING_SPACE(chan, 12)) { - NV_ERROR(dev, "GPU lockup - switching to software fbcon\n"); - - info->flags |= FBINFO_HWACCEL_DISABLED; + NV_GPU_LOCKUP(info); } if (info->flags & FBINFO_HWACCEL_DISABLED) { @@ -102,8 +98,7 @@ nv50_fbcon_imageblit(struct fb_info *info, const struct fb_image *image) } if (!(info->flags & FBINFO_HWACCEL_DISABLED) && RING_SPACE(chan, 11)) { - NV_ERROR(dev, "GPU lockup - switching to software fbcon\n"); - info->flags |= FBINFO_HWACCEL_DISABLED; + NV_GPU_LOCKUP(info); }...

...int iter_len = dsize > 128 ? 128 : dsize; Index: linux-2.6/drivers/gpu/drm/nouveau/nv50_fbcon.c =================================================================== --- linux-2.6.orig/drivers/gpu/drm/nouveau/nv50_fbcon.c +++ linux-2.6/drivers/gpu/drm/nouveau/nv50_fbcon.c @@ -125,7 +125,7 @@ nv50_fbcon_imageblit(struct fb_info *inf OUT_RING(chan, 0); OUT_RING(chan, image->dy); - dwords = ALIGN(image->width * image->height, 32) >> 5; + dwords = ALIGN(ALIGN(image->width, 8) * image->height, 32) >> 5; while (dwords) { int push = dwords > 2047 ? 2047 : dwords;

...ntaining the KASAN report Previously reported by others to mailing lists (with no replies): [4.4-rc1] nouveau: BUG: KASAN: slab-out-of-bounds in memcpy+0x1d/0x40 https://lists.freedesktop.org/archives/dri-devel/2015-November/095100.html [3.10] BUG: drm, nouveau: slab-out-of-bounds read access in nv50_fbcon_imageblit() https://lists.freedesktop.org/archives/dri-devel/2016-May/108270.html Hardware: Optimus laptop with inteldrmfb being the primary framebuffer, an external monitor is connected to DP-1 on the Nvidia card (GTX 965M, 10de:13d9). Steps to reproduce the out-of-bounds issue in my environment: 0. Avo...

...0000000000000005 0000000000000870 0000000002b68908 [ 3.571352] 3280: 0000000000000540 ffff8009766b1000 0000030300000326 0000000000000018 [ 3.571354] 32a0: ffff800976000c00 0000000000000008 [ 3.571359] [<ffff00000841077c>] __memcpy+0x7c/0x180 [ 3.571364] [<ffff00000866fcb4>] nv50_fbcon_imageblit+0x204/0x338 [ 3.571367] [<ffff00000866e2cc>] nouveau_fbcon_imageblit+0x94/0xe0 [ 3.571372] [<ffff0000084aa794>] soft_cursor+0x15c/0x1e0 [ 3.571375] [<ffff0000084aa1c4>] bit_cursor+0x4f4/0x538 [ 3.571379] [<ffff0000084a64d8>] fbcon_cursor+0x128/0x1b0 [ 3.571383...

...p;& !(info->flags & FBINFO_HWACCEL_DISABLED) && - mutex_trylock(&drm->client.mutex)) { - if (device->info.family < NV_DEVICE_INFO_V0_TESLA) - ret = nv04_fbcon_imageblit(info, image); - else - if (device->info.family < NV_DEVICE_INFO_V0_FERMI) - ret = nv50_fbcon_imageblit(info, image); - else - ret = nvc0_fbcon_imageblit(info, image); - mutex_unlock(&drm->client.mutex); - } - - if (ret == 0) - return; - - if (ret != -ENODEV) - nouveau_fbcon_gpu_lockup(info); - drm_fb_helper_cfb_imageblit(info, image); -} - -static int -nouveau_fbcon_sync(struct fb_info...

https://bugs.freedesktop.org/show_bug.cgi?id=67315 Priority: medium Bug ID: 67315 Assignee: nouveau at lists.freedesktop.org Summary: System lockup with X consuming all CPU QA Contact: xorg-team at lists.x.org Severity: normal Classification: Unclassified OS: Linux (All) Reporter: ricks at alldigital.com

...nt.mutex)) { > - if (device->info.family < NV_DEVICE_INFO_V0_TESLA) > - ret = nv04_fbcon_imageblit(info, image); > - else > - if (device->info.family < NV_DEVICE_INFO_V0_FERMI) > - ret = nv50_fbcon_imageblit(info, image); > - else > - ret = nvc0_fbcon_imageblit(info, image); > - mutex_unlock(&drm->client.mutex); > - } > - > - if (ret == 0) > - return; > - > - if (ret != -ENODEV) > -...

...; - if (device->info.family < NV_DEVICE_INFO_V0_TESLA) >> - ret = nv04_fbcon_imageblit(info, image); >> - else >> - if (device->info.family < NV_DEVICE_INFO_V0_FERMI) >> - ret = nv50_fbcon_imageblit(info, image); >> - else >> - ret = nvc0_fbcon_imageblit(info, image); >> - mutex_unlock(&drm->client.mutex); >> - } >> - >> - if (ret == 0) >> - return; >> - >> -...

...p;& !(info->flags & FBINFO_HWACCEL_DISABLED) && - mutex_trylock(&drm->client.mutex)) { - if (device->info.family < NV_DEVICE_INFO_V0_TESLA) - ret = nv04_fbcon_imageblit(info, image); - else - if (device->info.family < NV_DEVICE_INFO_V0_FERMI) - ret = nv50_fbcon_imageblit(info, image); - else - ret = nvc0_fbcon_imageblit(info, image); - mutex_unlock(&drm->client.mutex); - } - - if (ret == 0) - return; - - if (ret != -ENODEV) - nouveau_fbcon_gpu_lockup(info); - drm_fb_helper_cfb_imageblit(info, image); -} - -static int -nouveau_fbcon_sync(struct fb_info...

...u/drm/nouveau/nouveau_fbcon.h b/drivers/gpu/drm/nouveau/nouveau_fbcon.h index fdfc0c9..b4ff8d5 100644 --- a/drivers/gpu/drm/nouveau/nouveau_fbcon.h +++ b/drivers/gpu/drm/nouveau/nouveau_fbcon.h @@ -51,10 +51,26 @@ int nv50_fbcon_copyarea(struct fb_info *info, const struct fb_copyarea *region); int nv50_fbcon_imageblit(struct fb_info *info, const struct fb_image *image); int nv50_fbcon_accel_init(struct fb_info *info); +#ifdef CONFIG_DRM_NOUVEAU_NVC0 int nvc0_fbcon_fillrect(struct fb_info *info, const struct fb_fillrect *rect); int nvc0_fbcon_copyarea(struct fb_info *info, const struct fb_copyarea *region);...

Revised patch set v2. [PATCH 1/8] drm/nouveau: bo read/write wrappers for nv04_crtc.c [PATCH 2/8] drm/nouveau: use bo accessors for push buffers [PATCH 3/8] drm/nouveau: OUT_RINGp - optimize OUT_RING loops [PATCH 4/8] drm/nv50: proper notifier_bo access in nv50_display_vblank_crtc_handler() [PATCH 5/8] drm/nouveau: access fbcon notifier via bo accessors [PATCH 6/8] drm/nouveau: screen_base and

...ge) +static inline int nv04_fbcon_accel_init(struct fb_info *info) +{ + return -ENODEV; +} +#endif +#ifdef CONFIG_DRM_NOUVEAU_NV50 int nv50_fbcon_fillrect(struct fb_info *info, const struct fb_fillrect *rect); int nv50_fbcon_copyarea(struct fb_info *info, const struct fb_copyarea *region); int nv50_fbcon_imageblit(struct fb_info *info, const struct fb_image *image); int nv50_fbcon_accel_init(struct fb_info *info); +#else +_STUB(nv50_fbcon_fillrect, fb_fillrect) +_STUB(nv50_fbcon_copyarea, fb_copyarea) +_STUB(nv50_fbcon_imageblit, fb_image) +static inline int nv50_fbcon_accel_init(struct fb_info *info) +{ +...

...on.h b/drivers/gpu/drm/nouveau/nouveau_fbcon.h > index fdfc0c9..b4ff8d5 100644 > --- a/drivers/gpu/drm/nouveau/nouveau_fbcon.h > +++ b/drivers/gpu/drm/nouveau/nouveau_fbcon.h > @@ -51,10 +51,26 @@ int nv50_fbcon_copyarea(struct fb_info *info, const struct fb_copyarea *region); > int nv50_fbcon_imageblit(struct fb_info *info, const struct fb_image *image); > int nv50_fbcon_accel_init(struct fb_info *info); > > +#ifdef CONFIG_DRM_NOUVEAU_NVC0 > int nvc0_fbcon_fillrect(struct fb_info *info, const struct fb_fillrect *rect); > int nvc0_fbcon_copyarea(struct fb_info *info, const struct...

https://bugs.freedesktop.org/show_bug.cgi?id=33165 Summary: Nouveau + nvidia GT240 = unworkable Product: xorg Version: 7.5 Platform: x86 (IA32) OS/Version: Linux (All) Status: NEW Severity: normal Priority: medium Component: Driver/nouveau AssignedTo: nouveau at lists.freedesktop.org