search for: nv50_display

...to see if mstm->msto is null is redundant because it is an array and hence can never be null. Remove the redundant check. Detected by CoverityScan, CID#1375915 ("Array compared against 0") Signed-off-by: Colin Ian King <colin.king at canonical.com> --- drivers/gpu/drm/nouveau/nv50_display.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nv50_display.c b/drivers/gpu/drm/nouveau/nv50_display.c index f7b4326a4641..51e9081b95a0 100644 --- a/drivers/gpu/drm/nouveau/nv50_display.c +++ b/drivers/gpu/drm/nouveau/nv50_display.c @@ -3141,7 +3141,7...

...fresh rate with the "video=... at nn" parameter, e.g. video=1280x1024 at 75 is ignored. I bisected this to the following commit: drm/nv50: enable hpd on any connector we know the gpio line for Signed-off-by: Ben Skeggs <bskeggs at redhat.com> diff --git a/drivers/gpu/drm/nouveau/nv50_display.c b/drivers/gpu/drm/nouveau/nv50_display.c index 61a89f2..ebcd8bf 100644 --- a/drivers/gpu/drm/nouveau/nv50_display.c +++ b/drivers/gpu/drm/nouveau/nv50_display.c @@ -370,7 +370,9 @@ nv50_display_init(struct drm_device *dev) struct nouveau_connector *conn = nouveau_connector(connector);...

...r suggesting the correct fix. Detected by CoverityScan, CID#1375915 ("Array compared against 0") Fixes: f479c0ba4a17 ("drm/nouveau/kms/nv50: initial support for DP 1.2 multi-stream") Signed-off-by: Colin Ian King <colin.king at canonical.com> --- drivers/gpu/drm/nouveau/nv50_display.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nv50_display.c b/drivers/gpu/drm/nouveau/nv50_display.c index f7b4326a4641..ed444ecd9e85 100644 --- a/drivers/gpu/drm/nouveau/nv50_display.c +++ b/drivers/gpu/drm/nouveau/nv50_display.c @@ -3141,7 +3141,7...

From: Arnd Bergmann <arnd at arndb.de> nv50_display_create() is declared in another header, along with a couple of declarations that are now outdated: drivers/gpu/drm/nouveau/dispnv50/disp.c:2517:1: error: no previous prototype for 'nv50_display_create' Fixes: ba801ef068c1 ("drm/nouveau/kms: display destroy/init/fini hooks can be stat...

fixes d9c0aadc5aa241df26ce8301d34a8418919fb5ae Signed-off-by: Karol Herbst <kherbst at redhat.com> --- drm/nouveau/nouveau_backlight.c | 7 +++++++ drm/nouveau/nv50_display.c | 4 ++-- drm/nouveau/nv50_display.h | 4 ++++ 3 files changed, 13 insertions(+), 2 deletions(-) diff --git a/drm/nouveau/nouveau_backlight.c b/drm/nouveau/nouveau_backlight.c index 380f3402..057708da 100644 --- a/drm/nouveau/nouveau_backlight.c +++ b/drm/nouveau/nouveau_backlight.c @@...

...in the case of a GP108 board, the register indicated that there were only 2. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101601 Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu> --- I'm not extremely happy about the fact that we have to duplicate the head count in both the nv50_display logic for creating DRM-side CRTC's, as well as the nvkm-side logic for creating heads. However I don't immediately see an easy way around it without creating a nvif ioctl to get the number of heads. drm/nouveau/nv50_display.c | 8 +++++--- drm/nouveau/nvkm/engine/disp/gf119....

Add null check before dereferencing pointer asyc Addresses-Coverity-ID: 1397932 Signed-off-by: Gustavo A. R. Silva <garsilva at embeddedor.com> --- drivers/gpu/drm/nouveau/nv50_display.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nv50_display.c b/drivers/gpu/drm/nouveau/nv50_display.c index a766324..052a60a 100644 --- a/drivers/gpu/drm/nouveau/nv50_display.c +++ b/drivers/gpu/drm/nouveau/nv50_display.c @@ -2107,7 +2107,8 @@ nv50_...

...ork.freedesktop.org/patch/msgid/20170711143314.2148-2-maarten.lankhorst at linux.intel.com Reviewed-by: Sean Paul <seanpaul at chromium.org> [mlankhorst: Use if (ret) to remove the goto in success case.] Reviewed-by: Daniel Vetter <daniel.vetter at ffwll.ch> --- drivers/gpu/drm/nouveau/nv50_display.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nv50_display.c b/drivers/gpu/drm/nouveau/nv50_display.c index 5f71e304022e..c1e7307a2538 100644 --- a/drivers/gpu/drm/nouveau/nv50_display.c +++ b/drivers/gpu/drm/nouveau/nv50_display.c @@ -4120,7 +...

...d P51. (See Bug 101778). lspci example: 01:00.0 3D controller: NVIDIA Corporation GM107GLM [Quadro M1200 Mobile] (rev a2) Also include safe-guards to avoid NULL dereferencing of fbcon, which is how this bug was found. ---  drivers/gpu/drm/nouveau/nouveau_fbcon.c |  3 +--  drivers/gpu/drm/nouveau/nv50_display.c  | 13 +++++++++++++  2 files changed, 14 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_fbcon.c b/drivers/gpu/drm/nouveau/nouveau_fbcon.c index 2b12d82aac15..6b4d374a9d82 100644 --- a/drivers/gpu/drm/nouveau/nouveau_fbcon.c +++ b/drivers/gpu/drm/nouveau/nouveau_fbcon....

...overityScan, CID#1375915 ("Array compared against 0") >> >> Fixes: f479c0ba4a17 ("drm/nouveau/kms/nv50: initial support for DP 1.2 multi-stream") >> Signed-off-by: Colin Ian King <colin.king at canonical.com> >> --- >> drivers/gpu/drm/nouveau/nv50_display.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/nouveau/nv50_display.c b/drivers/gpu/drm/nouveau/nv50_display.c >> index f7b4326a4641..ed444ecd9e85 100644 >> --- a/drivers/gpu/drm/nouveau/nv50_display.c >> +++ b/drive...

...<rspliet at eclipso.eu> Tested-by: Zlatko Calusic <zcalusic at bitsync.net> Tested-by: Michael Riesch <michael at riesch.at> Tested-by: "poma" <pomidorabelisima at gmail.com> Tested-by: Adam Williamson <adamw at happyassassin.net> --- drivers/gpu/drm/nouveau/nv50_display.c | 26 ++++++++++++++++++++++++-- 1 file changed, 24 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nv50_display.c b/drivers/gpu/drm/nouveau/nv50_display.c index ae873d1..2f24a08 100644 --- a/drivers/gpu/drm/nouveau/nv50_display.c +++ b/drivers/gpu/drm/nouveau/nv50_display.c @...

...rfaces internally") Cc: Ben Skeggs <bskeggs at redhat.com> Cc: dri-devel at lists.freedesktop.org Cc: nouveau at lists.freedesktop.org Cc: <stable at vger.kernel.org> # v4.10+ Signed-off-by: Maarten Lankhorst <maarten.lankhorst at linux.intel.com> --- drivers/gpu/drm/nouveau/nv50_display.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nv50_display.c b/drivers/gpu/drm/nouveau/nv50_display.c index 42a85c14aea0..8fb55b96c40f 100644 --- a/drivers/gpu/drm/nouveau/nv50_display.c +++ b/drivers/gpu/drm/nouveau/nv50_display.c @@ -4119,7 +...

....org/show_bug.cgi?id=80675 Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu> --- There's more to be done here I think since the first modeset ends up skipping a bunch of stuff for some reason. But I can't figure out how to get it to not do that. But this is a start. drm/nouveau/nv50_display.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drm/nouveau/nv50_display.c b/drm/nouveau/nv50_display.c index 584466ef..0e8f4b76 100644 --- a/drm/nouveau/nv50_display.c +++ b/drm/nouveau/nv50_display.c @@ -1800,12 +1800,14 @@ nv50_head_lut_set(struct nv50_head *head, str...

...NVIDIA Corporation GM107GLM [Quadro M1200 Mobile] >> (rev a2) >> >> Also include safe-guards to avoid NULL dereferencing of fbcon, which is >> how this bug was found. >> --- >>   drivers/gpu/drm/nouveau/nouveau_fbcon.c |  3 +-- >>   drivers/gpu/drm/nouveau/nv50_display.c  | 13 +++++++++++++ >>   2 files changed, 14 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/gpu/drm/nouveau/nouveau_fbcon.c >> b/drivers/gpu/drm/nouveau/nouveau_fbcon.c >> index 2b12d82aac15..6b4d374a9d82 100644 >> --- a/drivers/gpu/drm/nouveau/nouvea...

...rue for DVI, but not for HDMI. HDMI supports no dual link, but it supports pixel clock rates above 165 MHz. Only activate Dual Link mode when it is actual possible. Signed-off-by: Hauke Mehrtens <hauke at hauke-m.de> Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu> --- drm/nouveau/nv50_display.c | 8 ++++---- drm/nouveau/nvkm/engine/disp/gf119.c | 2 +- drm/nouveau/nvkm/engine/disp/nv50.c | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drm/nouveau/nv50_display.c b/drm/nouveau/nv50_display.c index c053c50..93bcfdf 100644 --- a/drm/nouveau/nv50_display.c +...

...ko Calusic <zcalusic at bitsync.net> >> Tested-by: Michael Riesch <michael at riesch.at> >> Tested-by: "poma" <pomidorabelisima at gmail.com> >> Tested-by: Adam Williamson <adamw at happyassassin.net> >> --- >> drivers/gpu/drm/nouveau/nv50_display.c | 26 ++++++++++++++++++++++++-- >> 1 file changed, 24 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/gpu/drm/nouveau/nv50_display.c b/drivers/gpu/drm/nouveau/nv50_display.c >> index ae873d1..2f24a08 100644 >> --- a/drivers/gpu/drm/nouveau/nv50_display.c &g...

I don't see why the display engine would need write access to the entirety of vram, when read-only access is enough. Signed-off-by: Maarten Lankhorst <maarten.lankhorst at canonical.com> --- drivers/gpu/drm/nouveau/nv50_display.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nv50_display.c b/drivers/gpu/drm/nouveau/nv50_display.c index aab72f5..eac6b2a 100644 --- a/drivers/gpu/drm/nouveau/nv50_display.c +++ b/drivers/gpu/drm/nouveau/nv50_display.c @@ -159,7...

...3.17-rc. There's one minor nitpick inline too. Please also try and watch the wrapping of commit messages, I added newlines to make it easier to read them in git-log output. Thanks, Ben. > > Signed-off-by: Roy Spliet <rspliet at eclipso.eu> > --- > drivers/gpu/drm/nouveau/nv50_display.c | 12 +++++++++--- > 1 file changed, 9 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/nouveau/nv50_display.c b/drivers/gpu/drm/nouveau/nv50_display.c > index 4c534b7..cfa7ecf 100644 > --- a/drivers/gpu/drm/nouveau/nv50_display.c > +++ b/drivers/gpu/drm/nouveau/nv...

...link, but it supports pixel clock rates above 165 MHz. >> Only activate Dual Link mode when it is actual possible. >> >> Signed-off-by: Hauke Mehrtens <hauke at hauke-m.de> >> Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu> >> --- >> drm/nouveau/nv50_display.c | 8 ++++---- >> drm/nouveau/nvkm/engine/disp/gf119.c | 2 +- >> drm/nouveau/nvkm/engine/disp/nv50.c | 2 +- >> 3 files changed, 6 insertions(+), 6 deletions(-) >> >> diff --git a/drm/nouveau/nv50_display.c b/drm/nouveau/nv50_display.c >> index c053c...

...;>> (rev a2) >>>> >>>> Also include safe-guards to avoid NULL dereferencing of fbcon, which is >>>> how this bug was found. >>>> --- >>>> drivers/gpu/drm/nouveau/nouveau_fbcon.c | 3 +-- >>>> drivers/gpu/drm/nouveau/nv50_display.c | 13 +++++++++++++ >>>> 2 files changed, 14 insertions(+), 2 deletions(-) >>>> >>>> diff --git a/drivers/gpu/drm/nouveau/nouveau_fbcon.c >>>> b/drivers/gpu/drm/nouveau/nouveau_fbcon.c >>>> index 2b12d82aac15..6b4d374a9d82 100644 >...