Displaying 2 results from an estimated 2 matches for "nv50_disp_chan_intr".
2018 Jun 26
1
[bug report] drm/nouveau/disp/nv50-: add channel interfaces to control error interrupts
Hello Ben Skeggs,
The patch a9c44a88ca2f: "drm/nouveau/disp/nv50-: add channel
interfaces to control error interrupts" from May 8, 2018, leads to
the following static checker warning:
drivers/gpu/drm/nouveau/nvkm/engine/disp/channv50.c:169 nv50_disp_chan_intr()
warn: should '65537 << chan->chid.user' be a 64 bit type?
drivers/gpu/drm/nouveau/nvkm/engine/disp/channv50.c
165 void
166 nv50_disp_chan_intr(struct nv50_disp_chan *chan, bool en)
167 {
168 struct nvkm_device *device = chan->disp->base.engine.subd...
2018 May 27
1
[PATCH][next] drm/nouveau/disp: avoid potential overflow on shift of int value
...iff --git a/drivers/gpu/drm/nouveau/nvkm/engine/disp/channv50.c b/drivers/gpu/drm/nouveau/nvkm/engine/disp/channv50.c
index 57719f675eec..43ae3b092e43 100644
--- a/drivers/gpu/drm/nouveau/nvkm/engine/disp/channv50.c
+++ b/drivers/gpu/drm/nouveau/nvkm/engine/disp/channv50.c
@@ -166,7 +166,7 @@ void
nv50_disp_chan_intr(struct nv50_disp_chan *chan, bool en)
{
struct nvkm_device *device = chan->disp->base.engine.subdev.device;
- const u64 mask = 0x00010001 << chan->chid.user;
+ const u64 mask = 0x00010001ULL << chan->chid.user;
const u64 data = en ? 0x00010000 : 0x00000000;
nvkm_mask(...