search for: nv04_sgdma_bind

...is only the tip of the iceberg, so this isn't a formal patch submission, but I would appreciate your thought as to whether the below is correct (and thus I'm on the right track) : --- a/drivers/gpu/drm/nouveau/nouveau_sgdma.c +++ b/drivers/gpu/drm/nouveau/nouveau_sgdma.c @@ -31,7 +31,7 @@ nv04_sgdma_bind(struct ttm_tt *ttm, struct ttm_mem_reg *mem) { struct nouveau_sgdma_be *nvbe = (struct nouveau_sgdma_be *)ttm; struct nouveau_mem *node = mem->mm_node; - u64 size = mem->num_pages << 12; + u64 size = mem->num_pages << PAGE_SHIFT; if (ttm-&...

...100644 --- a/drivers/gpu/drm/nouveau/nouveau_sgdma.c +++ b/drivers/gpu/drm/nouveau/nouveau_sgdma.c @@ -51,7 +51,7 @@ nv04_sgdma_unbind(struct ttm_tt *ttm) return 0; } -static struct ttm_backend_func nv04_sgdma_backend = { +static const struct ttm_backend_func nv04_sgdma_backend = { .bind = nv04_sgdma_bind, .unbind = nv04_sgdma_unbind, .destroy = nouveau_sgdma_destroy @@ -82,7 +82,7 @@ nv50_sgdma_unbind(struct ttm_tt *ttm) return 0; } -static struct ttm_backend_func nv50_sgdma_backend = { +static const struct ttm_backend_func nv50_sgdma_backend = { .bind = nv50_sgdma_bind, .unbind...

...100644 --- a/drivers/gpu/drm/nouveau/nouveau_sgdma.c +++ b/drivers/gpu/drm/nouveau/nouveau_sgdma.c @@ -51,7 +51,7 @@ nv04_sgdma_unbind(struct ttm_tt *ttm) return 0; } -static struct ttm_backend_func nv04_sgdma_backend = { +static const struct ttm_backend_func nv04_sgdma_backend = { .bind = nv04_sgdma_bind, .unbind = nv04_sgdma_unbind, .destroy = nouveau_sgdma_destroy @@ -82,7 +82,7 @@ nv50_sgdma_unbind(struct ttm_tt *ttm) return 0; } -static struct ttm_backend_func nv50_sgdma_backend = { +static const struct ttm_backend_func nv50_sgdma_backend = { .bind = nv50_sgdma_bind, .unbind...

Op 11-08-13 07:36, Benjamin Herrenschmidt schreef: > On Sun, 2013-08-11 at 10:41 +1000, Benjamin Herrenschmidt wrote: >> Now, to do that, I need a better understanding of the various things >> in there since I'm not familiar with nouveau at all. What I think I've >> figured out is with a few questions, it would be awesome if you could >> answer them so I can have

...nouveau_bo_fixup_align(nvbo, flags, &align, &size); diff --git a/drivers/gpu/drm/nouveau/nouveau_sgdma.c b/drivers/gpu/drm/nouveau/nouveau_sgdma.c index ca5492a..494cf88 100644 --- a/drivers/gpu/drm/nouveau/nouveau_sgdma.c +++ b/drivers/gpu/drm/nouveau/nouveau_sgdma.c @@ -31,7 +31,7 @@ nv04_sgdma_bind(struct ttm_tt *ttm, struct ttm_mem_reg *mem) { struct nouveau_sgdma_be *nvbe = (struct nouveau_sgdma_be *)ttm; struct nouveau_mem *node = mem->mm_node; - u64 size = mem->num_pages << 12; + u64 size = mem->num_pages << PAGE_SHIFT; if (ttm->sg) { node->sg = ttm-...

...nouveau_bo_fixup_align(nvbo, flags, &align, &size); diff --git a/drivers/gpu/drm/nouveau/nouveau_sgdma.c b/drivers/gpu/drm/nouveau/nouveau_sgdma.c index 0843ebc..f255ff8 100644 --- a/drivers/gpu/drm/nouveau/nouveau_sgdma.c +++ b/drivers/gpu/drm/nouveau/nouveau_sgdma.c @@ -31,7 +31,7 @@ nv04_sgdma_bind(struct ttm_tt *ttm, struct ttm_mem_reg *mem) { struct nouveau_sgdma_be *nvbe = (struct nouveau_sgdma_be *)ttm; struct nouveau_mem *node = mem->mm_node; - u64 size = mem->num_pages << 12; + u64 size = mem->num_pages << PAGE_SHIFT; if (ttm->sg) { node->sg = ttm-...

...39;re hitting. > > diff --git a/drivers/gpu/drm/nouveau/nouveau_sgdma.c b/drivers/gpu/drm/nouveau/nouveau_sgdma.c > > index ca5492a..494cf88 100644 > > --- a/drivers/gpu/drm/nouveau/nouveau_sgdma.c > > +++ b/drivers/gpu/drm/nouveau/nouveau_sgdma.c > > @@ -31,7 +31,7 @@ nv04_sgdma_bind(struct ttm_tt *ttm, struct ttm_mem_reg *mem) > > { > > struct nouveau_sgdma_be *nvbe = (struct nouveau_sgdma_be *)ttm; > > struct nouveau_mem *node = mem->mm_node; > > - u64 size = mem->num_pages << 12; > > + u64 size = mem->num_pages << PAGE_...

...vm_map_sg+0x1ae/0x1d0 [nouveau] [ 402.178020] [<ffffffffa012f507>] nouveau_vm_map+0x287/0x3d0 [nouveau] [ 402.178026] [<ffffffff811ca7f7>] ? __kmalloc+0x1f7/0x240 [ 402.178039] [<ffffffffa005f3a2>] ? ttm_dma_tt_init+0xe2/0x110 [ttm] [ 402.178077] [<ffffffffa0173c0e>] nv04_sgdma_bind+0x4e/0x80 [nouveau] [ 402.178087] [<ffffffffa005ecaf>] ttm_tt_bind+0x4f/0x70 [ttm] [ 402.178096] [<ffffffffa006100f>] ttm_bo_handle_move_mem+0x54f/0x5b0 [ttm] [ 402.178104] [<ffffffffa00616b9>] ? ttm_bo_mem_space+0x169/0x340 [ttm] [ 402.178113] [<ffffffffa0061d47>] t...

...obably not an issue you're hitting. > diff --git a/drivers/gpu/drm/nouveau/nouveau_sgdma.c b/drivers/gpu/drm/nouveau/nouveau_sgdma.c > index ca5492a..494cf88 100644 > --- a/drivers/gpu/drm/nouveau/nouveau_sgdma.c > +++ b/drivers/gpu/drm/nouveau/nouveau_sgdma.c > @@ -31,7 +31,7 @@ nv04_sgdma_bind(struct ttm_tt *ttm, struct ttm_mem_reg *mem) > { > struct nouveau_sgdma_be *nvbe = (struct nouveau_sgdma_be *)ttm; > struct nouveau_mem *node = mem->mm_node; > - u64 size = mem->num_pages << 12; > + u64 size = mem->num_pages << PAGE_SHIFT; > > if (...

...gn(nvbo, flags, &align, &size); > diff --git a/drivers/gpu/drm/nouveau/nouveau_sgdma.c b/drivers/gpu/drm/nouveau/nouveau_sgdma.c > index 0843ebc..f255ff8 100644 > --- a/drivers/gpu/drm/nouveau/nouveau_sgdma.c > +++ b/drivers/gpu/drm/nouveau/nouveau_sgdma.c > @@ -31,7 +31,7 @@ nv04_sgdma_bind(struct ttm_tt *ttm, struct ttm_mem_reg *mem) > { > struct nouveau_sgdma_be *nvbe = (struct nouveau_sgdma_be *)ttm; > struct nouveau_mem *node = mem->mm_node; > - u64 size = mem->num_pages << 12; > + u64 size = mem->num_pages << PAGE_S...

...gt; > diff --git a/drivers/gpu/drm/nouveau/nouveau_sgdma.c b/drivers/gpu/drm/nouveau/nouveau_sgdma.c >> > index ca5492a..494cf88 100644 >> > --- a/drivers/gpu/drm/nouveau/nouveau_sgdma.c >> > +++ b/drivers/gpu/drm/nouveau/nouveau_sgdma.c >> > @@ -31,7 +31,7 @@ nv04_sgdma_bind(struct ttm_tt *ttm, struct ttm_mem_reg *mem) >> > { >> > struct nouveau_sgdma_be *nvbe = (struct nouveau_sgdma_be *)ttm; >> > struct nouveau_mem *node = mem->mm_node; >> > - u64 size = mem->num_pages << 12; >> > + u64 size = mem-...

https://bugs.freedesktop.org/show_bug.cgi?id=108857 Bug ID: 108857 Summary: display becomes unresponsive and keyboard input fails Product: xorg Version: unspecified Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW Severity: major Priority: medium Component: Driver/nouveau