search for: numericowner

Add new optional argument to copy-out: 'numericowner', 'excludes', 'xattrs', 'selinux', and 'acls'. Pass them straight to tar-out, so it is possible to tweak how the files are extracted from the guest, and locally saved. --- generator/actions.ml | 37 +++++++++++++++++++++++++++++++++++-- gobject/Makefile.inc |...

...(-) diff --git a/daemon/tar.c b/daemon/tar.c index d6f8f2f..68af749 100644 --- a/daemon/tar.c +++ b/daemon/tar.c @@ -311,7 +311,7 @@ make_exclude_from_file (char *const *excludes) /* Takes optional arguments, consult optargs_bitmask. */ int do_tar_out (const char *dir, const char *compress, int numericowner, - char *const *excludes) + char *const *excludes, int xattrs, int selinux) { CLEANUP_FREE char *buf = NULL; struct stat statbuf; @@ -349,6 +349,12 @@ do_tar_out (const char *dir, const char *compress, int numericowner, return -1; } + if (!(optargs_bitmask...

...arious optional arguments to the tar-in and tar-out commands. Firstly (1/7) an optional "compress" flag is added to select compression. This makes the calls tgz-in/tgz-out/txz-in/txz-out deprecated, and expands the range of compression types available. Secondly (2/7) we add an optional numericowner boolean to tar-out, which generates numeric UIDs/GIDs in the resulting tar file. The remaining patches allow us to encode the '--exclude=PATTERN' argument to tar. We add an OStringList type to the generator for passing optional lists of strings. Then we modify tar-out so that this can be...

...tyle = RErr, [Pathname "remotepath"; String "localdir"], []; > + style = RErr, [Pathname "remotepath"; String "localdir"], [OStringList "excludes"]; This change seems reasonable. Should we: (1) Bind other tar-out parameters? It looks as if numericowner, xattrs, selinux and acls would all be candidates. (2) More importantly for this patch, keep the order of the options compatible with tar-out? This would allow us to pass the optargs_bitmask straight through, if that's an advantage (it may not be). The 'compressed' optarg for tar-out...

Hi, this patch series does changes mostly in virt-dib, few bug fixes and a couple of new features (mostly implemented upstream already). In addition, one new API is added, and a new optional argument for an existing API is added (the latter is not needed, but could be useful anyway). Thanks, Pino Toscano (10): dib: fix listing envvars in fake-sudo dib: source dib "die" script in

...nt parse-environment-list rm-f rsync rsync-in rsync-out set-cachedir set-libvirt-supported-credentials set-libvirt-requested-credential set-tmpdir shutdown [backported to 1.16 and 1.18] tar-in [added compress flag] tar-out [added compress, numericowner, excludes flags] umount [added force and lazy optional arguments] utsname xfs-admin (Wanlong Gao) xfs-growfs (Wanlong Gao) xfs-info (Wanlong Gao) xfs-repair (Wanlong Gao) In the C API only: guestfs_push_error_handler guestfs_pop_error_handler Internal...

...xf - %s2> %s", + str_tar, dir, filter, chown_supported ? "" : "--no-same-owner ", error_file) == -1) { @@ -321,7 +324,8 @@ do_tar_out (const char *dir, const char *compress, int numericowner, } /* "tar -C /sysroot%s -cf - ." but we have to quote the dir. */ - if (asprintf_nowarn (&cmd, "tar -C %R%s%s%s -cf - .", + if (asprintf_nowarn (&cmd, "%s -C %R%s%s%s -cf - .", + str_tar, dir, filter,...

...r) == -1) { + err = errno; + r = cancel_receive (); + errno = err; + reply_with_perror ("asprintf"); + return -1; + } if (random_name (buf) == -1) { err = errno; r = cancel_receive (); @@ -332,7 +337,13 @@ do_tar_out (const char *dir, const char *compress, int numericowner, FILE *fp; CLEANUP_UNLINK_FREE char *exclude_from_file = NULL; CLEANUP_FREE char *cmd = NULL; - char buffer[GUESTFS_MAX_CHUNK_SIZE]; + CLEANUP_FREE char *buffer = NULL; + + buffer = malloc (GUESTFS_MAX_CHUNK_SIZE); + if (buffer == NULL) { + reply_with_perror ("malloc"); +...

...xf - %s2> %s", + str_tar, dir, filter, chown_supported ? "" : "--no-same-owner ", error_file) == -1) { @@ -321,7 +324,8 @@ do_tar_out (const char *dir, const char *compress, int numericowner, } /* "tar -C /sysroot%s -cf - ." but we have to quote the dir. */ - if (asprintf_nowarn (&cmd, "tar -C %R%s%s%s -cf - .", + if (asprintf_nowarn (&cmd, "%s -C %R%s%s%s -cf - .", + str_tar, dir, filter,...

..."tar", dir, filter, chown_supported ? "" : "--no-same-owner ", xattrs ? "--xattrs " : "", @@ -344,7 +342,7 @@ do_tar_out (const char *dir, const char *compress, int numericowner, /* "tar -C /sysroot%s -cf - ." but we have to quote the dir. */ if (asprintf_nowarn (&cmd, "%s -C %Q%s%s%s%s%s%s%s -cf - .", - str_tar, + "tar", buf, filter, numeri...

..."tar", dir, filter, chown_supported ? "" : "--no-same-owner ", xattrs ? "--xattrs " : "", @@ -344,7 +344,7 @@ do_tar_out (const char *dir, const char *compress, int numericowner, /* "tar -C /sysroot%s -cf - ." but we have to quote the dir. */ if (asprintf_nowarn (&cmd, "%s -C %Q%s%s%s%s%s%s%s -cf - .", - str_tar, + "tar", buf, filter, numeri...

Various changes/fixes to use smaller stack frames. Rich.

This is a simpler patch that removes GUESTFSD_EXT_CMD completely.

Replace GUESTFSD_EXT_CMD with a command line option ‘./guestfsd --print-external-commands’

...= true; tests = [ @@ -2871,7 +2871,7 @@ If set to true, POSIX ACLs are restored from the tar file. { defaults with name = "tar_out"; added = (1, 0, 3); - style = RErr, [String "directory"; FileOut "tarfile"], [OString "compress"; OBool "numericowner"; OStringList "excludes"; OBool "xattrs"; OBool "selinux"; OBool "acls"]; + style = RErr, [String (PlainString, "directory"); String (FileOut, "tarfile")], [OString "compress"; OBool "numericowner"; OStringList...

Very large but mechanical change to the generator. Rich.

This is a follow-up to the other generator changes in: https://www.redhat.com/archives/libguestfs/2017-February/msg00217.html Rich.

Split up the huge generator/actions.ml into several smaller files. Rich.

The existing mechanism was clunky, slow and used ~ 10 MB of local disk. Rich.