search for: numberofrelocations

...:vector as class members? The extra allocations can add up. 2. For the following bit: + reinterpret_cast <uint32_t &> (Section->Symbol->Aux [0]) = Section->Header.SizeOfRawData; + reinterpret_cast <uint16_t &> (Section->Symbol->Aux [4]) = Section->Header.NumberOfRelocations; + reinterpret_cast <uint16_t &> (Section->Symbol->Aux [6]) = Section->Header.PointerToLineNumbers; This isn't endian-safe; I'd suggest expanding it to 8 assignments. Same issues with the write_le functions. We need endian safety not only so that cross-compiling, for...

....h> Do you really need this? If so, please use <cstdio> + assert (Section->Symbol->Aux.size () == 15); + write_uint32_le(Section->Symbol->Aux.data() + 0, Section->Header.SizeOfRawData); + write_uint16_le(Section->Symbol->Aux.data() + 4, Section->Header.NumberOfRelocations); + write_uint16_le(Section->Symbol->Aux.data() + 6, Section->Header.PointerToLineNumbers); ... + void add_common_symbol(MCSymbol *Symbol, uint64_t Size, unsigned ByteAlignment, bool External); Please wrap to 80 columns. + for (coff::relocations::const_iterator k = (*i)->...

Here is a full patch including Nathan's COFF support, tests that pass on Windows, and some changes to lit. Obviously the COFF support and changes to lit should be separate patches in the end. http://codereview.appspot.com/1624043/show - Michael Spencer -------------- next part -------------- A non-text attachment was scrubbed... Name: COFF-support.patch Type: application/octet-stream Size:

Hi guys, I have attached my patch to support generating win32 COFF object files. I would have posted earlier, but my system drive crashed and I had to rebuild my system; Luckily, my source code was on a secondary drive. I think this would be a good beginning for ongoing support of the COFF object file format and was hoping for some feedback as to whether it was commit worthy or what was needed to

...please use <cstdio> > > > > + assert (Section->Symbol->Aux.size () == 15); > + write_uint32_le(Section->Symbol->Aux.data() + 0, Section- > >Header.SizeOfRawData); > + write_uint16_le(Section->Symbol->Aux.data() + 4, Section- > >Header.NumberOfRelocations); > + write_uint16_le(Section->Symbol->Aux.data() + 6, Section- > >Header.PointerToLineNumbers); > ... > + void add_common_symbol(MCSymbol *Symbol, uint64_t Size, > unsigned ByteAlignment, bool External); > > Please wrap to 80 columns. > > + for (...

I'm so close to having LLVM build on PowerPC. If there's any PowerPC experts, help? Lines like this: outs() << "[" << format("%2d", i) << "]" << "(sec " << format("%2d", int16_t(symbol->SectionNumber)) << ")" << "(fl 0x" <<

...ve for these types of cases. > > 2. For the following bit: > + reinterpret_cast <uint32_t &> (Section->Symbol->Aux [0]) = > Section->Header.SizeOfRawData; > + reinterpret_cast <uint16_t &> (Section->Symbol->Aux [4]) = > Section->Header.NumberOfRelocations; > + reinterpret_cast <uint16_t &> (Section->Symbol->Aux [6]) = > Section->Header.PointerToLineNumbers; > > This isn't endian-safe; I'd suggest expanding it to 8 assignments. > Same issues with the write_le functions. We need endian safety not > only...

...t;> >> >> >> + assert (Section->Symbol->Aux.size () == 15); >> + write_uint32_le(Section->Symbol->Aux.data() + 0, >> Section->Header.SizeOfRawData); >> + write_uint16_le(Section->Symbol->Aux.data() + 4, >> Section->Header.NumberOfRelocations); >> + write_uint16_le(Section->Symbol->Aux.data() + 6, >> Section->Header.PointerToLineNumbers); >> ... >> + void add_common_symbol(MCSymbol *Symbol, uint64_t Size, unsigned >> ByteAlignment, bool External); >> >> Please wrap to 80 columns....

...StorageClass: IMAGE_SYM_CLASS_STATIC - Name: .drectve Value: 0 SectionNumber: 1 SimpleType: IMAGE_SYM_TYPE_NULL ComplexType: IMAGE_SYM_DTYPE_NULL StorageClass: IMAGE_SYM_CLASS_STATIC SectionDefinition: Length: 47 NumberOfRelocations: 0 NumberOfLinenumbers: 0 CheckSum: 0 Number: 0 ... ``` There's a structure called coff::symbol which basically represents each one of these records. It looks like this: ``` struct symbol { char Name[NameSize]; uint32_t Value; int32_t SectionNumber;...

...; - Name: .drectve > Value: 0 > SectionNumber: 1 > SimpleType: IMAGE_SYM_TYPE_NULL > ComplexType: IMAGE_SYM_DTYPE_NULL > StorageClass: IMAGE_SYM_CLASS_STATIC > SectionDefinition: > Length: 47 > NumberOfRelocations: 0 > NumberOfLinenumbers: 0 > CheckSum: 0 > Number: 0 > ... > ``` > > There's a structure called coff::symbol which basically represents each > one of these records. It looks like this: > > ``` > struct symbol { > char Nam...

...>> Value: 0 >> SectionNumber: 1 >> SimpleType: IMAGE_SYM_TYPE_NULL >> ComplexType: IMAGE_SYM_DTYPE_NULL >> StorageClass: IMAGE_SYM_CLASS_STATIC >> SectionDefinition: >> Length: 47 >> NumberOfRelocations: 0 >> NumberOfLinenumbers: 0 >> CheckSum: 0 >> Number: 0 >> ... >> ``` >> >> There's a structure called coff::symbol which basically represents each >> one of these records. It looks like this: >> >>...

...0 >>> SectionNumber: 1 >>> SimpleType: IMAGE_SYM_TYPE_NULL >>> ComplexType: IMAGE_SYM_DTYPE_NULL >>> StorageClass: IMAGE_SYM_CLASS_STATIC >>> SectionDefinition: >>> Length: 47 >>> NumberOfRelocations: 0 >>> NumberOfLinenumbers: 0 >>> CheckSum: 0 >>> Number: 0 >>> ... >>> ``` >>> >>> There's a structure called coff::symbol which basically represents each >>> one of these records. It loo...

...tionNumber: 1 >>>> SimpleType: IMAGE_SYM_TYPE_NULL >>>> ComplexType: IMAGE_SYM_DTYPE_NULL >>>> StorageClass: IMAGE_SYM_CLASS_STATIC >>>> SectionDefinition: >>>> Length: 47 >>>> NumberOfRelocations: 0 >>>> NumberOfLinenumbers: 0 >>>> CheckSum: 0 >>>> Number: 0 >>>> ... >>>> ``` >>>> >>>> There's a structure called coff::symbol which basically represents each >>>&g...

...>>> SimpleType: IMAGE_SYM_TYPE_NULL >>>>> ComplexType: IMAGE_SYM_DTYPE_NULL >>>>> StorageClass: IMAGE_SYM_CLASS_STATIC >>>>> SectionDefinition: >>>>> Length: 47 >>>>> NumberOfRelocations: 0 >>>>> NumberOfLinenumbers: 0 >>>>> CheckSum: 0 >>>>> Number: 0 >>>>> ... >>>>> ``` >>>>> >>>>> There's a structure called coff::symbol which basically re...

...new section at the end of the file so I don't >>>>>>>> have to recalculate all sections (although now I probably could position it >>>>>>>> in the middle, knowing that each section is: SizeOfRawData + >>>>>>>> (last.Header.NumberOfRelocations * (4+4+2)) and the $H needs to >>>>>>>> come right after $T in the file). That although illegal based on the coff >>>>>>>> specs doesn't seem its going to influence lld. >>>>>>>> >>>>>>>> Also we tal...

Hi, I finally got my first .obj file patched with .debug$H to look somewhat right. I added the new section at the end of the file so I don't have to recalculate all sections (although now I probably could position it in the middle, knowing that each section is: SizeOfRawData + (last.Header.NumberOfRelocations * (4+4+2)) and the $H needs to come right after $T in the file). That although illegal based on the coff specs doesn't seem its going to influence lld. Also we talked and we are probably going to do something similar to a bunch of windows defines and a check for our own define (to guarantee th...

...ot my first .obj file patched with .debug$H to look somewhat > right. I added the new section at the end of the file so I don't have to > recalculate all sections (although now I probably could position it in the > middle, knowing that each section is: SizeOfRawData + > (last.Header.NumberOfRelocations * (4+4+2)) and the $H needs to come right > after $T in the file). That although illegal based on the coff specs > doesn't seem its going to influence lld. > > Also we talked and we are probably going to do something similar to a > bunch of windows defines and a check for our own...

...pleType: IMAGE_SYM_TYPE_NULL >>>>>> ComplexType: IMAGE_SYM_DTYPE_NULL >>>>>> StorageClass: IMAGE_SYM_CLASS_STATIC >>>>>> SectionDefinition: >>>>>> Length: 47 >>>>>> NumberOfRelocations: 0 >>>>>> NumberOfLinenumbers: 0 >>>>>> CheckSum: 0 >>>>>> Number: 0 >>>>>> ... >>>>>> ``` >>>>>> >>>>>> There's a structure called cof...

...irst .obj file patched with .debug$H to look somewhat >> right. I added the new section at the end of the file so I don't have to >> recalculate all sections (although now I probably could position it in the >> middle, knowing that each section is: SizeOfRawData + (last.Header.NumberOfRelocations >> * (4+4+2)) and the $H needs to come right after $T in the file). That >> although illegal based on the coff specs doesn't seem its going to >> influence lld. >> >> Also we talked and we are probably going to do something similar to a >> bunch of windows de...

...ith .debug$H to look somewhat >>>> right. I added the new section at the end of the file so I don't have to >>>> recalculate all sections (although now I probably could position it in the >>>> middle, knowing that each section is: SizeOfRawData + (last.Header.NumberOfRelocations >>>> * (4+4+2)) and the $H needs to come right after $T in the file). That >>>> although illegal based on the coff specs doesn't seem its going to >>>> influence lld. >>>> >>>> Also we talked and we are probably going to do something s...