search for: num_track

...the existing value of 'buffer' with null. That 'buffer' will > then never be free'd and result in a memory leak. Although I suspect Good point. Common lazy programer idiom. Will fix. > In oggplay.c there are checks like the following that do 'track >= > me->num_tracks' and at least one that does 'track > me->num_tracks'. I > think it should be '>' not '>=' in all cases, what do you think? Code I think it should be >= all the time. I'll check those out. > Check for NULL return from malloc needed here (the sa...

Hi, the attached patch adds rendering of Kate streams using libtiger. To do so, it adds a new type of RGBA video. One can request the incoming video (in YUV) to be sent in RGBA (ie, asking liboggplay to do the conversion in the first place). The large changes in the GLUT player also include fixes for crash-on-no-sound, mono sound, and locking fixes (I *think* - at least it works fine for me

...never be free'd and result in a memory leak. Although I suspect it'd crash anyway due to buffer being NULL when float_to_short_array is called: + buffer = realloc(buffer, size * sizeof (short) * channels); In oggplay.c there are checks like the following that do 'track >= me->num_tracks' and at least one that does 'track > me->num_tracks'. I think it should be '>' not '>=' in all cases, what do you think? Code following usually indexes into decode_data by the track number which is an error if the track == num_tracks I think. + if (track &...

There are two functions: static void vorbiscomment_entry_array_delete_(FLAC__StreamMetadata_VorbisComment_Entry *object_array, unsigned num_comments); and static void cuesheet_track_array_delete_(FLAC__StreamMetadata_CueSheet_Track *object_array, unsigned num_tracks); which first dereference object_array and only then check it for NULL: free(object_array[i].indices); ... ... if(0 != object_array) free(object_array); Currently the condition "if(0 != object_array)" is not necessary because libFL...