search for: num_sock

...nless that bind fails), but should bind to both. Even on Linux, a bind to ::1 does not include 127.0.0.1. I think this can be fixed with the following patch: --- channels-orig.c Tue Mar 26 04:26:25 2002 +++ channels.c Tue Apr 23 15:09:28 2002 @@ -2392,7 +2392,8 @@ if (num_socks == NUM_SOCKS) break; #else - break; + if (!x11_use_localhost || num_socks == NUM_SOCKS) + break; #endif } freeaddrinfo(aitop); Stig

...sizeof(on)) < 0) + debug("x11_create_display_inet: setsockopt(IPV6_V6ONLY) failed."); + } +#endif if (bind(sock, ai->ai_addr, ai->ai_addrlen) < 0) { debug("bind port %d: %.100s", port, strerror(errno)); close(sock); @@ -2374,7 +2381,12 @@ if (num_socks == NUM_SOCKS) break; #else - break; + if (x11_use_localhost) { + if (num_socks == NUM_SOCKS) + break; + } else { + break; + } #endif } freeaddrinfo(aitop); In article <Pine.HPX.4.44.0204301333550.2022-100000 at jenny> (at Tue, 30 Apr 2002 13:35:52 -0700 (PDT))...

...ote_hostname: getnameinfo NI_NUMERICHOST failed"); diff -ru openssh-1.2.2p1/channels.c openssh-1.2.2p1-20000308/channels.c --- openssh-1.2.2p1/channels.c Fri Mar 3 20:35:33 2000 +++ openssh-1.2.2p1-20000308/channels.c Wed Mar 8 00:25:18 2000 @@ -1215,8 +1215,12 @@ break; } socks[num_socks++] = sock; +#ifndef DONT_TRY_OTHER_AF if (num_socks == NUM_SOCKS) break; +#else + break; +#endif } if (num_socks > 0) break; diff -ru openssh-1.2.2p1/config.h.in openssh-1.2.2p1-20000308/config.h.in --- openssh-1.2.2p1/config.h.in Tue Mar 7 20:05:59 2000 +++ openssh-1.2.2p...

...n error occurs. */ -char * -x11_create_display_inet(int screen_number, int x11_display_offset) +int +x11_create_display_inet(int x11_display_offset, int gateway_ports) { int display_number, sock; u_short port; struct addrinfo hints, *ai, *aitop; char strport[NI_MAXSERV]; int gaierr, n, num_socks = 0, socks[NUM_SOCKS]; - char display[512]; - char hostname[MAXHOSTNAMELEN]; for (display_number = x11_display_offset; display_number < MAX_DISPLAYS; @@ -2416,12 +2414,12 @@ port = 6000 + display_number; memset(&hints, 0, sizeof(hints)); hints.ai_family = IPv4or6; - hint...

...lt;ylo at cs.hut.fi> * Copyright (c) 1995 Tatu Ylonen <ylo at cs.hut.fi>, Espoo, Finland *************** *** 2905,2913 **** debug2("bind port %d: %.100s", port, strerror(errno)); close(sock); - if (ai->ai_next) - continue; - for (n = 0; n < num_socks; n++) { close(socks[n]); } --- 2906,2911 ---- When those two lines are added back in, X11 forwarding is able to get a port bound. This is only the case on Solaris. On Linux, *BSD, IRIX systems the current code works. Thanks for looking into this. Pieter

I have been experiencing a problem with using X11 forwarding on an IPv6 enabled host (both CentOS 4.3 and Feddora Core 5 in x86) when X11UseLocalhost is off. Having looked at the code and the previous discussion regarding http://bugzilla.mindrot.org/show_bug.cgi?id=164 I think the problem is due to the IPV6_V6ONLY code interacting poorly with the DONT_TRY_OTHER_AF hack. Basically, on current

On Mon, Jul 23, 2001 at 12:49:14AM +0100, Matthew Vernon wrote: > ------- start of forwarded message ------- > From: <mouring at etoh.eviladmin.org> > To: Matthew Vernon <matthew at empire.ucam.org> > cc: <openssh-unix-dev at mindrot.org> > Subject: Re: [patch] GNU/Hurd compatibility patches > Date: Sun, 22 Jul 2001 12:39:32 -0500 (CDT) > > > We

...rdup(name); + return name; } /* diff -Nur openssh-2.2.0p1-/channels.c openssh-2.2.0p1/channels.c --- openssh-2.2.0p1-/channels.c Sun Oct 29 16:17:49 2000 +++ openssh-2.2.0p1/channels.c Sun Oct 29 16:44:49 2000 @@ -1720,7 +1720,7 @@ char strport[NI_MAXSERV]; int gaierr, n, num_socks = 0, socks[NUM_SOCKS]; char display[512]; - char hostname[MAXHOSTNAMELEN]; + char hostname[401]; /* we only use the first 400 bytes anyway*/ for (display_number = x11_display_offset; display_number < MAX_DISPLAYS; @@ -1791,7 +1791,8 @@ /*...

...debug2("bind port %d: %.100s", port, strerror(errno)); close(sock); - if( loc_errno == EADDRNOTAVAIL && ai->ai_next ) - continue; - for (n = 0; n < num_socks; n++) { close(socks[n]); } You have new mail in /var/spool/mail/sellswor sellswor at sethe:~/tmp/2/openssh-5.5p1> Thoughts? Am I approaching this wrong, and this shows a mis-configured machine? ( happens on multiple machi...

...debug2("bind port %d: %.100s", port, strerror(errno)); close(sock); + if (ai->ai_next) + continue; + for (n = 0; n < num_socks; n++) { close(socks[n]); } This restores a piece of code that was there in an older release (got it from 4.7p1 actually) Comparing similar code for general port forwarding binds, this code now behaves like that; ie: works on...

...400s:%d.%d", + he->h_name, display_number, screen_number); + else + #endif + snprintf(display, sizeof(display), "%.50s:%d.%d", + inet_ntoa(me.sin_addr), display_number, screen_number); + } + #endif + /* Allocate a channel for each socket. */ for (n = 0; n < num_socks; n++) { sock = socks[n]; *** session.c.orig Sun Feb 18 20:13:34 2001 --- session.c Wed Feb 21 11:39:06 2001 *************** *** 1361,1366 **** --- 1361,1369 ---- "Running %.100s add %.100s %.100s %.100s\n", options.xauth_location, display, auth_proto,...

Hi! Here is the patch to support tcp wrappers with x11-forwarded connections. The patch is for openssh-3.0.1p1 but it works fine with 2.9.9p2 too. I've understood that this will not be included in the official version because it adds complexity (?!) to openssh. Binding the forwarded port to localhost doesn't solve all problems. I've understood that you should also implement

...isplays = max_displays + x11_display_offset; + for (display_number = x11_display_offset; - display_number < MAX_DISPLAYS; + display_number < max_displays; display_number++) { port = 6000 + display_number; memset(&hints, 0, sizeof(hints)); @@ -3957,7 +3958,7 @@ if (num_socks > 0) break; } - if (display_number >= MAX_DISPLAYS) { + if (display_number >= max_displays) { error("Failed to allocate internet-domain X11 display socket."); return -1; } diff -Naur openssh-portable/channels.h openssh-portable-maxdisplays/channels.h --- openssh-po...

...ll_opens_permitted = 0; +#endif - +#ifdef WITH_X11FWD /* -- X11 forwarding */ /* Maximum number of fake X11 displays to try. */ @@ -122,8 +123,9 @@ */ static char *x11_fake_data = NULL; static u_int x11_fake_data_len; +#endif - +#ifdef WITH_AGENTFWD /* -- agent forwarding */ #define NUM_SOCKS 10 @@ -131,12 +133,15 @@ /* Name and directory of socket for authentication agent forwarding. */ static char *auth_sock_name = NULL; static char *auth_sock_dir = NULL; +#endif /* AF_UNSPEC or AF_INET or AF_INET6 */ static int IPv4or6 = AF_UNSPEC; +#ifdef WITH_TCPFWD /* helper */ static...