search for: num_connector

...drm/bochs/bochs_kms.c index cc93ff74fbd8..3a755c911342 100644 --- a/drivers/gpu/drm/bochs/bochs_kms.c +++ b/drivers/gpu/drm/bochs/bochs_kms.c @@ -164,6 +164,9 @@ int bochs_kms_init(struct bochs_device *bochs) void bochs_kms_fini(struct bochs_device *bochs) { + if (!bochs->dev->mode_config.num_connector) + return; + drm_atomic_helper_shutdown(bochs->dev); drm_mode_config_cleanup(bochs->dev); } -- 2.18.1

...> + struct drm_connector *conn; > + struct drm_crtc_state *crtc_state; > + int i; > + > + for_each_new_connector_in_state(pstate->state, conn, conn_state, i) { > + if (conn_state->crtc == pstate->crtc) > + break; > + } > + > + if (i == pstate->state->num_connector) > + return 0; > + > + if (conn_state->underscan.mode != DRM_UNDERSCAN_ON) > + return 0; > + > + crtc_state = drm_atomic_get_new_crtc_state(pstate->state, > + pstate->crtc); > + > + if (conn_state->underscan.hborder >= crtc_state->mode.hdisplay...

...(ret) + return ret; bochs->dev->mode_config.max_width = 8192; bochs->dev->mode_config.max_height = 8192; @@ -160,11 +164,3 @@ int bochs_kms_init(struct bochs_device *bochs) return 0; } - -void bochs_kms_fini(struct bochs_device *bochs) -{ - if (!bochs->dev->mode_config.num_connector) - return; - - drm_mode_config_cleanup(bochs->dev); -} -- 2.24.1

...t; > > + int i; > > > + > > > + for_each_new_connector_in_state(pstate->state, conn, conn_state, i) { > > > + if (conn_state->crtc == pstate->crtc) > > > + break; > > > + } > > > + > > > + if (i == pstate->state->num_connector) > > > + return 0; > > > + > > > + if (conn_state->underscan.mode != DRM_UNDERSCAN_ON) > > > + return 0; > > > + > > > + crtc_state = drm_atomic_get_new_crtc_state(pstate->state, > > > + pstate->crtc); > > >...

...gt; + for_each_new_connector_in_state(pstate->state, conn, conn_state, i) { > > > > > + if (conn_state->crtc == pstate->crtc) > > > > > + break; > > > > > + } > > > > > + > > > > > + if (i == pstate->state->num_connector) > > > > > + return 0; > > > > > + > > > > > + if (conn_state->underscan.mode != DRM_UNDERSCAN_ON) > > > > > + return 0; > > > > > + > > > > > + crtc_state = drm_atomic_get_new_crtc_state(pstate->state...

...; + struct drm_connector_state *conn_state = NULL; + struct drm_connector *conn; + struct drm_crtc_state *crtc_state; + int i; + + for_each_new_connector_in_state(pstate->state, conn, conn_state, i) { + if (conn_state->crtc == pstate->crtc) + break; + } + + if (i == pstate->state->num_connector) + return 0; + + if (conn_state->underscan.mode != DRM_UNDERSCAN_ON) + return 0; + + crtc_state = drm_atomic_get_new_crtc_state(pstate->state, + pstate->crtc); + + if (conn_state->underscan.hborder >= crtc_state->mode.hdisplay || + conn_state->underscan.vborder &g...

...(ret) + return ret; bochs->dev->mode_config.max_width = 8192; bochs->dev->mode_config.max_height = 8192; @@ -160,11 +164,3 @@ int bochs_kms_init(struct bochs_device *bochs) return 0; } - -void bochs_kms_fini(struct bochs_device *bochs) -{ - if (!bochs->dev->mode_config.num_connector) - return; - - drm_mode_config_cleanup(bochs->dev); -} -- 2.24.1

...+ struct drm_crtc_state *crtc_state; > > + int i; > > + > > + for_each_new_connector_in_state(pstate->state, conn, conn_state, i) { > > + if (conn_state->crtc == pstate->crtc) > > + break; > > + } > > + > > + if (i == pstate->state->num_connector) > > + return 0; > > + > > + if (conn_state->underscan.mode != DRM_UNDERSCAN_ON) > > + return 0; > > + > > + crtc_state = drm_atomic_get_new_crtc_state(pstate->state, > > + pstate->crtc); > > + > > + if (conn_state->undersc...

...tate, conn, conn_state, i) { > > > > > > > + if (conn_state->crtc == pstate->crtc) > > > > > > > + break; > > > > > > > + } > > > > > > > + > > > > > > > + if (i == pstate->state->num_connector) > > > > > > > + return 0; > > > > > > > + > > > > > > > + if (conn_state->underscan.mode != DRM_UNDERSCAN_ON) > > > > > > > + return 0; > > > > > > > + > > > > > > > +...

...; > + > > > > + for_each_new_connector_in_state(pstate->state, conn, conn_state, i) { > > > > + if (conn_state->crtc == pstate->crtc) > > > > + break; > > > > + } > > > > + > > > > + if (i == pstate->state->num_connector) > > > > + return 0; > > > > + > > > > + if (conn_state->underscan.mode != DRM_UNDERSCAN_ON) > > > > + return 0; > > > > + > > > > + crtc_state = drm_atomic_get_new_crtc_state(pstate->state, > > > > +...

...or without the bikeshed (but pls remove the double space because ocd): Reviewed-by: Daniel Vetter <daniel.vetter at ffwll.ch> Cheers, Daniel > + * states. > + */ > + bool duplicated : 1; > struct __drm_planes_state *planes; > struct __drm_crtcs_state *crtcs; > int num_connector; > -- > 2.20.1 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

...tor_in_state(pstate->state, conn, conn_state, i) { > > > > > > + if (conn_state->crtc == pstate->crtc) > > > > > > + break; > > > > > > + } > > > > > > + > > > > > > + if (i == pstate->state->num_connector) > > > > > > + return 0; > > > > > > + > > > > > > + if (conn_state->underscan.mode != DRM_UNDERSCAN_ON) > > > > > > + return 0; > > > > > > + > > > > > > + crtc_state = drm_atomic_get_n...

...truct drm_plane *plane, struct drm_crtc *crtc, > .x2 = crtc_x + crtc_w, > .y2 = crtc_y + crtc_h, > }; > - const struct drm_rect clip = { > - .x2 = crtc->mode.hdisplay, > - .y2 = crtc->mode.vdisplay, > - }; > struct drm_connector **connector_list; > int num_connectors, ret; > bool visible; > > ret = drm_plane_helper_check_update(plane, crtc, fb, > - &src, &dest, &clip, > + &src, &dest, > DRM_MODE_ROTATE_0, > DRM_PLANE_HELPER_NO_SCALING, > DRM_PLANE_HELPER_NO_SCALING,...

Hello, This is an attempt at providing generic support for underscan connector props. We already have 3 drivers defining the same underscan, underscan vborder and underscan hborder properties (amd, radeon and nouveau) and I am about to add a new one, hence my proposal to put the prop parsing code in the core and add ->underscan fields to drm_connector_state. In this v2, I also converted the

...not this atomic state was duplicated using + * drm_atomic_helper_duplicate_state(). Drivers and atomic helpers + * should use this to fixup normal inconsistencies in duplicated + * states. + */ + bool duplicated : 1; struct __drm_planes_state *planes; struct __drm_crtcs_state *crtcs; int num_connector; -- 2.20.1

...not this atomic state was duplicated using + * drm_atomic_helper_duplicate_state(). Drivers and atomic helpers + * should use this to fixup normal inconsistencies in duplicated + * states. + */ + bool duplicated : 1; struct __drm_planes_state *planes; struct __drm_crtcs_state *crtcs; int num_connector; -- 2.20.1

On Fri, 2018-09-21 at 11:27 +0200, Daniel Vetter wrote: > On Tue, Sep 18, 2018 at 07:06:19PM -0400, Lyude Paul wrote: > > Currently we set intel_connector->mst_port to NULL to signify that the > > MST port has been removed from the system so that we can prevent further > > action on the port such as connector probes, mode probing, etc. > > However, we're going to

...ause > ocd): > > Reviewed-by: Daniel Vetter <daniel.vetter at ffwll.ch> > > Cheers, Daniel > > > + * states. > > + */ > > + bool duplicated : 1; > > struct __drm_planes_state *planes; > > struct __drm_crtcs_state *crtcs; > > int num_connector; > > -- > > 2.20.1 > > -- Cheers, Lyude Paul

This fixes the extra issues I discovered upstream after the introduction of my rework of the atomic VCPI helpers that occur during suspend/resume. This time around, we use a slightly different but much less complicated approach for fixing said issues. Cc: Daniel Vetter <daniel at ffwll.ch> Lyude Paul (4): drm/dp_mst: Fix unbalanced malloc ref in drm_dp_mst_deallocate_vcpi()

This fixes the extra issues I discovered upstream after the introduction of my rework of the atomic VCPI helpers that occur during suspend/resume. This time around, we use a slightly different but much less complicated approach for fixing said issues. Cc: Daniel Vetter <daniel at ffwll.ch> Lyude Paul (4): drm/dp_mst: Fix unbalanced malloc ref in drm_dp_mst_deallocate_vcpi()