Displaying 15 results from an estimated 15 matches for "nr_virtio_feature_words".
2014 Nov 27
1
[PATCH RFC v4 03/16] virtio: support more feature bits
...;
> > Signed-off-by: Cornelia Huck <cornelia.huck at de.ibm.com>
> > @@ -117,7 +125,7 @@ struct VirtIODevice
> > uint8_t status;
> > uint8_t isr;
> > uint16_t queue_sel;
> > - uint32_t guest_features;
> > + uint32_t guest_features[NR_VIRTIO_FEATURE_WORDS];
> > size_t config_len;
> > void *config;
> > uint16_t config_vector;
>
> Ugh.
>
> That's quite tricky to use correctly.
> Why don't we just make it uint64_t?
...and another one was that at least virtio-ccw reads/writes in chunks
of 32 bit...
2014 Nov 27
1
[PATCH RFC v4 03/16] virtio: support more feature bits
...;
> > Signed-off-by: Cornelia Huck <cornelia.huck at de.ibm.com>
> > @@ -117,7 +125,7 @@ struct VirtIODevice
> > uint8_t status;
> > uint8_t isr;
> > uint16_t queue_sel;
> > - uint32_t guest_features;
> > + uint32_t guest_features[NR_VIRTIO_FEATURE_WORDS];
> > size_t config_len;
> > void *config;
> > uint16_t config_vector;
>
> Ugh.
>
> That's quite tricky to use correctly.
> Why don't we just make it uint64_t?
...and another one was that at least virtio-ccw reads/writes in chunks
of 32 bit...
2014 Nov 27
0
[PATCH RFC v4 03/16] virtio: support more feature bits
...<thuth at linux.vnet.ibm.com>
> Signed-off-by: Cornelia Huck <cornelia.huck at de.ibm.com>
> @@ -117,7 +125,7 @@ struct VirtIODevice
> uint8_t status;
> uint8_t isr;
> uint16_t queue_sel;
> - uint32_t guest_features;
> + uint32_t guest_features[NR_VIRTIO_FEATURE_WORDS];
> size_t config_len;
> void *config;
> uint16_t config_vector;
Ugh.
That's quite tricky to use correctly.
Why don't we just make it uint64_t?
The only real issue is that DEFINE_PROP_BIT wants
a uint32_t.
But that's easy to fix: add DEFINE_PROP64_BIT
that is...
2014 Nov 27
1
[PATCH RFC v4 03/16] virtio: support more feature bits
...32
+
+/* The highest feature bit that we support */
+#define VIRTIO_HIGHEST_FEATURE_BIT 32
+
/* from Linux's linux/virtio_ring.h */
/* This marks a buffer as continuing via the next field. */
@@ -110,6 +116,8 @@ enum virtio_device_endian {
VIRTIO_DEVICE_ENDIAN_BIG,
};
+#define NR_VIRTIO_FEATURE_WORDS ((VIRTIO_HIGHEST_FEATURE_BIT + 32) / 32)
+
struct VirtIODevice
{
DeviceState parent_obj;
@@ -117,7 +125,7 @@ struct VirtIODevice
uint8_t status;
uint8_t isr;
uint16_t queue_sel;
- uint32_t guest_features;
+ uint32_t guest_features[NR_VIRTIO_FEATURE_WORDS];
size_t co...
2014 Nov 27
1
[PATCH RFC v4 03/16] virtio: support more feature bits
...32
+
+/* The highest feature bit that we support */
+#define VIRTIO_HIGHEST_FEATURE_BIT 32
+
/* from Linux's linux/virtio_ring.h */
/* This marks a buffer as continuing via the next field. */
@@ -110,6 +116,8 @@ enum virtio_device_endian {
VIRTIO_DEVICE_ENDIAN_BIG,
};
+#define NR_VIRTIO_FEATURE_WORDS ((VIRTIO_HIGHEST_FEATURE_BIT + 32) / 32)
+
struct VirtIODevice
{
DeviceState parent_obj;
@@ -117,7 +125,7 @@ struct VirtIODevice
uint8_t status;
uint8_t isr;
uint16_t queue_sel;
- uint32_t guest_features;
+ uint32_t guest_features[NR_VIRTIO_FEATURE_WORDS];
size_t co...
2014 Oct 07
1
[PATCH RFC 03/11] virtio: support more feature bits
...32
+
+/* The highest feature bit that we support */
+#define VIRTIO_HIGHEST_FEATURE_BIT 32
+
/* from Linux's linux/virtio_ring.h */
/* This marks a buffer as continuing via the next field. */
@@ -110,6 +116,8 @@ enum virtio_device_endian {
VIRTIO_DEVICE_ENDIAN_BIG,
};
+#define NR_VIRTIO_FEATURE_WORDS ((VIRTIO_HIGHEST_FEATURE_BIT + 32) / 32)
+
struct VirtIODevice
{
DeviceState parent_obj;
@@ -117,7 +125,7 @@ struct VirtIODevice
uint8_t status;
uint8_t isr;
uint16_t queue_sel;
- uint32_t guest_features;
+ uint32_t guest_features[NR_VIRTIO_FEATURE_WORDS];
size_t co...
2014 Oct 07
1
[PATCH RFC 03/11] virtio: support more feature bits
...32
+
+/* The highest feature bit that we support */
+#define VIRTIO_HIGHEST_FEATURE_BIT 32
+
/* from Linux's linux/virtio_ring.h */
/* This marks a buffer as continuing via the next field. */
@@ -110,6 +116,8 @@ enum virtio_device_endian {
VIRTIO_DEVICE_ENDIAN_BIG,
};
+#define NR_VIRTIO_FEATURE_WORDS ((VIRTIO_HIGHEST_FEATURE_BIT + 32) / 32)
+
struct VirtIODevice
{
DeviceState parent_obj;
@@ -117,7 +125,7 @@ struct VirtIODevice
uint8_t status;
uint8_t isr;
uint16_t queue_sel;
- uint32_t guest_features;
+ uint32_t guest_features[NR_VIRTIO_FEATURE_WORDS];
size_t co...
2014 Nov 27
22
[PATCH RFC v4 00/16] qemu: towards virtio-1 host support
Yet another version of the virtio-1 support patches.
This one has seen some (very) light testing with the virtio-1 guest
support patches currently on vhost-next.
Changes from v3:
- Add support for FEATURES_OK. We refuse to set features after the
driver has set this in the status field, and we allow to fail
setting the status if the features are inconsistent.
- Add missing virtio-1 changes
2014 Nov 27
22
[PATCH RFC v4 00/16] qemu: towards virtio-1 host support
Yet another version of the virtio-1 support patches.
This one has seen some (very) light testing with the virtio-1 guest
support patches currently on vhost-next.
Changes from v3:
- Add support for FEATURES_OK. We refuse to set features after the
driver has set this in the status field, and we allow to fail
setting the status if the features are inconsistent.
- Add missing virtio-1 changes
2014 Nov 25
15
[PATCH RFC v2 00/12] qemu: towards virtio-1 host support
Hi,
here's the next version of my virtio-1 qemu patchset. Using virtio-1
virtio-blk and virtio-net devices with a guest kernel built from
<1416829787-14252-1-git-send-email-mst at redhat.com> still seems to
work for the virtio-ccw transport.
Changes from v1:
- rebased against current master
- don't advertise VERSION_1 for all devices, make devices switch it on
individually
2014 Nov 25
15
[PATCH RFC v2 00/12] qemu: towards virtio-1 host support
Hi,
here's the next version of my virtio-1 qemu patchset. Using virtio-1
virtio-blk and virtio-net devices with a guest kernel built from
<1416829787-14252-1-git-send-email-mst at redhat.com> still seems to
work for the virtio-ccw transport.
Changes from v1:
- rebased against current master
- don't advertise VERSION_1 for all devices, make devices switch it on
individually
2014 Nov 26
15
[PATCH RFC v3 00/12] qemu: towards virtio-1 host support
Next version of virtio-1 patches for qemu.
Only change from v2 is splitting out the vring accessors into a
separate header file - should hopefully fix the build issues.
Cornelia Huck (9):
virtio: cull virtio_bus_set_vdev_features
virtio: support more feature bits
s390x/virtio-ccw: fix check for WRITE_FEAT
virtio: introduce legacy virtio devices
virtio: allow virtio-1 queue layout
2014 Nov 26
15
[PATCH RFC v3 00/12] qemu: towards virtio-1 host support
Next version of virtio-1 patches for qemu.
Only change from v2 is splitting out the vring accessors into a
separate header file - should hopefully fix the build issues.
Cornelia Huck (9):
virtio: cull virtio_bus_set_vdev_features
virtio: support more feature bits
s390x/virtio-ccw: fix check for WRITE_FEAT
virtio: introduce legacy virtio devices
virtio: allow virtio-1 queue layout
2014 Oct 07
18
[PATCH RFC 00/11] qemu: towards virtio-1 host support
This patchset aims to get us some way to implement virtio-1 compliant
and transitional devices in qemu. Branch available at
git://github.com/cohuck/qemu virtio-1
I've mainly focused on:
- endianness handling
- extended feature bits
- virtio-ccw new/changed commands
Thanks go to Thomas for some preliminary work in this area.
I've been able to start guests both with and without the
2014 Oct 07
18
[PATCH RFC 00/11] qemu: towards virtio-1 host support
This patchset aims to get us some way to implement virtio-1 compliant
and transitional devices in qemu. Branch available at
git://github.com/cohuck/qemu virtio-1
I've mainly focused on:
- endianness handling
- extended feature bits
- virtio-ccw new/changed commands
Thanks go to Thomas for some preliminary work in this area.
I've been able to start guests both with and without the