search for: nr_server

Note this patch requires a non-upstream qemu patch that I've been experimenting with. See qemu-devel list. Rich.

On Tuesday 11 March 2014 23:13:46 Richard W.M. Jones wrote: > diff --git a/src/drives.c b/src/drives.c > index 2c85b52..68e37f7 100644 > --- a/src/drives.c > +++ b/src/drives.c > @@ -115,7 +115,8 @@ static struct drive * > create_drive_file (guestfs_h *g, const char *path, > bool readonly, const char *format, > const char *iface,

This series improves ceph rbd support in libguestfs. It uses the servers list, adds support for a custom username, and starts to add support for custom secret.

These patches contain the beginnings of discard (a.k.a. trim or unmap) support. This will allow us to change virt-sparsify to work on disk images in-place (instead of using slow & inefficient copying). The approach used is to add an optional 'discard' parameter to add-drive. It has 3 possible settings: - 'disable' : the default, no discard is done - 'besteffort' :

..._data *data) { + if (data->query != NULL && + data->protocol != drive_protocol_http && + data->protocol != drive_protocol_https) { + error (g, _("curl: you cannot specify a query string with this protocol")); + return NULL; + } + if (data->nr_servers != 1) { error (g, _("curl: you must specify exactly one server")); return NULL; @@ -207,6 +216,10 @@ create_drive_gluster (guestfs_h *g, error (g, _("gluster: you cannot specify a secret with this protocol")); return NULL; } + if (data->query != NULL)...

v1 -> v2: - Rebase on top of Pino's version work. Two patches went upstream, these are the two remaining patches. Note the generation number is still inside the qemu.stat file. We could put it in the filename, I have no particular preference. Rich.

QEMU upstream has broken snapshot=on ... again. These two patches stop using it entirely. Instead we run 'qemu-img create' to create overlay disks as required. Note that the libvirt and UML backends were already doing this: The libvirt backend because <transient/> has never worked, and the UML backend was running uml_mkcow because the UML-equivalent syntax of snapshot=on was

...- if (data.format && !valid_format_iface (data.format)) { + if (data.format && !VALID_FORMAT_IFACE (data.format)) { error (g, _("%s parameter is empty or contains disallowed characters"), "format"); free_drive_servers (data.servers, data.nr_servers); return -1; } - if (data.iface && !valid_format_iface (data.iface)) { + if (data.iface && !VALID_FORMAT_IFACE (data.iface)) { error (g, _("%s parameter is empty or contains disallowed characters"), "iface"); free_drive_servers (d...

Doing qemu feature detection in the direct backend takes ~100ms because we need to run `qemu -help' and `qemu -devices ?', and each of those interacts with glibc's very slow link loader. Fixing the link loader is really hard. Instead memoize the output of those two commands. This patch series first separates all the code dealing with qemu into a separate module (src/qemu.c) and

Miscellaneous fixes to: - Handling of Ceph drives now works end-to-end (RHBZ#1026688). - In particular, you can now use rbd:/// URIs in guestfish (and they work). - Parse Ceph & NBD network drives from libvirt XML correctly, so that existing domains with Ceph/NBD drives can be added (eg. using guestfish -d option). - Add more testing of the above.

As discussed in the thread on validating $TERM, it would be good to have a common function to do this. This is such a function. The main advantage is it includes unit tests which the previous functions did not. Rich.

Hi All, Here's the latest patch. I think this should address the problem. The query string is now only appended to the end of a URI in the HTTP and HTTPS cases. The add-uri test now passes, and 'make check' still passes. -- Gabriel

This still isn't working at the moment. See: http://marc.info/?t=139457409300003&r=1&w=2 This set of patches: - Adds new APIs to support discard in libguestfs. - Adds discard support to virt-format. - Adds discard support to virt-sysprep. - Implements virt-sparsify --in-place. Rich.

...c @@ -200,11 +200,6 @@ static struct drive * create_drive_curl (guestfs_h *g, const struct drive_create_data *data) { - if (data->secret != NULL) { - error (g, _("curl: you cannot specify a secret with this protocol")); - return NULL; - } - if (data->nr_servers != 1) { error (g, _("curl: you must specify exactly one server")); return NULL; @@ -371,11 +366,6 @@ static struct drive * create_drive_ssh (guestfs_h *g, const struct drive_create_data *data) { - if (data->secret != NULL) { - error (g, _("ssh:...

Move the creation of iscsi URIs away from make_uri, composing them manually: this is needed because libxml assumes colons (':') to separate user and password for the authority part, while with iscsi URIs the separator is percentage ('%'), which would be percent-encoded by libxml. --- src/launch-direct.c | 31 ++++++++++++++++++++++++++++--- 1 file changed, 28 insertions(+), 3

...optargs->bitmask & GUESTFS_ADD_DRIVE_OPTS_BLOCKSIZE_BITMASK + ? optargs->blocksize : 0; + if (data.readonly && data.discard == discard_enable) { error (g, _("discard support cannot be enabled on read-only drives")); free_drive_servers (data.servers, data.nr_servers); @@ -796,6 +821,11 @@ guestfs_impl_add_drive_opts (guestfs_h *g, const char *filename, free_drive_servers (data.servers, data.nr_servers); return -1; } + if (data.blocksize && !valid_blocksize (data.blocksize)) { + error (g, _("%s parameter is invalid"), "b...

...optargs->bitmask & GUESTFS_ADD_DRIVE_OPTS_BLOCKSIZE_BITMASK + ? optargs->blocksize : 0; + if (data.readonly && data.discard == discard_enable) { error (g, _("discard support cannot be enabled on read-only drives")); free_drive_servers (data.servers, data.nr_servers); @@ -796,6 +821,11 @@ guestfs_impl_add_drive_opts (guestfs_h *g, const char *filename, free_drive_servers (data.servers, data.nr_servers); return -1; } + if (!valid_blocksize (data.blocksize)) { + error (g, _("%s parameter is invalid"), "blocksize"); + free...

Although the commit message ties this to https://bugzilla.redhat.com/1804207, in fact I believe this commit could be applied independently. It's a simple optimization. Rich.

...(data->username != NULL) { + error (g, _("spdk: you cannot specify a username with this protocol")); + return NULL; + } + if (data->secret != NULL) { + error (g, _("spdk: you cannot specify a secret with this protocol")); + return NULL; + } + + if (data->nr_servers != 1) { + error (g, _("spdk: you must specify exactly one server")); + return NULL; + } + + if (data->servers[0].transport != drive_transport_unix) { + error (g, _("spdk: only unix transport is supported")); + return NULL; + } + + return create_drive_non_file...

...GUESTFS_ADD_DRIVE_OPTS_LBLOCKSIZE_BITMASK > + ? optargs->lblocksize : 0; > + > if (data.readonly && data.discard == discard_enable) { > error (g, _("discard support cannot be enabled on read-only drives")); > free_drive_servers (data.servers, data.nr_servers); > diff --git a/lib/guestfs-internal.h b/lib/guestfs-internal.h > index 6799c265d..20f22a674 100644 > --- a/lib/guestfs-internal.h > +++ b/lib/guestfs-internal.h > @@ -261,6 +261,8 @@ struct drive { > char *cachemode; > enum discard discard; > bool copyonread; &gt...