search for: nr_chunks

...irst + * chunk before offset. + */ + end = offset + count; + start_sector = + ROUND_DOWN (offset, VIXDISKLIB_MIN_CHUNK_SIZE * VIXDISKLIB_SECTOR_SIZE) + / VIXDISKLIB_SECTOR_SIZE; + while (start_sector * VIXDISKLIB_SECTOR_SIZE < end) { + VixError err; + uint32_t i; + uint64_t nr_chunks, nr_sectors; + VixDiskLibBlockList *block_list; + + assert (IS_ALIGNED (start_sector, VIXDISKLIB_MIN_CHUNK_SIZE)); + + nr_chunks = + ROUND_UP (end - start_sector * VIXDISKLIB_SECTOR_SIZE, + VIXDISKLIB_MIN_CHUNK_SIZE * VIXDISKLIB_SECTOR_SIZE) + / (VIXDISKLIB_MIN_CHU...

...his: #define CHUNK_TO_MISCQ_MSG(chunk) (chunk - sizeof(struct virtio_balloon_miscq_hdr)) switch (type) { case PAGE_CHUNK_TYPE_BALLOON: msg_buf = vb->balloon_page_chunk_hdr; msg_len = sizeof(struct virtio_balloon_page_chunk_hdr) + nr_chunks * sizeof(struct virtio_balloon_page_chunk_entry); break; case PAGE_CHUNK_TYPE_UNUSED: msg_buf = CHUNK_TO_MISCQ_MSG(vb->unused_page_chunk_hdr); msg_len = sizeof(struct virtio_balloon_miscq_hdr) + sizeof(struct virtio_balloon_page_chunk_...

...hunk) (chunk - sizeof(struct > virtio_balloon_miscq_hdr)) > > switch (type) { > case PAGE_CHUNK_TYPE_BALLOON: > msg_buf = vb->balloon_page_chunk_hdr; > msg_len = sizeof(struct virtio_balloon_page_chunk_hdr) + > nr_chunks * sizeof(struct virtio_balloon_page_chunk_entry); > break; > case PAGE_CHUNK_TYPE_UNUSED: > msg_buf = CHUNK_TO_MISCQ_MSG(vb->unused_page_chunk_hdr); > msg_len = sizeof(struct virtio_balloon_miscq_hdr) + sizeof(struct > vi...

...hunk) (chunk - sizeof(struct > virtio_balloon_miscq_hdr)) > > switch (type) { > case PAGE_CHUNK_TYPE_BALLOON: > msg_buf = vb->balloon_page_chunk_hdr; > msg_len = sizeof(struct virtio_balloon_page_chunk_hdr) + > nr_chunks * sizeof(struct virtio_balloon_page_chunk_entry); > break; > case PAGE_CHUNK_TYPE_UNUSED: > msg_buf = CHUNK_TO_MISCQ_MSG(vb->unused_page_chunk_hdr); > msg_len = sizeof(struct virtio_balloon_miscq_hdr) + sizeof(struct > vi...

On Fri, Apr 14, 2017 at 04:37:52PM +0800, Wei Wang wrote: > On 04/14/2017 12:34 AM, Michael S. Tsirkin wrote: > > On Thu, Apr 13, 2017 at 05:35:05PM +0800, Wei Wang wrote: > > > > So we don't need the bitmap to talk to host, it is just > > a data structure we chose to maintain lists of pages, right? > Right. bitmap is the way to gather pages to chunk. >

On Fri, Apr 14, 2017 at 04:37:52PM +0800, Wei Wang wrote: > On 04/14/2017 12:34 AM, Michael S. Tsirkin wrote: > > On Thu, Apr 13, 2017 at 05:35:05PM +0800, Wei Wang wrote: > > > > So we don't need the bitmap to talk to host, it is just > > a data structure we chose to maintain lists of pages, right? > Right. bitmap is the way to gather pages to chunk. >

Not sure what version we're up to, but this reimplements extents using the new simpler structure described in this thread: https://www.redhat.com/archives/libguestfs/2019-March/msg00077.html I also fixed most of the things that Eric pointed out in the previous review, although I need to go back over his replies and check I've got everything. This needs a bit more testing. However the

I'm not sure exactly which version we're up to, but let's say it's version 4. I'm a lot happier with this version: - all filters have been reviewed and changed where I think that's necessary - can_extents is properly defined and implemented now - NBD protocol is followed - I believe it addresses all previous review points where possible The "only" thing

I want to post this but mainly for discussion and early review. It's not safe for these patches to all go upstream yet (because not all filters have been checked/adjusted), but if any patches were to go upstream then probably 1 & 2 only are safe. File, VDDK, memory and data plugins all work, although I have only done minimal testing on them. The current tests, such as they are, all

This has already been pushed upstream. I am simply posting these here so we have a reference in the mailing list in case we find bugs later (as I'm sure we will - it's a complex patch series). Great thanks to Eric Blake for tireless review on this one. It also seems to have identified a few minor bugs in qemu along the way. Rich.