search for: nozero2

...ne doing the > > koji runs, there's obviously another feedback cycle to go through. > > Sure I'll give your patch a go once I see it in git, thanks! Unfortunately no this didn't fix it. The log is: https://kojipkgs.fedoraproject.org//work/tasks/9782/48609782/build.log nozero2.img (for example) was originally: nozero2.img: 2048 allocated blocks of size 512 bytes, total size 1048576 but when we test it later it has grown to 4096 blocks: + for i in {2..6} ++ stat -c %b nozero2.img + test 4096 '!=' 2048 + echo 'nozero2.img was trimmed by mistake'...

...st-nozero.sh b/tests/test-nozero.sh index 1282586..fc22420 100755 --- a/tests/test-nozero.sh +++ b/tests/test-nozero.sh @@ -39,12 +39,14 @@ sock3=`mktemp -u` sock4=`mktemp -u` sock5a=`mktemp -u` sock5b=`mktemp -u` +sock6=`mktemp -u` files="nozero1.img nozero1.log $sock1 nozero1.pid nozero2.img nozero2.log $sock2 nozero2.pid nozero3.img nozero3.log $sock3 nozero3.pid nozero4.img nozero4.log $sock4 nozero4.pid nozero5.img nozero5a.log nozero5b.log $sock5a $sock5b - nozero5a.pid nozero5b.pid" + nozero5a.pid nozero5b.pid + nozero6.img nozero...

...= nbd_pread, .pwrite = nbd_pwrite, diff --git a/tests/test-nozero.sh b/tests/test-nozero.sh index 95ed045..57c4452 100755 --- a/tests/test-nozero.sh +++ b/tests/test-nozero.sh @@ -36,7 +36,9 @@ set -e files="nozero1.img nozero1.log nozero1.sock nozero1.pid nozero2.img nozero2.log nozero2.sock nozero2.pid nozero3.img nozero3.log nozero3.sock nozero3.pid - nozero4.img nozero4.log nozero4.sock nozero4.pid" + nozero4.img nozero4.log nozero4.sock nozero4.pid + nozero5.img nozero5a.log nozero5b.log nozero5a.sock nozero5b.sock +...

...ji.fedoraproject.org/koji/taskinfo?taskID=48259627 log: https://kojipkgs.fedoraproject.org//work/tasks/9762/48259762/build.log The error is “nozero6.img was trimmed by mistake”. I added “set -x” to the script earlier today so we can see exactly what's wrong, and it is that: ++ stat -c %b nozero2.img ++ stat -c %b nozero6.img + test 4096 '!=' 2048 + echo 'nozero6.img was trimmed by mistake' AFAICT what this means is that nozero2.img is growing during the test (from 2048 to 4096 blocks). When I run the test locally this file stays at 2048 blocks the whole time, and th...

On 8/1/20 12:39 PM, Richard W.M. Jones wrote: > On Sat, Aug 01, 2020 at 08:46:11AM +0100, Richard W.M. Jones wrote: >> >> One thing I noticed which is a bit odd is: >> >> $ rm file; for f in {0..1023}; do printf '%1024s' .; done > file; stat -c "%b %B" file >> 2048 512 >> $ rm file; for f in {0..1023}; do printf '%1024s' .

...le). exit 77 - -# The cleanup() function is called implicitly on exit. diff --git a/tests/test-nozero.sh b/tests/test-nozero.sh index 239d4bd..c22363b 100755 --- a/tests/test-nozero.sh +++ b/tests/test-nozero.sh @@ -61,18 +61,10 @@ if test "$(stat -c %b nozero1.img)" = "$(stat -c %b nozero2.img)"; then fi cp nozero2.img nozero1.img -pid1= pid2= pid3= pid4= pid5a= pid5b= - -# Kill any nbdkit processes on exit. +# For easier debugging, dump the final log files before removing them +# on exit. cleanup () { - test "$pid1" && kill $pid1 - test "$pid2...

...gin: even though server side does not advertise # ZERO, the client side still exposes it, and just skips calling nbd's .zero -nbdkit -P nozero1.pid -U nozero1.sock --filter=log \ +start_nbdkit -P nozero1.pid -U nozero1.sock --filter=log \ file logfile=nozero1.log nozero1.img -nbdkit -P nozero2.pid -U nozero2.sock --filter=log --filter=nozero \ +start_nbdkit -P nozero2.pid -U nozero2.sock --filter=log --filter=nozero \ file logfile=nozero2.log nozero2.img -nbdkit -P nozero3.pid -U nozero3.sock --filter=log --filter=nozero \ +start_nbdkit -P nozero3.pid -U nozero3.sock --filter=log...

...skID=48259627 > log: https://kojipkgs.fedoraproject.org//work/tasks/9762/48259762/build.log > > The error is “nozero6.img was trimmed by mistake”. I added “set -x” > to the script earlier today so we can see exactly what's wrong, and it > is that: > > ++ stat -c %b nozero2.img > ++ stat -c %b nozero6.img > + test 4096 '!=' 2048 > + echo 'nozero6.img was trimmed by mistake' Hmm, maybe it is file-system dependent (not all filesystems reserve the same amount of space for a sparse file - that's something that qemu iotests keep on...

...of nbd plugin: even though server side does not advertise # ZERO, the client side still exposes it, and just skips calling nbd's .zero nbdkit -P nozero1.pid -U nozero1.sock --filter=log \ - file logfile=nozero1.log file=nozero1.img + file logfile=nozero1.log nozero1.img nbdkit -P nozero2.pid -U nozero2.sock --filter=log --filter=nozero \ - file logfile=nozero2.log file=nozero2.img + file logfile=nozero2.log nozero2.img nbdkit -P nozero3.pid -U nozero3.sock --filter=log --filter=nozero \ - file logfile=nozero3.log file=nozero3.img zeromode=emulate + file log...

...of nbd plugin: even though server side does not advertise # ZERO, the client side still exposes it, and just skips calling nbd's .zero nbdkit -P nozero1.pid -U nozero1.sock --filter=log \ - file logfile=nozero1.log file=nozero1.img + file logfile=nozero1.log nozero1.img nbdkit -P nozero2.pid -U nozero2.sock --filter=log --filter=nozero \ - file logfile=nozero2.log file=nozero2.img + file logfile=nozero2.log nozero2.img nbdkit -P nozero3.pid -U nozero3.sock --filter=log --filter=nozero \ - file logfile=nozero3.log file=nozero3.img zeromode=emulate + file log...

Combine much common code into tests/functions.sh. Patch 1: Preparation for patch 3. Patch 2: Fix a long-standing bug in how man pages links are generated. Patch 3: Common code for iterating a test function over every plugin. Patch 4: Common code for starting nbdkit in a test and waiting for the PID file to appear. This is the largest and most complex of the patches but is

v1 was here: https://www.redhat.com/archives/libguestfs/2018-September/msg00057.html v2: - Fix tab vs spaces in configure.ac. - To generate list of plugins, use printf instead of xargs. - Use 'source ./functions.sh' instead of 'source functions'. - functions.sh: Consistent quoting in foreach_plugin function. - functions.sh: Change the contract of start_nbdkit so it

Remove the need to use file= (and in future other) parameters for many plugins. eg. Using the file plugin becomes: nbdkit file disk.img Rich.

v1 was here: https://www.redhat.com/archives/libguestfs/2018-September/msg00024.html v2: - As discussed in the patch review, tighten up the characters permitted in keys. - Update documentation to note that relative paths can be made safe by prefixing with ./ and absolute paths do not need any extra steps. - I pushed patch 1/6 from the v1 series since it was just a trivial

v1: https://www.redhat.com/archives/libguestfs/2018-September/msg00024.html v2: https://www.redhat.com/archives/libguestfs/2018-September/msg00034.html v3: - Fixed is_config_key zero length test. - Fixed is_config_key so it uses strspn and is not O(n^2). - Changed >= 1.7 to >= 1.8 in the documentation. Rich.

After more than a month since v2 [1], I've finally got my FUA support series polished. This is all of my outstanding patches, even though some of them were originally posted in separate threads from the original FUA post [2], [3] [1] https://www.redhat.com/archives/libguestfs/2018-January/msg00113.html [2] https://www.redhat.com/archives/libguestfs/2018-January/msg00219.html [3]