search for: nozero1

...= nozero_zero, }; diff --git a/tests/test-nozero.sh b/tests/test-nozero.sh index 1282586..fc22420 100755 --- a/tests/test-nozero.sh +++ b/tests/test-nozero.sh @@ -39,12 +39,14 @@ sock3=`mktemp -u` sock4=`mktemp -u` sock5a=`mktemp -u` sock5b=`mktemp -u` +sock6=`mktemp -u` files="nozero1.img nozero1.log $sock1 nozero1.pid nozero2.img nozero2.log $sock2 nozero2.pid nozero3.img nozero3.log $sock3 nozero3.pid nozero4.img nozero4.log $sock4 nozero4.pid nozero5.img nozero5a.log nozero5b.log $sock5a $sock5b - nozero5a.pid nozero5b.pid" + n...

...can_zero, .can_fua = nbd_can_fua, .pread = nbd_pread, .pwrite = nbd_pwrite, diff --git a/tests/test-nozero.sh b/tests/test-nozero.sh index 95ed045..57c4452 100755 --- a/tests/test-nozero.sh +++ b/tests/test-nozero.sh @@ -36,7 +36,9 @@ set -e files="nozero1.img nozero1.log nozero1.sock nozero1.pid nozero2.img nozero2.log nozero2.sock nozero2.pid nozero3.img nozero3.log nozero3.sock nozero3.pid - nozero4.img nozero4.log nozero4.sock nozero4.pid" + nozero4.img nozero4.log nozero4.sock nozero4.pid + nozero5.img noze...

...on exit. diff --git a/tests/test-nozero.sh b/tests/test-nozero.sh index 904d822..33456e1 100755 --- a/tests/test-nozero.sh +++ b/tests/test-nozero.sh @@ -31,6 +31,7 @@ # OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF # SUCH DAMAGE. +source functions.sh set -e files="nozero1.img nozero1.log nozero1.sock nozero1.pid @@ -101,40 +102,24 @@ trap cleanup INT QUIT TERM EXIT ERR # 4: log after filter with zeromode=emulate, to ensure no ZERO to plugin # 5a/b: both sides of nbd plugin: even though server side does not advertise # ZERO, the client side still exposes it, and j...

...ng # only that nbdkit can create the file). exit 77 - -# The cleanup() function is called implicitly on exit. diff --git a/tests/test-nozero.sh b/tests/test-nozero.sh index 239d4bd..c22363b 100755 --- a/tests/test-nozero.sh +++ b/tests/test-nozero.sh @@ -61,18 +61,10 @@ if test "$(stat -c %b nozero1.img)" = "$(stat -c %b nozero2.img)"; then fi cp nozero2.img nozero1.img -pid1= pid2= pid3= pid4= pid5a= pid5b= - -# Kill any nbdkit processes on exit. +# For easier debugging, dump the final log files before removing them +# on exit. cleanup () { - test "$pid1" &am...

Combine much common code into tests/functions.sh. Patch 1: Preparation for patch 3. Patch 2: Fix a long-standing bug in how man pages links are generated. Patch 3: Common code for iterating a test function over every plugin. Patch 4: Common code for starting nbdkit in a test and waiting for the PID file to appear. This is the largest and most complex of the patches but is

v1 was here: https://www.redhat.com/archives/libguestfs/2018-September/msg00057.html v2: - Fix tab vs spaces in configure.ac. - To generate list of plugins, use printf instead of xargs. - Use 'source ./functions.sh' instead of 'source functions'. - functions.sh: Consistent quoting in foreach_plugin function. - functions.sh: Change the contract of start_nbdkit so it

.....904d822 100755 --- a/tests/test-nozero.sh +++ b/tests/test-nozero.sh @@ -102,15 +102,15 @@ trap cleanup INT QUIT TERM EXIT ERR # 5a/b: both sides of nbd plugin: even though server side does not advertise # ZERO, the client side still exposes it, and just skips calling nbd's .zero nbdkit -P nozero1.pid -U nozero1.sock --filter=log \ - file logfile=nozero1.log file=nozero1.img + file logfile=nozero1.log nozero1.img nbdkit -P nozero2.pid -U nozero2.sock --filter=log --filter=nozero \ - file logfile=nozero2.log file=nozero2.img + file logfile=nozero2.log nozero2.img nbd...

.....904d822 100755 --- a/tests/test-nozero.sh +++ b/tests/test-nozero.sh @@ -102,15 +102,15 @@ trap cleanup INT QUIT TERM EXIT ERR # 5a/b: both sides of nbd plugin: even though server side does not advertise # ZERO, the client side still exposes it, and just skips calling nbd's .zero nbdkit -P nozero1.pid -U nozero1.sock --filter=log \ - file logfile=nozero1.log file=nozero1.img + file logfile=nozero1.log nozero1.img nbdkit -P nozero2.pid -U nozero2.sock --filter=log --filter=nozero \ - file logfile=nozero2.log file=nozero2.img + file logfile=nozero2.log nozero2.img nbd...

...ge! # diff --git a/tests/test-nozero.sh b/tests/test-nozero.sh index 904d822..239d4bd 100755 --- a/tests/test-nozero.sh +++ b/tests/test-nozero.sh @@ -31,6 +31,7 @@ # OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF # SUCH DAMAGE. +source ./functions.sh set -e files="nozero1.img nozero1.log nozero1.sock nozero1.pid @@ -65,10 +66,6 @@ pid1= pid2= pid3= pid4= pid5a= pid5b= # Kill any nbdkit processes on exit. cleanup () { - status=$? - trap '' INT QUIT TERM EXIT ERR - echo $0: cleanup: exit code $status - test "$pid1" && kill $p...

Remove the need to use file= (and in future other) parameters for many plugins. eg. Using the file plugin becomes: nbdkit file disk.img Rich.

v1 was here: https://www.redhat.com/archives/libguestfs/2018-September/msg00024.html v2: - As discussed in the patch review, tighten up the characters permitted in keys. - Update documentation to note that relative paths can be made safe by prefixing with ./ and absolute paths do not need any extra steps. - I pushed patch 1/6 from the v1 series since it was just a trivial

v1: https://www.redhat.com/archives/libguestfs/2018-September/msg00024.html v2: https://www.redhat.com/archives/libguestfs/2018-September/msg00034.html v3: - Fixed is_config_key zero length test. - Fixed is_config_key so it uses strspn and is not O(n^2). - Changed >= 1.7 to >= 1.8 in the documentation. Rich.

After more than a month since v2 [1], I've finally got my FUA support series polished. This is all of my outstanding patches, even though some of them were originally posted in separate threads from the original FUA post [2], [3] [1] https://www.redhat.com/archives/libguestfs/2018-January/msg00113.html [2] https://www.redhat.com/archives/libguestfs/2018-January/msg00219.html [3]