search for: nouveau_xv

...scope ... 1193: if (newTTSize <= destination_buffer->size) { ... // Used in this scope ... 1248: } else { ... // Used in this scope ... 1316: } // Not used in this scope Warning reported by gcc 8.2: nouveau_xv.c: In function ‘NVPutImage’: nouveau_xv.c:1195:7: warning: declaration of ‘i’ shadows a previous local [-Wshadow] int i = 0; ^ nouveau_xv.c:1073:11: note: shadowed declaration is here int ret, i; ^ Signed-off-by: Rhys Kidd <rhyskidd at gmail.com> --- src/nouveau_xv.c...

Fixes warning with gcc 8.2: nouveau_xv.c: In function ‘NVInitVideo’: nouveau_xv.c:2247:68: warning: passing argument 2 of ‘vlCreateAdaptorXvMC’ discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers] adaptorsXvMC[0] = vlCreateAdaptorXvMC(pScreen, textureAdaptor[0]->name);...

...9;t need to take over ownership of the name pointer, so yes - I guess it's being silly in one respect by not being specific about const. > > On Sat, Jan 19, 2019 at 6:30 PM Rhys Kidd <rhyskidd at gmail.com> wrote: > > > > Fixes warning with gcc 8.2: > > > > nouveau_xv.c: In function ‘NVInitVideo’: > > nouveau_xv.c:2247:68: warning: passing argument 2 of > ‘vlCreateAdaptorXvMC’ discards ‘const’ qualifier from pointer target type > [-Wdiscarded-qualifiers] > > adaptorsXvMC[0] = vlCreateAdaptorXvMC(pScreen, > textureAdaptor[0]->name); &g...

Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu> --- src/nouveau_xv.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/nouveau_xv.c b/src/nouveau_xv.c index 8eafcf0..567e30c 100644 --- a/src/nouveau_xv.c +++ b/src/nouveau_xv.c @@ -552,8 +552,11 @@ NVCopyNV12ColorPlanes(unsigned char *src1, unsigned char *src2, if (e) { unsigned s...

...imirkin at alum.mit.edu> --- I've been running with this patch (+ some extra debug info) for a while and haven't seen any ill effects in Xv rendering. The debugging info I had added suggests that the overruns are gone when the image is dragged partially off the screen on the left. src/nouveau_xv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/nouveau_xv.c b/src/nouveau_xv.c index f7dc2bc..8eafcf0 100644 --- a/src/nouveau_xv.c +++ b/src/nouveau_xv.c @@ -1095,7 +1095,7 @@ NVPutImage(ScrnInfoPtr pScrn, short src_x, short src_y, short drw_x, NVCopyNV12ColorPl...

Is vlCreateAdaptorXvMC just silly, or does it really want to take ownership of the name pointer? On Sat, Jan 19, 2019 at 6:30 PM Rhys Kidd <rhyskidd at gmail.com> wrote: > > Fixes warning with gcc 8.2: > > nouveau_xv.c: In function ‘NVInitVideo’: > nouveau_xv.c:2247:68: warning: passing argument 2 of ‘vlCreateAdaptorXvMC’ discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers] > adaptorsXvMC[0] = vlCreateAdaptorXvMC(pScreen, textureAdaptor[0]->name); >...

Silences warning with gcc 8.2: nouveau_xv.c: In function ‘NVInitVideo’: nouveau_xv.c:2247:68: warning: passing argument 2 of ‘vlCreateAdaptorXvMC’ discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers] adaptorsXvMC[0] = vlCreateAdaptorXvMC(pScreen, textureAdaptor[0]->name);...

Warning reported by gcc 8.2: nouveau_xv.c: In function ‘NVPutImage’: nouveau_xv.c:1369:7: warning: declaration of ‘ret’ shadows a previous local [-Wshadow] int ret = BadImplementation; ^~~ nouveau_xv.c:1073:6: note: shadowed declaration is here int ret, i; ^~~ Fixes: a50bba6 ("xv: misc cleanups") Cc: Ben Skeg...

...clude/xorg/os.h:225) nouveau_exa.c:372:3: warning: 'Xfree' is deprecated (declared at /usr/include/xorg/os.h:234) nouveau_exa.c: In function 'nouveau_exa_destroy_pixmap': nouveau_exa.c:388:2: warning: 'Xfree' is deprecated (declared at /usr/include/xorg/os.h:234) CC nouveau_xv.lo nouveau_xv.c: In function 'NVSetupBlitVideo': nouveau_xv.c:1582:2: warning: 'Xcalloc' is deprecated (declared at /usr/include/xorg/os.h:225) (...) -------------------------------------------------- Kredyty hipoteczne z dop?at?. Sprawd? koniecznie! http://linkint.pl/f26ca

...ed function nouveau_wfb_init() dri2: Mark local create/destroy buffer and copy region functions as static xv: Mark local NVSetupTexturedVideo function as static xv/nv30,nv40: Mark local NV30GetSurfaceFormat and NV40GetSurfaceFormat as static src/nouveau_dri2.c | 12 ++++++------ src/nouveau_xv.c | 2 +- src/nv30_xv_tex.c | 2 +- src/nv40_xv_tex.c | 2 +- src/nv_proto.h | 1 - 5 files changed, 9 insertions(+), 10 deletions(-) -- 2.19.1

...e.com> --- This patch actually compiles. There are still a couple clang warnings, but those are dead assignments and one dead initialization. If there is interest I can send patches for those as well. The clang results can be viewed at http://stuff.caurea.org/clang-static-analyzer/nouveau src/nouveau_xv.c | 114 ++++++++++++++++++++++++++---------------------------- 1 files changed, 55 insertions(+), 59 deletions(-) diff --git a/src/nouveau_xv.c b/src/nouveau_xv.c index 4437aa6..eb43207 100644 --- a/src/nouveau_xv.c +++ b/src/nouveau_xv.c @@ -920,7 +920,6 @@ NVPutImage(ScrnInfoPtr pScrn, short s...

https://bugs.freedesktop.org/show_bug.cgi?id=63263 Priority: medium Bug ID: 63263 Assignee: nouveau at lists.freedesktop.org Summary: X server crash in nouveau_xv.c:NVPutImage (NVCopyNV12ColorPlanes) QA Contact: xorg-team at lists.x.org Severity: normal Classification: Unclassified OS: Linux (All) Reporter: imirkin at alum.mit.edu Hardware: x86-64 (AMD64) Status: NEW...

Ostensibly it should probably be looking at the pixmap format. However it's always the window pixmap, so we can assume it's what we expect. Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu> --- src/nouveau_xv.c | 11 +++++++++-- src/nv50_xv.c | 3 ++- src/nvc0_xv.c | 3 ++- 3 files changed, 13 insertions(+), 4 deletions(-) diff --git a/src/nouveau_xv.c b/src/nouveau_xv.c index 0b6c4d4..2f1979a 100644 --- a/src/nouveau_xv.c +++ b/src/nouveau_xv.c @@ -112,6 +112,13 @@ XF86VideoFormatRec NVFormats...

memcpy() goes from taking 45% to 66% of total function time, which translates to a 30% decrease in NVPutImage runtime. Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu> --- src/nouveau_xv.c | 33 ++++++++++++++++++++++++++------- 1 file changed, 26 insertions(+), 7 deletions(-) diff --git a/src/nouveau_xv.c b/src/nouveau_xv.c index 567e30c..5569b7c 100644 --- a/src/nouveau_xv.c +++ b/src/nouveau_xv.c @@ -25,6 +25,8 @@ #include "config.h" #endif +#include <immintrin...

Not clear what the depth % 8 was trying to protect against, but it was breaking 30bpp visuals with DRI3. Add it in to ensure that bitsPerPixel % 8 is 0, since there is plenty of bpp/8 math in the driver. Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu> --- src/nouveau_dri2.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/nouveau_dri2.c b/src/nouveau_dri2.c

in nv10_exa.c : check_texture does : if (w > 2046 || h > 2046) NOUVEAU_FALLBACK("picture too large, %dx%d\n", w, h); check_render_target does : if (w > 4096 || h > 4096) return FALSE; So we have different size limits for the source and the destination ? Another thing is that nv20 uses nv10_exa.c code, and the limit in

xorg-server can be built without glamor, which leads to: CC nouveau_xv.lo In file included from nouveau_xv.c:41:0: nouveau_glamor.h:12:20: fatal error: glamor.h: No such file or directory compilation terminated. Signed-off-by: Marcin Slusarz <marcin.slusarz at gmail.com> --- configure.ac | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git...

...ces are the monitor will come back on, but the display remains black until the next time the X server is restarted. Signed-off-by: Lyude <lyude at redhat.com> --- src/drmmode_display.c | 14 ++++++++++++-- src/nouveau_dri2.c | 14 +++++++++----- src/nouveau_present.c | 6 +++--- src/nouveau_xv.c | 2 +- src/nv_proto.h | 1 + 5 files changed, 26 insertions(+), 11 deletions(-) diff --git a/src/drmmode_display.c b/src/drmmode_display.c index b6c9bb9..dd9fa27 100644 --- a/src/drmmode_display.c +++ b/src/drmmode_display.c @@ -65,6 +65,7 @@ typedef struct { uint32_t rotate_...

...Mirkin <imirkin at alum.mit.edu> --- Note: this won't work for GM20x - we need to allow TIC format to be updated for that to work. But this is a step in that direction. src/Makefile.am | 16 ++++++++ src/nouveau_copy.c | 1 + src/nouveau_exa.c | 2 +- src/nouveau_xv.c | 2 +- src/nv_accel_common.c | 1 + src/nv_driver.c | 1 + src/nvc0_accel.c | 37 ++++++++++++++--- src/nvc0_exa.c | 48 ++++++++++++++++++++-- src/nvc0_xv.c | 48 ++++++++++++++++++++-- src/shader/Makefile | 23 ++++++++---...

..., indexed by vertex id. This approach could be used for all nvc0 generations, but I didn't want to rock the boat. Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu> --- src/Makefile.am | 16 ++++++++ src/nouveau_copy.c | 1 + src/nouveau_exa.c | 2 +- src/nouveau_xv.c | 2 +- src/nv_accel_common.c | 1 + src/nv_driver.c | 1 + src/nvc0_accel.c | 37 ++++++++++++++--- src/nvc0_exa.c | 48 ++++++++++++++++++++-- src/nvc0_xv.c | 48 ++++++++++++++++++++-- src/shader/Makefile | 23 ++++++++---...